From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 891C4FA3728 for ; Wed, 16 Oct 2019 22:02:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5150320872 for ; Wed, 16 Oct 2019 22:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263328; bh=RR3rpb/NWDOjZesUdv/4qJSanHshBDUM1P6TXdKXDcg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=u5ISNCsoigdZ5zOsncxqB2ur8yXzvHShvESHAxViJGAp7tJqboncUd7wDg1Bo5YKr kw96lA+/CvHmVjpgQ/MzcfseDgHOqIorTQbTWg0C3CyfE/r0AYtKpNtWwMOAB6lFPu SY1T3YcedUXiJOz9oXJMMgvg2iR9OW+ck/UDfk6E= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2438658AbfJPV7w (ORCPT ); Wed, 16 Oct 2019 17:59:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:52708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2438276AbfJPV6t (ORCPT ); Wed, 16 Oct 2019 17:58:49 -0400 Received: from localhost (unknown [192.55.54.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 75C3321928; Wed, 16 Oct 2019 21:58:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571263128; bh=RR3rpb/NWDOjZesUdv/4qJSanHshBDUM1P6TXdKXDcg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uCtyvcH5amPypjJfAUcInV18x+1DGPOF38T+14Hm5YzG0kMrHkLklvPAYIVKTulJc XP3tNQaGbJLtaoNwXtIaWwInWAA7vvORvvk1hjqOZvJfBsoDsMpcyzEch4QVBwivms nyjpNWrEJTElQvrDUdLVKXSCTpO8wKb2YeV4+BQg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost Subject: [PATCH 5.3 051/112] staging: vt6655: Fix memory leak in vt6655_probe Date: Wed, 16 Oct 2019 14:50:43 -0700 Message-Id: <20191016214857.295568959@linuxfoundation.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20191016214844.038848564@linuxfoundation.org> References: <20191016214844.038848564@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Navid Emamdoost commit 80b15db5e1e9c3300de299b2d43d1aafb593e6ac upstream. In vt6655_probe, if vnt_init() fails the cleanup code needs to be called like other error handling cases. The call to device_free_info() is added. Fixes: 67013f2c0e58 ("staging: vt6655: mac80211 conversion add main mac80211 functions") Signed-off-by: Navid Emamdoost Cc: stable Link: https://lore.kernel.org/r/20191004200319.22394-1-navid.emamdoost@gmail.com Signed-off-by: Greg Kroah-Hartman --- drivers/staging/vt6655/device_main.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/staging/vt6655/device_main.c +++ b/drivers/staging/vt6655/device_main.c @@ -1748,8 +1748,10 @@ vt6655_probe(struct pci_dev *pcid, const priv->hw->max_signal = 100; - if (vnt_init(priv)) + if (vnt_init(priv)) { + device_free_info(priv); return -ENODEV; + } device_print_info(priv); pci_set_drvdata(pcid, priv);