All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Andy Shevchenko <andriy.shevchenko@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	linux-spi@vger.kernel.org,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Sam Ravnborg <sam@ravnborg.org>, Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH] spi: pxa2xx: Set controller->max_transfer_size in dma mode
Date: Wed, 16 Oct 2019 22:49:18 +0100	[thread overview]
Message-ID: <20191016214918.GA11473@sirena.co.uk> (raw)
In-Reply-To: <36610873-fa30-a286-d05c-5eceb3cbcb57@tronnes.org>


[-- Attachment #1.1: Type: text/plain, Size: 767 bytes --]

On Wed, Oct 16, 2019 at 11:30:51PM +0200, Noralf Trønnes wrote:

> As Andy mentioned, ->max_transfer_size is a callback:

> struct spi_controller {
> 	/*
> 	 * on some hardware transfer / message size may be constrained
> 	 * the limit may depend on device transfer settings
> 	 */
> 	size_t (*max_transfer_size)(struct spi_device *spi);

> (I looked at its users and they all return a static or probe time value
> so not sure why it's a callback.)

Huh, I wonder why we did that...  I can't find any clear record, and
like you say nothing is using it so we should probably fix it - however
that's best done separately to this :/  Sorry for the confusion, I
didn't register what Andy was saying as being pointing out the current
state of the code.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: Mark Brown <broonie@kernel.org>
To: "Noralf Trønnes" <noralf@tronnes.org>
Cc: linux-arm-kernel@lists.infradead.org,
	Andy Shevchenko <andriy.shevchenko@intel.com>,
	Daniel Vetter <daniel.vetter@ffwll.ch>,
	Robert Jarzmik <robert.jarzmik@free.fr>,
	Haojian Zhuang <haojian.zhuang@gmail.com>,
	linux-spi@vger.kernel.org,
	DRI Development <dri-devel@lists.freedesktop.org>,
	Sam Ravnborg <sam@ravnborg.org>, Daniel Mack <daniel@zonque.org>
Subject: Re: [PATCH] spi: pxa2xx: Set controller->max_transfer_size in dma mode
Date: Wed, 16 Oct 2019 22:49:18 +0100	[thread overview]
Message-ID: <20191016214918.GA11473@sirena.co.uk> (raw)
In-Reply-To: <36610873-fa30-a286-d05c-5eceb3cbcb57@tronnes.org>


[-- Attachment #1.1: Type: text/plain, Size: 767 bytes --]

On Wed, Oct 16, 2019 at 11:30:51PM +0200, Noralf Trønnes wrote:

> As Andy mentioned, ->max_transfer_size is a callback:

> struct spi_controller {
> 	/*
> 	 * on some hardware transfer / message size may be constrained
> 	 * the limit may depend on device transfer settings
> 	 */
> 	size_t (*max_transfer_size)(struct spi_device *spi);

> (I looked at its users and they all return a static or probe time value
> so not sure why it's a callback.)

Huh, I wonder why we did that...  I can't find any clear record, and
like you say nothing is using it so we should probably fix it - however
that's best done separately to this :/  Sorry for the confusion, I
didn't register what Andy was saying as being pointing out the current
state of the code.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-10-16 21:49 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 19:57 [PATCH] spi: pxa2xx: Set controller->max_transfer_size in dma mode Daniel Vetter
2019-10-16 19:57 ` Daniel Vetter
2019-10-16 21:30 ` Noralf Trønnes
2019-10-16 21:30   ` Noralf Trønnes
2019-10-16 21:49   ` Mark Brown [this message]
2019-10-16 21:49     ` Mark Brown
2019-10-17  6:44 ` Daniel Vetter
2019-10-17  7:06   ` Andy Shevchenko
2019-10-17  7:06     ` Andy Shevchenko
2019-10-21 11:08     ` Andy Shevchenko
2019-10-21 11:08       ` Andy Shevchenko
2019-10-21 11:35       ` Mark Brown
2019-10-21 11:35         ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191016214918.GA11473@sirena.co.uk \
    --to=broonie@kernel.org \
    --cc=andriy.shevchenko@intel.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=daniel@zonque.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=haojian.zhuang@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-spi@vger.kernel.org \
    --cc=noralf@tronnes.org \
    --cc=robert.jarzmik@free.fr \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.