From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C293AECE58D for ; Thu, 17 Oct 2019 19:24:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9A1AC20869 for ; Thu, 17 Oct 2019 19:24:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2503518AbfJQTYp (ORCPT ); Thu, 17 Oct 2019 15:24:45 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:40876 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393438AbfJQTYn (ORCPT ); Thu, 17 Oct 2019 15:24:43 -0400 Received: from localhost (unknown [IPv6:2603:3023:50c:85e1:5314:1b70:2a53:887e]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id E33AF14047D0C; Thu, 17 Oct 2019 12:24:42 -0700 (PDT) Date: Thu, 17 Oct 2019 15:24:42 -0400 (EDT) Message-Id: <20191017.152442.339047834113245608.davem@davemloft.net> To: f.fainelli@gmail.com Cc: netdev@vger.kernel.org, andrew@lunn.ch, linux-kernel@vger.kernel.org, hkallweit1@gmail.com, bcm-kernel-feedback-list@broadcom.com, olteanv@gmail.com, rmk+kernel@armlinux.org.uk, cphealy@gmail.com, joabreu@synopsys.com Subject: Re: [PATCH net-next 0/2] net: phy: Add ability to debug RGMII connections From: David Miller In-Reply-To: <20191015224953.24199-1-f.fainelli@gmail.com> References: <20191015224953.24199-1-f.fainelli@gmail.com> X-Mailer: Mew version 6.8 on Emacs 26.2 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 17 Oct 2019 12:24:43 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Florian Fainelli Date: Tue, 15 Oct 2019 15:49:51 -0700 > This patch series is primarily intended to reduce the amount of support > involved with bringing up RGMII connections with the PHY library (or > PHYLINK) for that matter. The idea consists in looping back a packet we > just crafted and check whether it did came back correctly, if that is > the case, we are good, else we must try configuring the PHY for > different delays until it either works or we bail out. > > As indicated in the commit message, future improvements could probably > be done in order to converge faster on the appropriate configuration. > This is intended to be PHY centric, and we are not playing with delays > on the MAC side other than through the parsing of the phydev->interface. > > The typical output would look like this: > > [ 62.668701] bcmgenet 8f00000.ethernet eth0: Trying "rgmii-txid" PHY interface > [ 62.676094] bcmgenet 8f00000.ethernet eth0: Determined "rgmii-txid" to be correct > > Feedback highly welcome on this! Looks like there was some feedback, please address. Thank you.