From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 665F0FA372A for ; Thu, 17 Oct 2019 15:08:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 369F720820 for ; Thu, 17 Oct 2019 15:08:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2440386AbfJQPIZ (ORCPT ); Thu, 17 Oct 2019 11:08:25 -0400 Received: from mx1.redhat.com ([209.132.183.28]:12187 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405952AbfJQPIZ (ORCPT ); Thu, 17 Oct 2019 11:08:25 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EC4F530789A0; Thu, 17 Oct 2019 15:08:23 +0000 (UTC) Received: from gondolin (dhcp-192-202.str.redhat.com [10.33.192.202]) by smtp.corp.redhat.com (Postfix) with ESMTP id A8FD860872; Thu, 17 Oct 2019 15:07:57 +0000 (UTC) Date: Thu, 17 Oct 2019 17:07:55 +0200 From: Cornelia Huck To: Jason Wang Cc: kvm@vger.kernel.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org, intel-gvt-dev@lists.freedesktop.org, kwankhede@nvidia.com, alex.williamson@redhat.com, mst@redhat.com, tiwei.bie@intel.com, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, maxime.coquelin@redhat.com, cunming.liang@intel.com, zhihong.wang@intel.com, rob.miller@broadcom.com, xiao.w.wang@intel.com, haotian.wang@sifive.com, zhenyuw@linux.intel.com, zhi.a.wang@intel.com, jani.nikula@linux.intel.com, joonas.lahtinen@linux.intel.com, rodrigo.vivi@intel.com, airlied@linux.ie, daniel@ffwll.ch, farman@linux.ibm.com, pasic@linux.ibm.com, sebott@linux.ibm.com, oberpar@linux.ibm.com, heiko.carstens@de.ibm.com, gor@linux.ibm.com, borntraeger@de.ibm.com, akrowiak@linux.ibm.com, freude@linux.ibm.com, lingshan.zhu@intel.com, idos@mellanox.com, eperezma@redhat.com, lulu@redhat.com, parav@mellanox.com, christophe.de.dinechin@gmail.com, kevin.tian@intel.com, stefanha@redhat.com Subject: Re: [PATCH V4 3/6] mdev: introduce device specific ops Message-ID: <20191017170755.15506ada.cohuck@redhat.com> In-Reply-To: <20191017104836.32464-4-jasowang@redhat.com> References: <20191017104836.32464-1-jasowang@redhat.com> <20191017104836.32464-4-jasowang@redhat.com> Organization: Red Hat GmbH MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 17 Oct 2019 15:08:24 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 17 Oct 2019 18:48:33 +0800 Jason Wang wrote: > Currently, except for the create and remove, the rest of > mdev_parent_ops is designed for vfio-mdev driver only and may not help > for kernel mdev driver. With the help of class id, this patch > introduces device specific callbacks inside mdev_device > structure. This allows different set of callback to be used by > vfio-mdev and virtio-mdev. > > Signed-off-by: Jason Wang > --- > .../driver-api/vfio-mediated-device.rst | 25 +++++---- > MAINTAINERS | 1 + > drivers/gpu/drm/i915/gvt/kvmgt.c | 18 ++++--- > drivers/s390/cio/vfio_ccw_ops.c | 18 ++++--- > drivers/s390/crypto/vfio_ap_ops.c | 14 +++-- > drivers/vfio/mdev/mdev_core.c | 18 +++++-- > drivers/vfio/mdev/mdev_private.h | 1 + > drivers/vfio/mdev/vfio_mdev.c | 37 ++++++------- > include/linux/mdev.h | 45 ++++------------ > include/linux/vfio_mdev.h | 52 +++++++++++++++++++ > samples/vfio-mdev/mbochs.c | 20 ++++--- > samples/vfio-mdev/mdpy.c | 20 ++++--- > samples/vfio-mdev/mtty.c | 18 ++++--- > 13 files changed, 184 insertions(+), 103 deletions(-) > create mode 100644 include/linux/vfio_mdev.h > > diff --git a/Documentation/driver-api/vfio-mediated-device.rst b/Documentation/driver-api/vfio-mediated-device.rst > index f9a78d75a67a..0cca84d19603 100644 > --- a/Documentation/driver-api/vfio-mediated-device.rst > +++ b/Documentation/driver-api/vfio-mediated-device.rst > @@ -152,11 +152,22 @@ callbacks per mdev parent device, per mdev type, or any other categorization. > Vendor drivers are expected to be fully asynchronous in this respect or > provide their own internal resource protection.) > > -The callbacks in the mdev_parent_ops structure are as follows: > - > -* open: open callback of mediated device > -* close: close callback of mediated device > -* ioctl: ioctl callback of mediated device > +As multiple types of mediated devices may be supported, the device > +must set up the class id and the device specific callbacks in create() s/in create()/in the create()/ > +callback. E.g for vfio-mdev device it needs to be done through: "Each class provides a helper function to do so; e.g. for vfio-mdev devices, the function to be called is:" ? > + > + int mdev_set_vfio_ops(struct mdev_device *mdev, > + const struct vfio_mdev_ops *vfio_ops); > + > +The class id (set to MDEV_CLASS_ID_VFIO) is used to match a device "(set by this helper function to MDEV_CLASS_ID_VFIO)" ? > +with an mdev driver via its id table. The device specific callbacks > +(specified in *ops) are obtainable via mdev_get_dev_ops() (for use by "(specified in *vfio_ops by the caller)" ? > +the mdev bus driver). A vfio-mdev device (class id MDEV_CLASS_ID_VFIO) > +uses the following device-specific ops: > + > +* open: open callback of vfio mediated device > +* close: close callback of vfio mediated device > +* ioctl: ioctl callback of vfio mediated device > * read : read emulation callback > * write: write emulation callback > * mmap: mmap emulation callback > @@ -167,10 +178,6 @@ register itself with the mdev core driver:: > extern int mdev_register_device(struct device *dev, > const struct mdev_parent_ops *ops); > > -It is also required to specify the class_id in create() callback through:: > - > - int mdev_set_class(struct mdev_device *mdev, u16 id); > - I'm wondering if this patch set should start out with introducing helper functions already (i.e. don't introduce mdev_set_class(), but start out with mdev_set_class_vfio() which will gain the *vfio_ops argument in this patch.) > However, the mdev_parent_ops structure is not required in the function call > that a driver should use to unregister itself with the mdev core driver:: > (...) > diff --git a/drivers/vfio/mdev/mdev_core.c b/drivers/vfio/mdev/mdev_core.c > index 3a9c52d71b4e..d0f3113c8071 100644 > --- a/drivers/vfio/mdev/mdev_core.c > +++ b/drivers/vfio/mdev/mdev_core.c > @@ -45,15 +45,23 @@ void mdev_set_drvdata(struct mdev_device *mdev, void *data) > } > EXPORT_SYMBOL(mdev_set_drvdata); > > -/* Specify the class for the mdev device, this must be called during > - * create() callback. > +/* Specify the VFIO device ops for the mdev device, this > + * must be called during create() callback for VFIO mdev device. > */ /* * Specify the mdev device to be a VFIO mdev device, and set the * VFIO devices ops for it. This must be called from the create() * callback for VFIO mdev devices. */ ? > -void mdev_set_class(struct mdev_device *mdev, u16 id) > +void mdev_set_vfio_ops(struct mdev_device *mdev, > + const struct vfio_mdev_device_ops *vfio_ops) > { > WARN_ON(mdev->class_id); > - mdev->class_id = id; > + mdev->class_id = MDEV_CLASS_ID_VFIO; > + mdev->device_ops = vfio_ops; > } > -EXPORT_SYMBOL(mdev_set_class); > +EXPORT_SYMBOL(mdev_set_vfio_ops); > + > +const void *mdev_get_dev_ops(struct mdev_device *mdev) > +{ > + return mdev->device_ops; > +} > +EXPORT_SYMBOL(mdev_get_dev_ops); > > struct device *mdev_dev(struct mdev_device *mdev) > { (...) The code change looks good to me; I'm just wondering if we should introduce mdev_set_class() at all (see above). From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cornelia Huck Subject: Re: [PATCH V4 3/6] mdev: introduce device specific ops Date: Thu, 17 Oct 2019 17:07:55 +0200 Message-ID: <20191017170755.15506ada.cohuck@redhat.com> References: <20191017104836.32464-1-jasowang@redhat.com> <20191017104836.32464-4-jasowang@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20191017104836.32464-4-jasowang@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Jason Wang Cc: stefanha@redhat.com, christophe.de.dinechin@gmail.com, kvm@vger.kernel.org, mst@redhat.com, airlied@linux.ie, heiko.carstens@de.ibm.com, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, kwankhede@nvidia.com, rob.miller@broadcom.com, linux-s390@vger.kernel.org, sebott@linux.ibm.com, lulu@redhat.com, eperezma@redhat.com, pasic@linux.ibm.com, borntraeger@de.ibm.com, haotian.wang@sifive.com, cunming.liang@intel.com, farman@linux.ibm.com, idos@mellanox.com, gor@linux.ibm.com, intel-gfx@lists.freedesktop.org, xiao.w.wang@intel.com, freude@linux.ibm.com, parav@mellanox.com, zhihong.wang@intel.com, intel-gvt-dev@lists.freedesktop.org, akrowiak@linux.ibm.com, oberpar@linux.ibm.com, tiwei.bie@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, maxime.coquelin@redhat.com, lingshan.zhu@intel.com List-Id: dri-devel@lists.freedesktop.org T24gVGh1LCAxNyBPY3QgMjAxOSAxODo0ODozMyArMDgwMApKYXNvbiBXYW5nIDxqYXNvd2FuZ0By ZWRoYXQuY29tPiB3cm90ZToKCj4gQ3VycmVudGx5LCBleGNlcHQgZm9yIHRoZSBjcmVhdGUgYW5k IHJlbW92ZSwgdGhlIHJlc3Qgb2YKPiBtZGV2X3BhcmVudF9vcHMgaXMgZGVzaWduZWQgZm9yIHZm aW8tbWRldiBkcml2ZXIgb25seSBhbmQgbWF5IG5vdCBoZWxwCj4gZm9yIGtlcm5lbCBtZGV2IGRy aXZlci4gV2l0aCB0aGUgaGVscCBvZiBjbGFzcyBpZCwgdGhpcyBwYXRjaAo+IGludHJvZHVjZXMg ZGV2aWNlIHNwZWNpZmljIGNhbGxiYWNrcyBpbnNpZGUgbWRldl9kZXZpY2UKPiBzdHJ1Y3R1cmUu IFRoaXMgYWxsb3dzIGRpZmZlcmVudCBzZXQgb2YgY2FsbGJhY2sgdG8gYmUgdXNlZCBieQo+IHZm aW8tbWRldiBhbmQgdmlydGlvLW1kZXYuCj4gCj4gU2lnbmVkLW9mZi1ieTogSmFzb24gV2FuZyA8 amFzb3dhbmdAcmVkaGF0LmNvbT4KPiAtLS0KPiAgLi4uL2RyaXZlci1hcGkvdmZpby1tZWRpYXRl ZC1kZXZpY2UucnN0ICAgICAgIHwgMjUgKysrKystLS0tCj4gIE1BSU5UQUlORVJTICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAxICsKPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUv Z3Z0L2t2bWd0LmMgICAgICAgICAgICAgIHwgMTggKysrKy0tLQo+ICBkcml2ZXJzL3MzOTAvY2lv L3ZmaW9fY2N3X29wcy5jICAgICAgICAgICAgICAgfCAxOCArKysrLS0tCj4gIGRyaXZlcnMvczM5 MC9jcnlwdG8vdmZpb19hcF9vcHMuYyAgICAgICAgICAgICB8IDE0ICsrKy0tCj4gIGRyaXZlcnMv dmZpby9tZGV2L21kZXZfY29yZS5jICAgICAgICAgICAgICAgICB8IDE4ICsrKysrLS0KPiAgZHJp dmVycy92ZmlvL21kZXYvbWRldl9wcml2YXRlLmggICAgICAgICAgICAgIHwgIDEgKwo+ICBkcml2 ZXJzL3ZmaW8vbWRldi92ZmlvX21kZXYuYyAgICAgICAgICAgICAgICAgfCAzNyArKysrKystLS0t LS0tCj4gIGluY2x1ZGUvbGludXgvbWRldi5oICAgICAgICAgICAgICAgICAgICAgICAgICB8IDQ1 ICsrKystLS0tLS0tLS0tLS0KPiAgaW5jbHVkZS9saW51eC92ZmlvX21kZXYuaCAgICAgICAgICAg ICAgICAgICAgIHwgNTIgKysrKysrKysrKysrKysrKysrKwo+ICBzYW1wbGVzL3ZmaW8tbWRldi9t Ym9jaHMuYyAgICAgICAgICAgICAgICAgICAgfCAyMCArKysrLS0tCj4gIHNhbXBsZXMvdmZpby1t ZGV2L21kcHkuYyAgICAgICAgICAgICAgICAgICAgICB8IDIwICsrKystLS0KPiAgc2FtcGxlcy92 ZmlvLW1kZXYvbXR0eS5jICAgICAgICAgICAgICAgICAgICAgIHwgMTggKysrKy0tLQo+ICAxMyBm aWxlcyBjaGFuZ2VkLCAxODQgaW5zZXJ0aW9ucygrKSwgMTAzIGRlbGV0aW9ucygtKQo+ICBjcmVh dGUgbW9kZSAxMDA2NDQgaW5jbHVkZS9saW51eC92ZmlvX21kZXYuaAo+IAo+IGRpZmYgLS1naXQg YS9Eb2N1bWVudGF0aW9uL2RyaXZlci1hcGkvdmZpby1tZWRpYXRlZC1kZXZpY2UucnN0IGIvRG9j dW1lbnRhdGlvbi9kcml2ZXItYXBpL3ZmaW8tbWVkaWF0ZWQtZGV2aWNlLnJzdAo+IGluZGV4IGY5 YTc4ZDc1YTY3YS4uMGNjYTg0ZDE5NjAzIDEwMDY0NAo+IC0tLSBhL0RvY3VtZW50YXRpb24vZHJp dmVyLWFwaS92ZmlvLW1lZGlhdGVkLWRldmljZS5yc3QKPiArKysgYi9Eb2N1bWVudGF0aW9uL2Ry aXZlci1hcGkvdmZpby1tZWRpYXRlZC1kZXZpY2UucnN0Cj4gQEAgLTE1MiwxMSArMTUyLDIyIEBA IGNhbGxiYWNrcyBwZXIgbWRldiBwYXJlbnQgZGV2aWNlLCBwZXIgbWRldiB0eXBlLCBvciBhbnkg b3RoZXIgY2F0ZWdvcml6YXRpb24uCj4gIFZlbmRvciBkcml2ZXJzIGFyZSBleHBlY3RlZCB0byBi ZSBmdWxseSBhc3luY2hyb25vdXMgaW4gdGhpcyByZXNwZWN0IG9yCj4gIHByb3ZpZGUgdGhlaXIg b3duIGludGVybmFsIHJlc291cmNlIHByb3RlY3Rpb24uKQo+ICAKPiAtVGhlIGNhbGxiYWNrcyBp biB0aGUgbWRldl9wYXJlbnRfb3BzIHN0cnVjdHVyZSBhcmUgYXMgZm9sbG93czoKPiAtCj4gLSog b3Blbjogb3BlbiBjYWxsYmFjayBvZiBtZWRpYXRlZCBkZXZpY2UKPiAtKiBjbG9zZTogY2xvc2Ug Y2FsbGJhY2sgb2YgbWVkaWF0ZWQgZGV2aWNlCj4gLSogaW9jdGw6IGlvY3RsIGNhbGxiYWNrIG9m IG1lZGlhdGVkIGRldmljZQo+ICtBcyBtdWx0aXBsZSB0eXBlcyBvZiBtZWRpYXRlZCBkZXZpY2Vz IG1heSBiZSBzdXBwb3J0ZWQsIHRoZSBkZXZpY2UKPiArbXVzdCBzZXQgdXAgdGhlIGNsYXNzIGlk IGFuZCB0aGUgZGV2aWNlIHNwZWNpZmljIGNhbGxiYWNrcyBpbiBjcmVhdGUoKQoKcy9pbiBjcmVh dGUoKS9pbiB0aGUgY3JlYXRlKCkvCgo+ICtjYWxsYmFjay4gRS5nIGZvciB2ZmlvLW1kZXYgZGV2 aWNlIGl0IG5lZWRzIHRvIGJlIGRvbmUgdGhyb3VnaDoKCiJFYWNoIGNsYXNzIHByb3ZpZGVzIGEg aGVscGVyIGZ1bmN0aW9uIHRvIGRvIHNvOyBlLmcuIGZvciB2ZmlvLW1kZXYKZGV2aWNlcywgdGhl IGZ1bmN0aW9uIHRvIGJlIGNhbGxlZCBpczoiCgo/Cgo+ICsKPiArICAgIGludCBtZGV2X3NldF92 ZmlvX29wcyhzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYsCj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgY29uc3Qgc3RydWN0IHZmaW9fbWRldl9vcHMgKnZmaW9fb3BzKTsKPiArCj4gK1RoZSBj bGFzcyBpZCAoc2V0IHRvIE1ERVZfQ0xBU1NfSURfVkZJTykgaXMgdXNlZCB0byBtYXRjaCBhIGRl dmljZQoKIihzZXQgYnkgdGhpcyBoZWxwZXIgZnVuY3Rpb24gdG8gTURFVl9DTEFTU19JRF9WRklP KSIgPwoKPiArd2l0aCBhbiBtZGV2IGRyaXZlciB2aWEgaXRzIGlkIHRhYmxlLiBUaGUgZGV2aWNl IHNwZWNpZmljIGNhbGxiYWNrcwo+ICsoc3BlY2lmaWVkIGluICpvcHMpIGFyZSBvYnRhaW5hYmxl IHZpYSBtZGV2X2dldF9kZXZfb3BzKCkgKGZvciB1c2UgYnkKCiIoc3BlY2lmaWVkIGluICp2Zmlv X29wcyBieSB0aGUgY2FsbGVyKSIgPwoKPiArdGhlIG1kZXYgYnVzIGRyaXZlcikuIEEgdmZpby1t ZGV2IGRldmljZSAoY2xhc3MgaWQgTURFVl9DTEFTU19JRF9WRklPKQo+ICt1c2VzIHRoZSBmb2xs b3dpbmcgZGV2aWNlLXNwZWNpZmljIG9wczoKPiArCj4gKyogb3Blbjogb3BlbiBjYWxsYmFjayBv ZiB2ZmlvIG1lZGlhdGVkIGRldmljZQo+ICsqIGNsb3NlOiBjbG9zZSBjYWxsYmFjayBvZiB2Zmlv IG1lZGlhdGVkIGRldmljZQo+ICsqIGlvY3RsOiBpb2N0bCBjYWxsYmFjayBvZiB2ZmlvIG1lZGlh dGVkIGRldmljZQo+ICAqIHJlYWQgOiByZWFkIGVtdWxhdGlvbiBjYWxsYmFjawo+ICAqIHdyaXRl OiB3cml0ZSBlbXVsYXRpb24gY2FsbGJhY2sKPiAgKiBtbWFwOiBtbWFwIGVtdWxhdGlvbiBjYWxs YmFjawo+IEBAIC0xNjcsMTAgKzE3OCw2IEBAIHJlZ2lzdGVyIGl0c2VsZiB3aXRoIHRoZSBtZGV2 IGNvcmUgZHJpdmVyOjoKPiAgCWV4dGVybiBpbnQgIG1kZXZfcmVnaXN0ZXJfZGV2aWNlKHN0cnVj dCBkZXZpY2UgKmRldiwKPiAgCSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0 IHN0cnVjdCBtZGV2X3BhcmVudF9vcHMgKm9wcyk7Cj4gIAo+IC1JdCBpcyBhbHNvIHJlcXVpcmVk IHRvIHNwZWNpZnkgdGhlIGNsYXNzX2lkIGluIGNyZWF0ZSgpIGNhbGxiYWNrIHRocm91Z2g6Ogo+ IC0KPiAtCWludCBtZGV2X3NldF9jbGFzcyhzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYsIHUxNiBp ZCk7Cj4gLQoKSSdtIHdvbmRlcmluZyBpZiB0aGlzIHBhdGNoIHNldCBzaG91bGQgc3RhcnQgb3V0 IHdpdGggaW50cm9kdWNpbmcKaGVscGVyIGZ1bmN0aW9ucyBhbHJlYWR5IChpLmUuIGRvbid0IGlu dHJvZHVjZSBtZGV2X3NldF9jbGFzcygpLCBidXQKc3RhcnQgb3V0IHdpdGggbWRldl9zZXRfY2xh c3NfdmZpbygpIHdoaWNoIHdpbGwgZ2FpbiB0aGUgKnZmaW9fb3BzCmFyZ3VtZW50IGluIHRoaXMg cGF0Y2guKQoKPiAgSG93ZXZlciwgdGhlIG1kZXZfcGFyZW50X29wcyBzdHJ1Y3R1cmUgaXMgbm90 IHJlcXVpcmVkIGluIHRoZSBmdW5jdGlvbiBjYWxsCj4gIHRoYXQgYSBkcml2ZXIgc2hvdWxkIHVz ZSB0byB1bnJlZ2lzdGVyIGl0c2VsZiB3aXRoIHRoZSBtZGV2IGNvcmUgZHJpdmVyOjoKPiAgCgoo Li4uKQoKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy92ZmlvL21kZXYvbWRldl9jb3JlLmMgYi9kcml2 ZXJzL3ZmaW8vbWRldi9tZGV2X2NvcmUuYwo+IGluZGV4IDNhOWM1MmQ3MWI0ZS4uZDBmMzExM2M4 MDcxIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvdmZpby9tZGV2L21kZXZfY29yZS5jCj4gKysrIGIv ZHJpdmVycy92ZmlvL21kZXYvbWRldl9jb3JlLmMKPiBAQCAtNDUsMTUgKzQ1LDIzIEBAIHZvaWQg bWRldl9zZXRfZHJ2ZGF0YShzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYsIHZvaWQgKmRhdGEpCj4g IH0KPiAgRVhQT1JUX1NZTUJPTChtZGV2X3NldF9kcnZkYXRhKTsKPiAgCj4gLS8qIFNwZWNpZnkg dGhlIGNsYXNzIGZvciB0aGUgbWRldiBkZXZpY2UsIHRoaXMgbXVzdCBiZSBjYWxsZWQgZHVyaW5n Cj4gLSAqIGNyZWF0ZSgpIGNhbGxiYWNrLgo+ICsvKiBTcGVjaWZ5IHRoZSBWRklPIGRldmljZSBv cHMgZm9yIHRoZSBtZGV2IGRldmljZSwgdGhpcwo+ICsgKiBtdXN0IGJlIGNhbGxlZCBkdXJpbmcg Y3JlYXRlKCkgY2FsbGJhY2sgZm9yIFZGSU8gbWRldiBkZXZpY2UuCj4gICAqLwoKLyoKICogU3Bl Y2lmeSB0aGUgbWRldiBkZXZpY2UgdG8gYmUgYSBWRklPIG1kZXYgZGV2aWNlLCBhbmQgc2V0IHRo ZQogKiBWRklPIGRldmljZXMgb3BzIGZvciBpdC4gVGhpcyBtdXN0IGJlIGNhbGxlZCBmcm9tIHRo ZSBjcmVhdGUoKQogKiBjYWxsYmFjayBmb3IgVkZJTyBtZGV2IGRldmljZXMuCiAqLwoKPwoKPiAt dm9pZCBtZGV2X3NldF9jbGFzcyhzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYsIHUxNiBpZCkKPiAr dm9pZCBtZGV2X3NldF92ZmlvX29wcyhzdHJ1Y3QgbWRldl9kZXZpY2UgKm1kZXYsCj4gKwkJICAg ICAgIGNvbnN0IHN0cnVjdCB2ZmlvX21kZXZfZGV2aWNlX29wcyAqdmZpb19vcHMpCj4gIHsKPiAg CVdBUk5fT04obWRldi0+Y2xhc3NfaWQpOwo+IC0JbWRldi0+Y2xhc3NfaWQgPSBpZDsKPiArCW1k ZXYtPmNsYXNzX2lkID0gTURFVl9DTEFTU19JRF9WRklPOwo+ICsJbWRldi0+ZGV2aWNlX29wcyA9 IHZmaW9fb3BzOwo+ICB9Cj4gLUVYUE9SVF9TWU1CT0wobWRldl9zZXRfY2xhc3MpOwo+ICtFWFBP UlRfU1lNQk9MKG1kZXZfc2V0X3ZmaW9fb3BzKTsKPiArCj4gK2NvbnN0IHZvaWQgKm1kZXZfZ2V0 X2Rldl9vcHMoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2KQo+ICt7Cj4gKwlyZXR1cm4gbWRldi0+ ZGV2aWNlX29wczsKPiArfQo+ICtFWFBPUlRfU1lNQk9MKG1kZXZfZ2V0X2Rldl9vcHMpOwo+ICAK PiAgc3RydWN0IGRldmljZSAqbWRldl9kZXYoc3RydWN0IG1kZXZfZGV2aWNlICptZGV2KQo+ICB7 CgooLi4uKQoKVGhlIGNvZGUgY2hhbmdlIGxvb2tzIGdvb2QgdG8gbWU7IEknbSBqdXN0IHdvbmRl cmluZyBpZiB3ZSBzaG91bGQKaW50cm9kdWNlIG1kZXZfc2V0X2NsYXNzKCkgYXQgYWxsIChzZWUg YWJvdmUpLgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJ bnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0 cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZng=