All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Sean Christopherson <sean.j.christopherson@intel.com>
Cc: linux-sgx@vger.kernel.org
Subject: Re: [PATCH for_v23 v3 00/12] x86/sgx: Bug fixes for v23
Date: Thu, 17 Oct 2019 21:12:01 +0300	[thread overview]
Message-ID: <20191017181201.GI6667@linux.intel.com> (raw)
In-Reply-To: <20191017181054.GH6667@linux.intel.com>

On Thu, Oct 17, 2019 at 09:10:54PM +0300, Jarkko Sakkinen wrote:
> On Wed, Oct 16, 2019 at 11:37:33AM -0700, Sean Christopherson wrote:
> > As requested, the merge of the EPC and EADD bug fix series.  The headliners
> > are two critical bug fixes for a memory leak in sgx_encl_destroy() and a
> > livelock due to the EPC page free count getting corrupted.
> 
> BTW, are you still planning to send multi-page EADD? I think it should
> be done. It is obviously superior design when combined with my small
> twist where mrmask is calculated inside the kernel.
> 
> Not only does it provide multi-page EADD but you could always do one
> ioctl per area. With mrmask in parameters you end up needing two if the
> user space is designed in a way that measurement is not a multiple of a
> page.
> 
> If mrmask would make sense in the parameters, then a single-page EADD
> would be cool but I think we want to render it out completely.

My earlier comments about doing first a single page EADD were based on
API where you provide mrmask.

/Jarkko

  reply	other threads:[~2019-10-17 18:12 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-16 18:37 [PATCH for_v23 v3 00/12] x86/sgx: Bug fixes for v23 Sean Christopherson
2019-10-16 18:37 ` [PATCH for_v23 v3 01/12] x86/sgx: Pass EADD the kernel's virtual address for the source page Sean Christopherson
2019-10-18  9:57   ` Jarkko Sakkinen
2019-10-22  3:22     ` Sean Christopherson
2019-10-23 11:57       ` Jarkko Sakkinen
2019-10-16 18:37 ` [PATCH for_v23 v3 02/12] x86/sgx: Check the validity of the source page address for EADD Sean Christopherson
2019-10-16 18:37 ` [PATCH for_v23 v3 03/12] x86/sgx: Fix EEXTEND error handling Sean Christopherson
2019-10-18 10:42   ` Jarkko Sakkinen
2019-10-16 18:37 ` [PATCH for_v23 v3 04/12] x86/sgx: Drop mmap_sem before EEXTENDing an enclave page Sean Christopherson
2019-10-18 10:04   ` Jarkko Sakkinen
2019-10-16 18:37 ` [PATCH for_v23 v3 05/12] x86/sgx: Remove redundant message from WARN on non-emtpy mm_list Sean Christopherson
2019-10-18 12:08   ` Jarkko Sakkinen
2019-10-16 18:37 ` [PATCH for_v23 v3 06/12] x86/sgx: Fix a memory leak in sgx_encl_destroy() Sean Christopherson
2019-10-18 12:17   ` Jarkko Sakkinen
2019-10-16 18:37 ` [PATCH for_v23 v3 07/12] x86/sgx: WARN on any non-zero return from __eremove() Sean Christopherson
2019-10-16 18:37 ` [PATCH for_v23 v3 08/12] x86/sgx: WARN only once if EREMOVE fails Sean Christopherson
2019-10-16 18:37 ` [PATCH for_v23 v3 09/12] x86/sgx: Split second half of sgx_free_page() to a separate helper Sean Christopherson
2019-10-18 10:06   ` Jarkko Sakkinen
2019-10-22  3:36     ` Sean Christopherson
2019-10-23 11:59       ` Jarkko Sakkinen
2019-10-16 18:37 ` [PATCH for_v23 v3 10/12] x86/sgx: Use the post-reclaim variant of __sgx_free_page() Sean Christopherson
2019-10-16 18:37 ` [PATCH for_v23 v3 11/12] x86/sgx: Don't update free page count if EPC section allocation fails Sean Christopherson
2019-10-16 18:37 ` [PATCH for_v23 v3 12/12] x86/sgx: Reinstate per EPC section free page counts Sean Christopherson
2019-10-18 12:49   ` Jarkko Sakkinen
2019-10-18 12:55     ` Jarkko Sakkinen
2019-10-18 14:30     ` Sean Christopherson
2019-10-21 11:19       ` Jarkko Sakkinen
2019-10-22 19:35         ` Sean Christopherson
2019-10-23 12:02           ` Jarkko Sakkinen
2019-10-17 18:10 ` [PATCH for_v23 v3 00/12] x86/sgx: Bug fixes for v23 Jarkko Sakkinen
2019-10-17 18:12   ` Jarkko Sakkinen [this message]
2019-10-18 13:13   ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191017181201.GI6667@linux.intel.com \
    --to=jarkko.sakkinen@linux.intel.com \
    --cc=linux-sgx@vger.kernel.org \
    --cc=sean.j.christopherson@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.