Hi Thomas,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on linus/master]
[cannot apply to v5.4-rc3 next-20191017]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Thomas-Zimmermann/DRM-fbconv-helpers-for-converting-fbdev-drivers/20191015-152231
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   ld: drivers/staging/mgakms/g450_pll.o: in function `__crc_g450_mnp2f':
   (*ABS*+0x456b8a98): multiple definition of `__crc_g450_mnp2f'
   ld: drivers/staging/mgakms/g450_pll.o: in function `__crc_matroxfb_g450_setclk':
   (*ABS*+0x4da4fa96): multiple definition of `__crc_matroxfb_g450_setclk'
   ld: drivers/staging/mgakms/g450_pll.o: in function `matroxfb_g450_setclk':
>> (.text+0x5b0): multiple definition of `matroxfb_g450_setclk'; drivers/video/fbdev/matrox/g450_pll.o:(.text+0x5b0): first defined here
   ld: drivers/staging/mgakms/g450_pll.o: in function `g450_mnp2f':
>> (.text+0x0): multiple definition of `g450_mnp2f'; drivers/video/fbdev/matrox/g450_pll.o:(.text+0x0): first defined here
   ld: drivers/staging/mgakms/g450_pll.o: in function `matroxfb_g450_setpll_cond':
>> (.text+0x230): multiple definition of `matroxfb_g450_setpll_cond'; drivers/video/fbdev/matrox/g450_pll.o:(.text+0x230): first defined here
   ld: drivers/staging/mgakms/g450_pll.o: in function `__crc_matroxfb_g450_setpll_cond':
   (*ABS*+0xc16eb42d): multiple definition of `__crc_matroxfb_g450_setpll_cond'
   ld: drivers/staging/mgakms/matroxfb_accel.o: in function `matrox_cfbX_init':
>> (.text+0x0): multiple definition of `matrox_cfbX_init'; drivers/video/fbdev/matrox/matroxfb_accel.o:(.text+0x0): first defined here
   ld: drivers/staging/mgakms/matroxfb_accel.o: in function `__crc_matrox_cfbX_init':
   (*ABS*+0xad1ca004): multiple definition of `__crc_matrox_cfbX_init'
   ld: drivers/staging/mgakms/matroxfb_base.o: in function `__crc_matroxfb_enable_irq':
   (*ABS*+0x2f4ea06b): multiple definition of `__crc_matroxfb_enable_irq'
   ld: drivers/staging/mgakms/matroxfb_base.o: in function `__crc_matroxfb_register_driver':
   (*ABS*+0x9eefe8ea): multiple definition of `__crc_matroxfb_register_driver'
   ld: drivers/staging/mgakms/matroxfb_base.o: in function `matroxfb_enable_irq':
>> (.text+0x3d70): multiple definition of `matroxfb_enable_irq'; drivers/video/fbdev/matrox/matroxfb_base.o:(.text+0x3d40): first defined here
   ld: drivers/staging/mgakms/matroxfb_base.o: in function `__crc_matroxfb_unregister_driver':
   (*ABS*+0xe6ed497): multiple definition of `__crc_matroxfb_unregister_driver'
   ld: drivers/staging/mgakms/matroxfb_base.o: in function `matroxfb_register_driver':
>> (.text+0x7e0): multiple definition of `matroxfb_register_driver'; drivers/video/fbdev/matrox/matroxfb_base.o:(.text+0x7e0): first defined here
   ld: drivers/staging/mgakms/matroxfb_base.o: in function `matroxfb_wait_for_sync':
>> (.text+0x41b0): multiple definition of `matroxfb_wait_for_sync'; drivers/video/fbdev/matrox/matroxfb_base.o:(.text+0x4180): first defined here
   ld: drivers/staging/mgakms/matroxfb_base.o: in function `__crc_matroxfb_wait_for_sync':
   (*ABS*+0xf264a0a8): multiple definition of `__crc_matroxfb_wait_for_sync'
   ld: drivers/staging/mgakms/matroxfb_base.o: in function `matroxfb_unregister_driver':
>> (.text+0x950): multiple definition of `matroxfb_unregister_driver'; drivers/video/fbdev/matrox/matroxfb_base.o:(.text+0x950): first defined here
>> ld: drivers/staging/mgakms/matroxfb_DAC1064.o:(.data+0x0): multiple definition of `matrox_G100'; drivers/video/fbdev/matrox/matroxfb_DAC1064.o:(.data+0x0): first defined here
   ld: drivers/staging/mgakms/matroxfb_DAC1064.o: in function `__crc_DAC1064_global_init':
   (*ABS*+0x279aabee): multiple definition of `__crc_DAC1064_global_init'
   ld: drivers/staging/mgakms/matroxfb_DAC1064.o: in function `__crc_DAC1064_global_restore':
   (*ABS*+0xb0a182ca): multiple definition of `__crc_DAC1064_global_restore'
>> ld: drivers/staging/mgakms/matroxfb_DAC1064.o:(.data+0x40): multiple definition of `matrox_mystique'; drivers/video/fbdev/matrox/matroxfb_DAC1064.o:(.data+0x40): first defined here
   ld: drivers/staging/mgakms/matroxfb_DAC1064.o: in function `__crc_matrox_mystique':
   (*ABS*+0x82a67894): multiple definition of `__crc_matrox_mystique'
   ld: drivers/staging/mgakms/matroxfb_DAC1064.o: in function `DAC1064_global_restore':
>> (.text+0x0): multiple definition of `DAC1064_global_restore'; drivers/video/fbdev/matrox/matroxfb_DAC1064.o:(.text+0x0): first defined here
   ld: drivers/staging/mgakms/matroxfb_DAC1064.o: in function `__crc_matrox_G100':
   (*ABS*+0x1efba743): multiple definition of `__crc_matrox_G100'
   ld: drivers/staging/mgakms/matroxfb_DAC1064.o: in function `DAC1064_global_init':
>> (.text+0x130): multiple definition of `DAC1064_global_init'; drivers/video/fbdev/matrox/matroxfb_DAC1064.o:(.text+0x130): first defined here
   ld: drivers/staging/mgakms/matroxfb_g450.o: in function `__crc_matroxfb_g450_connect':
   (*ABS*+0xb554d1f9): multiple definition of `__crc_matroxfb_g450_connect'
   ld: drivers/staging/mgakms/matroxfb_g450.o: in function `__crc_matroxfb_g450_shutdown':
   (*ABS*+0xfef8ad0b): multiple definition of `__crc_matroxfb_g450_shutdown'
   ld: drivers/staging/mgakms/matroxfb_g450.o: in function `matroxfb_g450_shutdown':
>> (.text+0x2c0): multiple definition of `matroxfb_g450_shutdown'; drivers/video/fbdev/matrox/matroxfb_g450.o:(.text+0x2c0): first defined here
   ld: drivers/staging/mgakms/matroxfb_g450.o: in function `matroxfb_g450_connect':
>> (.text+0x130): multiple definition of `matroxfb_g450_connect'; drivers/video/fbdev/matrox/matroxfb_g450.o:(.text+0x130): first defined here
   ld: drivers/staging/mgakms/matroxfb_misc.o: in function `__crc_matroxfb_DAC_in':
   (*ABS*+0xa94ac221): multiple definition of `__crc_matroxfb_DAC_in'
   ld: drivers/staging/mgakms/matroxfb_misc.o: in function `__crc_matroxfb_DAC_out':
   (*ABS*+0x7b927ef5): multiple definition of `__crc_matroxfb_DAC_out'
   ld: drivers/staging/mgakms/matroxfb_misc.o: in function `matroxfb_PLL_calcclock':
>> (.text+0x260): multiple definition of `matroxfb_PLL_calcclock'; drivers/video/fbdev/matrox/matroxfb_misc.o:(.text+0x260): first defined here
   ld: drivers/staging/mgakms/matroxfb_misc.o: in function `matroxfb_DAC_in':
>> (.text+0x50): multiple definition of `matroxfb_DAC_in'; drivers/video/fbdev/matrox/matroxfb_misc.o:(.text+0x50): first defined here
   ld: drivers/staging/mgakms/matroxfb_misc.o: in function `matroxfb_DAC_out':
>> (.text+0x0): multiple definition of `matroxfb_DAC_out'; drivers/video/fbdev/matrox/matroxfb_misc.o:(.text+0x0): first defined here
   ld: drivers/staging/mgakms/matroxfb_misc.o: in function `matroxfb_vgaHWinit':
>> (.text+0x500): multiple definition of `matroxfb_vgaHWinit'; drivers/video/fbdev/matrox/matroxfb_misc.o:(.text+0x500): first defined here
   ld: drivers/staging/mgakms/matroxfb_misc.o: in function `__crc_matroxfb_vgaHWinit':
   (*ABS*+0x880c2f5e): multiple definition of `__crc_matroxfb_vgaHWinit'
   ld: drivers/staging/mgakms/matroxfb_misc.o: in function `matroxfb_vgaHWrestore':
>> (.text+0xd50): multiple definition of `matroxfb_vgaHWrestore'; drivers/video/fbdev/matrox/matroxfb_misc.o:(.text+0xd50): first defined here
   ld: drivers/staging/mgakms/matroxfb_misc.o: in function `__crc_matroxfb_read_pins':
   (*ABS*+0x10a9907b): multiple definition of `__crc_matroxfb_read_pins'
   ld: drivers/staging/mgakms/matroxfb_misc.o: in function `matroxfb_read_pins':
>> (.text+0x13d0): multiple definition of `matroxfb_read_pins'; drivers/video/fbdev/matrox/matroxfb_misc.o:(.text+0x13d0): first defined here
   ld: drivers/staging/mgakms/matroxfb_misc.o: in function `matroxfb_var2my':

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation