From: Herbert Xu <herbert@gondor.apana.org.au>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: xuzaibo@huawei.com, davem@davemloft.net,
forest.zhouchang@huawei.com, linux-crypto@vger.kernel.org,
linux-kernel@vger.kernel.org, linuxarm@huawei.com,
tanghui20@huawei.com
Subject: Re: [PATCH] crypto: hisilicon: Fix misuse of GENMASK macro
Date: Fri, 18 Oct 2019 19:07:06 +1100 [thread overview]
Message-ID: <20191018080706.GO25128@gondor.apana.org.au> (raw)
In-Reply-To: <20191015201330.25973-1-rikard.falkeborn@gmail.com>
On Tue, Oct 15, 2019 at 10:13:30PM +0200, Rikard Falkeborn wrote:
> Arguments are supposed to be ordered high then low.
>
> Fixes: c8b4b477079d ("crypto: hisilicon - add HiSilicon HPRE accelerator")
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> Spotted when trying to introduce compile time checking that the order
> of the arguments to GENMASK are correct [0]. I have only compile tested
> the patch.
>
> [0]: https://lore.kernel.org/lkml/20191009214502.637875-1-rikard.falkeborn@gmail.com/
>
> drivers/crypto/hisilicon/hpre/hpre_main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2019-10-18 8:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-30 9:20 [PATCH 0/5] crypto: hisilicon - add HPRE support Zaibo Xu
2019-09-30 9:20 ` [PATCH 1/5] crypto: hisilicon - add HiSilicon HPRE accelerator Zaibo Xu
2019-10-15 20:13 ` [PATCH] crypto: hisilicon: Fix misuse of GENMASK macro Rikard Falkeborn
2019-10-16 1:34 ` Xu Zaibo
2019-10-18 8:07 ` Herbert Xu [this message]
2019-09-30 9:20 ` [PATCH 2/5] crypto: hisilicon - add SRIOV support for HPRE Zaibo Xu
2019-09-30 9:20 ` [PATCH 3/5] Documentation: Add debugfs doc for hisi_hpre Zaibo Xu
2019-09-30 9:20 ` [PATCH 4/5] crypto: hisilicon: Add debugfs for HPRE Zaibo Xu
2019-09-30 9:20 ` [PATCH 5/5] MAINTAINERS: Add maintainer for HiSilicon HPRE driver Zaibo Xu
2019-10-09 3:15 ` [PATCH 0/5] crypto: hisilicon - add HPRE support Xu Zaibo
2019-10-10 12:54 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191018080706.GO25128@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=forest.zhouchang@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=rikard.falkeborn@gmail.com \
--cc=tanghui20@huawei.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.