✗ Fi.CI.CHECKPATCH: warning for series starting with [01/14] drm/i915: Rework watermark readout to use plane api (rev2)

[Patchwork <patchwork@emeril.freedesktop.org>]

== Series Details ==

Series: series starting with [01/14] drm/i915: Rework watermark readout to use plane api (rev2)
URL   : https://patchwork.freedesktop.org/series/68154/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
b7926f94b005 drm/i915: Rework watermark readout to use plane api
ec5541f29359 drm/i915: Introduce intel_atomic_get_plane_state_after_check(), v2.
-:10: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#10: 
In case of intel_modeset_all_pipes() this is not yet done after atomic_check,

-:87: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#87: FILE: drivers/gpu/drm/i915/display/intel_atomic.c:387:
+					DRM_DEBUG_KMS("Failed to add [PLANE:%d] to drm_state: %li\n",
+						plane->base.base.id, PTR_ERR(plane_state));

total: 0 errors, 1 warnings, 1 checks, 185 lines checked
c11aa5f9aecb drm/i915: Handle a few more cases for crtc hw/uapi split, v2.
892e45082594 drm/i915: Add aliases for uapi and hw to crtc_state
-:67: WARNING:LONG_LINE: line over 100 characters
#67: FILE: drivers/gpu/drm/i915/display/intel_display.h:450:
+			      to_intel_plane_state(__drm_atomic_get_current_plane_state((crtc_state)->uapi.state, &plane->base))))

total: 0 errors, 1 warnings, 0 checks, 83 lines checked
d34b44583315 drm/i915: Perform manual conversions for crtc uapi/hw split, v2.
9dcd30df9a3d drm/i915: Perform automated conversions for crtc uapi/hw split, base -> hw.
-:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7: 
Split up crtc_state->base to hw where appropriate. This is done using the following patch:

-:1382: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1382: FILE: drivers/gpu/drm/i915/display/intel_display.c:16667:
+		crtc_state->hw.active = crtc_state->hw.enable =

total: 0 errors, 1 warnings, 1 checks, 2055 lines checked
9dcebb8f873c drm/i915: Perform automated conversions for crtc uapi/hw split, base -> uapi.
-:18: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#18: 
identifier x =~ "^(active|enable|degamma_lut|gamma_lut|ctm|mode|adjusted_mode)$";

-:2352: ERROR:CODE_INDENT: code indent should use tabs where possible
#2352: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:211:
+^I^I^I^I          new_crtc_state->uapi.event);$

-:2352: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#2352: FILE: drivers/gpu/drm/i915/display/intel_sprite.c:211:
+		drm_crtc_arm_vblank_event(&crtc->base,
+				          new_crtc_state->uapi.event);

total: 1 errors, 1 warnings, 1 checks, 2514 lines checked
87af32bda7a2 drm/i915: Complete crtc hw/uapi split, v2.
-:15: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#15: 
- Clear crtc_state->hw on disable, instead of using clear_intel_crtc_state().

total: 0 errors, 1 warnings, 0 checks, 206 lines checked
de2e37307e2d drm/i915: Add aliases for uapi and hw to plane_state
-:49: WARNING:LINE_SPACING: Missing a blank line after declarations
#49: FILE: drivers/gpu/drm/i915/display/intel_atomic_plane.c:112:
+	struct intel_plane_state *plane_state = to_intel_plane_state(state);
+	WARN_ON(plane_state->vma);

total: 0 errors, 1 warnings, 0 checks, 59 lines checked
205a73338518 drm/i915: Perform manual conversions for plane uapi/hw split
6aa0728a2af6 drm/i915: Perform automated conversions for plane uapi/hw split, base -> hw.
-:11: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#11: 
identifier x =~ "^(crtc|fb|alpha|pixel_blend_mode|rotation|color_encoding|color_range)$";

-:832: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "plane_state->hw.fb"
#832: FILE: drivers/gpu/drm/i915/intel_pm.c:813:
+		return plane_state->hw.fb != NULL;

total: 0 errors, 1 warnings, 1 checks, 836 lines checked
3d5dd6146657 drm/i915: Perform automated conversions for plane uapi/hw split, base -> uapi.
-:713: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#713: FILE: drivers/gpu/drm/i915/display/intel_display.c:10962:
+		unsigned width = drm_rect_width(&plane_state->uapi.dst);

-:714: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#714: FILE: drivers/gpu/drm/i915/display/intel_display.c:10963:
+		unsigned height = drm_rect_height(&plane_state->uapi.dst);

-:782: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#782: FILE: drivers/gpu/drm/i915/display/intel_display.c:11565:
+		plane_state->uapi.visible = visible = false;

-:1510: WARNING:LONG_LINE: line over 100 characters
#1510: FILE: drivers/gpu/drm/i915/intel_pm.c:3112:
+			(drm_rect_width(&sprstate->uapi.dst) != drm_rect_width(&sprstate->uapi.src) >> 16 ||

-:1511: WARNING:LONG_LINE: line over 100 characters
#1511: FILE: drivers/gpu/drm/i915/intel_pm.c:3113:
+			 drm_rect_height(&sprstate->uapi.dst) != drm_rect_height(&sprstate->uapi.src) >> 16);

total: 0 errors, 4 warnings, 1 checks, 1415 lines checked
80a567494d9b drm/i915: Complete plane hw and uapi split, v2.
-:139: CHECK:PREFER_KERNEL_TYPES: Prefer kernel type 'u16' over 'uint16_t'
#139: FILE: drivers/gpu/drm/i915/display/intel_display_types.h:530:
+		uint16_t pixel_blend_mode;

total: 0 errors, 0 warnings, 1 checks, 107 lines checked
073f680610d1 drm/i915: Remove special case slave handling during hw programming, v2.

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx