From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A22C3CA9EA0 for ; Fri, 18 Oct 2019 18:07:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8097D2245A for ; Fri, 18 Oct 2019 18:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571422032; bh=utFmYwcbGuT2bwcOimZjkGDdSF8gOzIMBKV5zg5qv30=; h=From:To:Cc:Subject:In-Reply-To:Date:List-ID:From; b=DXmhDKvPppxWx/4NzIwrJu+lFWRFKFc/2E5XXpPD/XtkYaBX8Rf1+RdHpwm1AMzpg q/31xfhADCE0otvxasap/HJ+5SxXJXa/GpyFp/bxNYA8mC95b+E2BpLy8K6BYz2Mah j+EsDb7pV7Gfsf2JTYAlDxZwARqbognjOuPVGjWQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2505731AbfJRSHL (ORCPT ); Fri, 18 Oct 2019 14:07:11 -0400 Received: from heliosphere.sirena.org.uk ([172.104.155.198]:44890 "EHLO heliosphere.sirena.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2505717AbfJRSHI (ORCPT ); Fri, 18 Oct 2019 14:07:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=bmhg+/17g88lQSaN0+48g3/Zis9k7Udg88qlSS1o+MA=; b=WsrEodvRhBXE HYpwMKN35mSEhssW9zftk8eief4ZLz+Rs53Ri8erePRh6FWXNXHsQCcombxSTejhJS2mmMtOvVN4w P+7W+5KalXA5f0D6NEZDUlI8ECSQrg5WiXOVP26k3sHGxXDK3W7i/hRe7WIgwjammdTLJt0MLivsp KByxo=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iLWeR-0004Es-0T; Fri, 18 Oct 2019 18:06:59 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 691AA2741DEA; Fri, 18 Oct 2019 19:06:58 +0100 (BST) From: Mark Brown To: Chuhong Yuan Cc: alsa-devel@alsa-project.org, "Cc:"@sirena.co.uk, "Cc:"@sirena.co.uk, Jaroslav Kysela , Liam Girdwood , linux-kernel@vger.kernel.org, Mark Brown , Takashi Iwai Subject: Applied "ASoC: tlv320aic32x4: add a check for devm_clk_get" to the asoc tree In-Reply-To: <20191018081448.8486-1-hslester96@gmail.com> X-Patchwork-Hint: ignore Message-Id: <20191018180658.691AA2741DEA@ypsilon.sirena.org.uk> Date: Fri, 18 Oct 2019 19:06:58 +0100 (BST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The patch ASoC: tlv320aic32x4: add a check for devm_clk_get has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.5 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 1092b09708882e3c216f0b9c02e606b3c0942c5b Mon Sep 17 00:00:00 2001 From: Chuhong Yuan Date: Fri, 18 Oct 2019 16:14:49 +0800 Subject: [PATCH] ASoC: tlv320aic32x4: add a check for devm_clk_get aic32x4_set_dai_sysclk misses a check for devm_clk_get and may miss the failure. Add a check to fix it. Signed-off-by: Chuhong Yuan Link: https://lore.kernel.org/r/20191018081448.8486-1-hslester96@gmail.com Signed-off-by: Mark Brown --- sound/soc/codecs/tlv320aic32x4.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c index 68165de1c8de..b4e9a6c73f90 100644 --- a/sound/soc/codecs/tlv320aic32x4.c +++ b/sound/soc/codecs/tlv320aic32x4.c @@ -573,6 +573,9 @@ static int aic32x4_set_dai_sysclk(struct snd_soc_dai *codec_dai, struct clk *pll; pll = devm_clk_get(component->dev, "pll"); + if (IS_ERR(pll)) + return PTR_ERR(pll); + mclk = clk_get_parent(pll); return clk_set_rate(mclk, freq); -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8F439CA9EA9 for ; Fri, 18 Oct 2019 18:11:27 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1ED17222C3 for ; Fri, 18 Oct 2019 18:11:26 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="XJRT3wX4"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="WsrEodvR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1ED17222C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 4A73F1681; Fri, 18 Oct 2019 20:10:35 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 4A73F1681 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1571422285; bh=NtTqsF0wcJjoQ6oEfIoHgNFNiBwNMYJgL5z89sO/XRI=; h=From:To:In-Reply-To:Date:Cc:Subject:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From; b=XJRT3wX4g3nvFzo6wSY0JBTeXGJfxbYsaKfjK4faLsFpNgWUU5SuuAd7YM1SDfdHR oQ0wOoUhBKons0mLn5GueMDJEX+/WC5oTPKHZ+sMBjrxwcfdzeGtG0ZjWgvxRC8hRD asNwXJbjttqENq8K5NkwhNemMPH0W809xW2BwS0c= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id CAB87F800D0; Fri, 18 Oct 2019 20:07:19 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 30CDCF80362; Fri, 18 Oct 2019 20:07:07 +0200 (CEST) Received: from heliosphere.sirena.org.uk (heliosphere.sirena.org.uk [172.104.155.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 71310F80369 for ; Fri, 18 Oct 2019 20:06:59 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 71310F80369 Authentication-Results: alsa1.perex.cz; dkim=pass (1024-bit key) header.d=sirena.org.uk header.i=@sirena.org.uk header.b="WsrEodvR" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=sirena.org.uk; s=20170815-heliosphere; h=Date:Message-Id:In-Reply-To: Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:References: List-Id:List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner: List-Archive; bh=bmhg+/17g88lQSaN0+48g3/Zis9k7Udg88qlSS1o+MA=; b=WsrEodvRhBXE HYpwMKN35mSEhssW9zftk8eief4ZLz+Rs53Ri8erePRh6FWXNXHsQCcombxSTejhJS2mmMtOvVN4w P+7W+5KalXA5f0D6NEZDUlI8ECSQrg5WiXOVP26k3sHGxXDK3W7i/hRe7WIgwjammdTLJt0MLivsp KByxo=; Received: from cpc102320-sgyl38-2-0-cust46.18-2.cable.virginm.net ([82.37.168.47] helo=ypsilon.sirena.org.uk) by heliosphere.sirena.org.uk with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1iLWeR-0004Es-0T; Fri, 18 Oct 2019 18:06:59 +0000 Received: by ypsilon.sirena.org.uk (Postfix, from userid 1000) id 691AA2741DEA; Fri, 18 Oct 2019 19:06:58 +0100 (BST) From: Mark Brown To: Chuhong Yuan In-Reply-To: <20191018081448.8486-1-hslester96@gmail.com> X-Patchwork-Hint: ignore Message-Id: <20191018180658.691AA2741DEA@ypsilon.sirena.org.uk> Date: Fri, 18 Oct 2019 19:06:58 +0100 (BST) Cc: alsa-devel@alsa-project.org, Takashi Iwai , linux-kernel@vger.kernel.org, Liam Girdwood , Mark Brown , "Cc:"@sirena.co.uk Subject: [alsa-devel] Applied "ASoC: tlv320aic32x4: add a check for devm_clk_get" to the asoc tree X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" The patch ASoC: tlv320aic32x4: add a check for devm_clk_get has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.5 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted. You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed. If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced. Please add any relevant lists and maintainers to the CCs when replying to this mail. Thanks, Mark >From 1092b09708882e3c216f0b9c02e606b3c0942c5b Mon Sep 17 00:00:00 2001 From: Chuhong Yuan Date: Fri, 18 Oct 2019 16:14:49 +0800 Subject: [PATCH] ASoC: tlv320aic32x4: add a check for devm_clk_get aic32x4_set_dai_sysclk misses a check for devm_clk_get and may miss the failure. Add a check to fix it. Signed-off-by: Chuhong Yuan Link: https://lore.kernel.org/r/20191018081448.8486-1-hslester96@gmail.com Signed-off-by: Mark Brown --- sound/soc/codecs/tlv320aic32x4.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/sound/soc/codecs/tlv320aic32x4.c b/sound/soc/codecs/tlv320aic32x4.c index 68165de1c8de..b4e9a6c73f90 100644 --- a/sound/soc/codecs/tlv320aic32x4.c +++ b/sound/soc/codecs/tlv320aic32x4.c @@ -573,6 +573,9 @@ static int aic32x4_set_dai_sysclk(struct snd_soc_dai *codec_dai, struct clk *pll; pll = devm_clk_get(component->dev, "pll"); + if (IS_ERR(pll)) + return PTR_ERR(pll); + mclk = clk_get_parent(pll); return clk_set_rate(mclk, freq); -- 2.20.1 _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel