From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 283D7CA9EA9 for ; Fri, 18 Oct 2019 19:04:46 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 031962070B for ; Fri, 18 Oct 2019 19:04:46 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="IGyKEOZx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2443246AbfJRTEp (ORCPT ); Fri, 18 Oct 2019 15:04:45 -0400 Received: from vps0.lunn.ch ([185.16.172.187]:53204 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2443231AbfJRTEo (ORCPT ); Fri, 18 Oct 2019 15:04:44 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Type:MIME-Version:References:Message-ID: Subject:Cc:To:From:Date:Sender:Reply-To:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=gChMufF7pDlsTELG5XA6EwZSwB7D7Bj07q+bOG1oGb4=; b=IGyKEOZxoCUxnUeBCWOSJG2WA1 pwJZL0JfM1HnI+xcXSvrTouBqKE3Mc7qzDHniX8gNfhsM2muWm6BjYSAn1xIqqVE3EXORzkqF1y5C XOJvSFQxejNpDcR5xhWrLVoezqOGDnZrYxYswo7rAkTvoiDzEtyWq7LjfIYxen+XJk08=; Received: from andrew by vps0.lunn.ch with local (Exim 4.92.2) (envelope-from ) id 1iLXYA-0002oW-Fo; Fri, 18 Oct 2019 21:04:34 +0200 Date: Fri, 18 Oct 2019 21:04:34 +0200 From: Andrew Lunn To: Chen Wandun Cc: igor.russkikh@aquantia.com, davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] net: aquantia: add an error handling in aq_nic_set_multicast_list Message-ID: <20191018190434.GG24810@lunn.ch> References: <1571394037-19978-1-git-send-email-chenwandun@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1571394037-19978-1-git-send-email-chenwandun@huawei.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Oct 18, 2019 at 06:20:37PM +0800, Chen Wandun wrote: > From: Chenwandun > > add an error handling in aq_nic_set_multicast_list, it may not > work when hw_multicast_list_set error; and at the same time > it will remove gcc Wunused-but-set-variable warning. > > Signed-off-by: Chenwandun Reviewed-by: Andrew Lunn Andrew