From mboxrd@z Thu Jan 1 00:00:00 1970 From: Imre Deak Subject: Re: [PATCH] drm/i915/tc: Implement the TC cold exit sequence Date: Sat, 19 Oct 2019 13:49:42 +0300 Message-ID: <20191019104942.GA7182@ideak-desk.fi.intel.com> References: <20191001005536.123020-1-jose.souza@intel.com> <20191003145048.GF5071@ideak-desk.fi.intel.com> <0b02769d681e728a0c7b086eabbd361a42c257ab.camel@intel.com> Reply-To: imre.deak@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5239C89C51 for ; Sat, 19 Oct 2019 10:51:07 +0000 (UTC) Content-Disposition: inline In-Reply-To: <0b02769d681e728a0c7b086eabbd361a42c257ab.camel@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Souza, Jose" Cc: "intel-gfx@lists.freedesktop.org" , "De Marchi, Lucas" List-Id: intel-gfx@lists.freedesktop.org T24gU2F0LCBPY3QgMTksIDIwMTkgYXQgMDI6NTk6MTRBTSArMDMwMCwgU291emEsIEpvc2Ugd3Jv dGU6Cj4gT24gVGh1LCAyMDE5LTEwLTAzIGF0IDE3OjUwICswMzAwLCBJbXJlIERlYWsgd3JvdGU6 Cj4gPiBPbiBNb24sIFNlcCAzMCwgMjAxOSBhdCAwNTo1NTozNlBNIC0wNzAwLCBKb3PDqSBSb2Jl cnRvIGRlIFNvdXphCj4gPiB3cm90ZToKPiA+ID4gVGhpcyBpcyByZXF1aXJlZCBmb3IgbGVnYWN5 L3N0YXRpYyBUQyBwb3J0cyBhcyBJT00gaXMgbm90IGF3YXJlIG9mCj4gPiA+IHRoZSBjb25uZWN0 aW9uIGFuZCB3aWxsIG5vdCB0cmlnZ2VyIHRoZSBUQyBjb2xkIGV4aXQuCj4gPiA+IAo+ID4gPiBC U3BlYzogMjE3NTAKPiA+ID4gQlNwc2M6IDQ5Mjk0Cj4gPiA+IENjOiBJbXJlIERlYWsgPGltcmUu ZGVha0BpbnRlbC5jb20+Cj4gPiA+IENjOiBMdWNhcyBEZSBNYXJjaGkgPGx1Y2FzLmRlbWFyY2hp QGludGVsLmNvbT4KPiA+ID4gU2lnbmVkLW9mZi1ieTogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8 am9zZS5zb3V6YUBpbnRlbC5jb20+Cj4gPiA+IC0tLQo+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5 MTUvZGlzcGxheS9pbnRlbF90Yy5jIHwgMzQgKysrKysrKysrKysrKysrKysrKystCj4gPiA+IC0t LS0KPiA+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmggICAgICAgICB8ICAxICsK PiA+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMjkgaW5zZXJ0aW9ucygrKSwgNiBkZWxldGlvbnMoLSkK PiA+ID4gCj4gPiA+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2lu dGVsX3RjLmMKPiA+ID4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3RjLmMK PiA+ID4gaW5kZXggNzc3MzE2OWI3MzMxLi4wOWI3ODAyN2JkZDUgMTAwNjQ0Cj4gPiA+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2Rpc3BsYXkvaW50ZWxfdGMuYwo+ID4gPiArKysgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9kaXNwbGF5L2ludGVsX3RjLmMKPiA+ID4gQEAgLTcsNiArNyw3IEBA Cj4gPiA+ICAjaW5jbHVkZSAiaW50ZWxfZGlzcGxheS5oIgo+ID4gPiAgI2luY2x1ZGUgImludGVs X2Rpc3BsYXlfdHlwZXMuaCIKPiA+ID4gICNpbmNsdWRlICJpbnRlbF9kcF9tc3QuaCIKPiA+ID4g KyNpbmNsdWRlICJpbnRlbF9zaWRlYmFuZC5oIgo+ID4gPiAgI2luY2x1ZGUgImludGVsX3RjLmgi Cj4gPiA+ICAKPiA+ID4gIHN0YXRpYyBjb25zdCBjaGFyICp0Y19wb3J0X21vZGVfbmFtZShlbnVt IHRjX3BvcnRfbW9kZSBtb2RlKQo+ID4gPiBAQCAtMTY5LDYgKzE3MCwyMiBAQCBzdGF0aWMgdm9p ZCB0Y19wb3J0X2ZpeHVwX2xlZ2FjeV9mbGFnKHN0cnVjdAo+ID4gPiBpbnRlbF9kaWdpdGFsX3Bv cnQgKmRpZ19wb3J0LAo+ID4gPiAgCWRpZ19wb3J0LT50Y19sZWdhY3lfcG9ydCA9ICFkaWdfcG9y dC0+dGNfbGVnYWN5X3BvcnQ7Cj4gPiA+ICB9Cj4gPiA+ICAKPiA+ID4gK3N0YXRpYyBpbnQgdGNf Y29sZF9leGl0X3JlcXVlc3Qoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRldl9wcml2KQo+ID4g PiArewo+ID4gPiArCWludCByZXQ7Cj4gPiA+ICsKPiA+ID4gKwlkbyB7Cj4gPiA+ICsJCXJldCA9 IHNhbmR5YnJpZGdlX3Bjb2RlX3dyaXRlX3RpbWVvdXQoZGV2X3ByaXYsCj4gPiA+ICsJCQkJCQkg ICAgICBJQ0xfUENPREVfRVhJVF9UQwo+ID4gPiBDT0xELCAwLAo+ID4gPiArCQkJCQkJICAgICAg MjUwLCAxKTsKPiA+ID4gKwo+ID4gPiArCX0gd2hpbGUgKHJldCA9PSAtRUFHQUlOKTsKPiA+ID4g Kwo+ID4gPiArCURSTV9ERUJVR19LTVMoInRjY29sZCBleGl0ICVzXG4iLCByZXQgPT0gMCA/ICJz dWNjZWVkZWQiIDoKPiA+ID4gImZhaWxlZCIpOwo+ID4gPiArCj4gPiA+ICsJcmV0dXJuIHJldDsK PiA+ID4gK30KPiA+ID4gKwo+ID4gPiAgc3RhdGljIHUzMiB0Y19wb3J0X2xpdmVfc3RhdHVzX21h c2soc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydAo+ID4gPiAqZGlnX3BvcnQpCj4gPiA+ICB7Cj4g PiA+ICAJc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmk5MTUgPSB0b19pOTE1KGRpZ19wb3J0LQo+ ID4gPiA+YmFzZS5iYXNlLmRldik7Cj4gPiA+IEBAIC0xNzcsMTMgKzE5NCwyMSBAQCBzdGF0aWMg dTMyIHRjX3BvcnRfbGl2ZV9zdGF0dXNfbWFzayhzdHJ1Y3QKPiA+ID4gaW50ZWxfZGlnaXRhbF9w b3J0ICpkaWdfcG9ydCkKPiA+ID4gIAl1MzIgbWFzayA9IDA7Cj4gPiA+ICAJdTMyIHZhbDsKPiA+ ID4gIAo+ID4gPiArCWlmIChpbnRlbF91bmNvcmVfcmVhZCh1bmNvcmUsIFNERUlTUikgJgo+ID4g PiBTREVfVENfSE9UUExVR19JQ1AodGNfcG9ydCkpCj4gPiA+ICsJCW1hc2sgfD0gQklUKFRDX1BP UlRfTEVHQUNZKTsKPiA+ID4gKwo+ID4gPiAgCXZhbCA9IGludGVsX3VuY29yZV9yZWFkKHVuY29y ZSwKPiA+ID4gIAkJCQlQT1JUX1RYX0RGTEVYRFBTUChkaWdfcG9ydC0KPiA+ID4gPnRjX3BoeV9m aWEpKTsKPiA+ID4gIAo+ID4gPiAgCWlmICh2YWwgPT0gMHhmZmZmZmZmZikgewo+ID4gPiAtCQlE Uk1fREVCVUdfS01TKCJQb3J0ICVzOiBQSFkgaW4gVENDT0xELCBub3RoaW5nCj4gPiA+IGNvbm5l Y3RlZFxuIiwKPiA+ID4gLQkJCSAgICAgIGRpZ19wb3J0LT50Y19wb3J0X25hbWUpOwo+ID4gPiAt CQlyZXR1cm4gbWFzazsKPiA+ID4gKwkJaWYgKG1hc2spCj4gPiA+ICsJCQl0Y19jb2xkX2V4aXRf cmVxdWVzdChpOTE1KTsKPiAKPiAKPiBTb3JyeSBmb3IgdGhlIGRlbGF5LCB3YXMgT09PLgo+IAo+ ID4gCj4gPiBUaGUgc2VtYW50aWMgb2YgdGhlIG1ib3ggY29tbWFuZCB0aGlzIG5lZWRzIGlzIGlu aGVyZW50bHkgcmFjeSBvbgo+ID4gc3lzdGVtcyB3aXRoIHByZWVtcHRpb24sIHRoZSBpbnN0cnVj dGlvbiB0byB1c2UgaXQgaXM6Cj4gPiAKPiA+ICIiIgo+ID4gSXNzdWUgR1QgRHJpdmVyIG1haWxi b3ggY29tbWFuZCB0byBleGl0IFRDQ09MRCwgdGhlbiBjb21wbGV0ZSBzdGVwcwo+ID4gYi1kCj4g PiB3aXRoaW4gNTAwIG1pbGxpc2Vjb25kcyB0byBwcmV2ZW50IHJlLWVudHJ5Lgo+ID4gIiIiCj4g PiAKPiA+IFdlJ2QgaGF2ZSB0byByZWFjaCB0aGUgcG9pbnQgd2hlcmUgd2UgZW5hYmxlIHRoZSBB VVggcG93ZXIgaW4gNTAwbXMsCj4gPiB3aGljaCBjYW4ndCBiZSBndWFyYW50ZWVkLiBNb3Jlb3Zl ciBUQ0NPTEQgY291bGQgYmUgZW50ZXJlZCBqdXN0Cj4gPiBhZnRlcgo+ID4gcmVhZGluZyBQT1JU X1RYX0RGTEVYRFBTUCwgc28gd2UgbWF5IG5vdCBkZXRlY3QgaXQuCj4gPiAKPiA+IFdoYXQgd2Ug Y2FuIGRvIC0gYWZ0ZXIgZGlzY3Vzc2luZyB3aXRoIEhXIGZvbGtzIC0gaXMgdG8gZmlyc3QgcmVx dWVzdAo+ID4gQVVYIHBvd2VyIGFuZCB0aGVuIGlzc3VlIHRoZSBtYm94IGNvbW1hbmQsIHdoaWNo IHByZXZlbnRzIFRDQ09MRAo+ID4gcmUtZW50cnkgdW50aWwgcmVsZWFzaW5nIHRoZSBBVVggcG93 ZXIgcmVxdWVzdC4gVGhpcyBhbHNvIG5lZWRzCj4gPiBpZ25vcmluZwo+ID4gdGhlIHRpbWVvdXQg b2YgdGhlIEFVWCBwb3dlciBlbmFibGluZyBBQ0ssIHNpbmNlIGl0IHdpbGwgb25seSBiZQo+ID4g QUNLZWQKPiA+IGFmdGVyIGV4aXRpbmcgVENDT0xELgo+IAo+IAo+IEh1dW0gbG9va3MgbW9yZSBy b2J1c3QgaW5kZWVkLgo+IAo+ID4gCj4gPiBTbyBJIHRoaW5rIHdlIHNob3VsZCBibG9jayBUQ0NP TEQgdGhpcyB3YXkgaW4gX19pbnRlbF90Y19wb3J0X2xvY2soKToKPiA+IAo+ID4gCWlmIHRjX2xp bmtfcmVmY291bnQ9PTA6Cj4gPiAJCWludGVsX2Rpc3BsYXlfcG93ZXJfZ2V0KFBPV0VSX0RPTUFJ Tl9BVVhfPHBvcnQ+KQo+ID4gCQl0Y19jb2xkX2V4aXRfcmVxdWVzdCgpCj4gCj4gU28gZm9yIG5v bi1sZWdhY3kgdGhlIElPTSByZXF1ZXN0IHRvIGV4aXQgVENDT0xEIGNvdWxkIGhhdmUgdGltZWQg b3V0Cj4gYXQgdGhpcyBwb2ludC4gQnV0IGZvciBtb3N0IGNhc2VzIHRoaXMgd2lsbCBub3QgaGFw cGVuLCB3aHkgbm90IGhlcmUKPiByZWFkIG9uZSBGSUEgcmVnaXN0ZXIgYW5kIGNoZWNrIGlmID09 IDB4ZmZmZmZmZmYgaWYgc28gd2UgY2FsbAo+IHRjX2NvbGRfZXhpdF9yZXF1ZXN0KCkuCgpUaGF0 IHdvdWxkIGJlIHJhY3ksIFRDQ09MRCBjb3VsZCBiZSBlbnRlcmVkIHJpZ2h0IGFmdGVyIGRvaW5n IHRoZSBGSUEKcmVnIGNoZWNrLiBHZXR0aW5nIHRoZSBBVVggcG93ZXIgcmVmIGFsb25lIHdvbid0 IHByZXZlbnQgYSBUQ0NPTEQgZW50cnkKdW50aWwgdGhlIFBDT0RFIGNvbW1hbmQgaGFzIGNvbXBs ZXRlZC4KCj4gCj4gPiAJCWlmIGludGVsX3RjX3BvcnRfbmVlZHNfcmVzZXQoKToKPiA+IAkJCWlu dGVsX3RjX3BvcnRfcmVzZXRfbW9kZSgpCj4gPiAJCWlmIHRjX21vZGUgIT0gTEVHQUNZOgo+ID4g CQkJaW50ZWxfZGlzcGxheV9wb3dlcl9wdXQoUE9XRVJfRE9NQUlOX0FVWF88cG9ydD4KPiAKPiBB bHNvIHdoeSBwb3dlcl9wdXQoKSBmb3Igbm9uLWxlZ2FjeT8gYSBwcmVlbXB0aW9uIGNvdWxkIGhh cHBlbiBhZnRlcgo+IGxvY2soKSBhbmQgY2F1c2UgYSBUQ0NPTEQgYmVmb3JlIHRoZSBuZWVkZWQg cmVhZHMvd3JpdGVzIHRvIEZJQSBpcwo+IGRvbmUuCgpUaGUgbmV3IFBDT0RFIGNvbW1hbmQgd2Fz IG9ubHkgYWRkZWQgZm9yIGxlZ2FjeSBhbmQgdGhlIEFVWCBwb3dlcgpyZWZlcmVuY2UgbWFrZXMg YSBkaWZmZXJlbmNlIG9ubHkgaW4gdGhhdCBtb2RlLiBJbiBEUC1hbHQgbW9kZSB0aGUKRFBDU1NT LkRQUE1TVEMgZmxhZyBwcmV2ZW50cyBUQ0NPTEQuCgpJbiBUQlQgbW9kZSB0aGUgVEJUIEFVWCBw b3dlciByZWYgd291bGQgbm90IHByZXZlbnQgVENDT0xELiBJbiB0aGF0IG1vZGUKd2UgZG9uJ3Qg YWNjZXNzIEZJQSByZWdzIGFmdGVyd2FyZHMgYW5kCiJ0aGUgVEJUIGNvbnRyb2xsZXIgcHJldmVu dHMgVENDT0xEIHdoaWxlIGl0IHVzZXMgdGhlIGNvbm5lY3Rpb24iLgoKPiAKPiBCZXR0ZXIgcmVt b3ZlIHRoaXMgYmxvY2sgYW5kIG9ubHkgcG93ZXJfcHV0KCkgd2hlbiByZW1vdmluZyB0aGUgbGFz dAo+IHJlZmVyZW5jZSBvbiBpbnRlbF90Y19wb3J0X3VubG9jaygpCj4gCj4gPiApCj4gPiAKPiA+ IHRoZW4gdW5ibG9jayBUQ0NPTEQgaW4gaW50ZWxfdGNfcG9ydF91bmxvY2soKToKPiA+IAo+ID4g CWlmIHRjX2xpbmtfcmVmY291bnQ9PTAgYW5kIHRjX21vZGUgPT0gTEVHQUNZOgo+ID4gCQlpbnRl bF9kaXNwbGF5X3Bvd2VyX3B1dChQT1dFUl9ET01BSU5fQVVYXzxwb3J0PikKPiA+IAkKPiA+ID4g Kwo+ID4gPiArCQlpZiAodmFsID09IDB4ZmZmZmZmZmYpIHsKPiA+ID4gKwkJCURSTV9ERUJVR19L TVMoIlBvcnQgJXM6IFBIWSBpbiBUQ0NPTEQsIG5vdGhpbmcKPiA+ID4gY29ubmVjdGVkXG4iLAo+ ID4gPiArCQkJCSAgICAgIGRpZ19wb3J0LT50Y19wb3J0X25hbWUpOwo+ID4gPiArCQkJcmV0dXJu IG1hc2s7Cj4gPiA+ICsJCX0KPiA+ID4gIAl9Cj4gPiA+ICAKPiA+ID4gIAlpZiAodmFsICYgVENf TElWRV9TVEFURV9UQlQoZGlnX3BvcnQtPnRjX3BoeV9maWFfaWR4KSkKPiA+ID4gQEAgLTE5MSw5 ICsyMTYsNiBAQCBzdGF0aWMgdTMyIHRjX3BvcnRfbGl2ZV9zdGF0dXNfbWFzayhzdHJ1Y3QKPiA+ ID4gaW50ZWxfZGlnaXRhbF9wb3J0ICpkaWdfcG9ydCkKPiA+ID4gIAlpZiAodmFsICYgVENfTElW RV9TVEFURV9UQyhkaWdfcG9ydC0+dGNfcGh5X2ZpYV9pZHgpKQo+ID4gPiAgCQltYXNrIHw9IEJJ VChUQ19QT1JUX0RQX0FMVCk7Cj4gPiA+ICAKPiA+ID4gLQlpZiAoaW50ZWxfdW5jb3JlX3JlYWQo dW5jb3JlLCBTREVJU1IpICYKPiA+ID4gU0RFX1RDX0hPVFBMVUdfSUNQKHRjX3BvcnQpKQo+ID4g PiAtCQltYXNrIHw9IEJJVChUQ19QT1JUX0xFR0FDWSk7Cj4gPiA+IC0KPiA+ID4gIAkvKiBUaGUg c2luayBjYW4gYmUgY29ubmVjdGVkIG9ubHkgaW4gYSBzaW5nbGUgbW9kZS4gKi8KPiA+ID4gIAlp ZiAoIVdBUk5fT04oaHdlaWdodDMyKG1hc2spID4gMSkpCj4gPiA+ICAJCXRjX3BvcnRfZml4dXBf bGVnYWN5X2ZsYWcoZGlnX3BvcnQsIG1hc2spOwo+ID4gPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cmVnLmgKPiA+ID4gaW5kZXggMDU4YWE1Y2E4YjczLi4zNWMzNzI0YjdmZWYgMTAwNjQ0Cj4gPiA+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgKPiA+ID4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ID4gPiBAQCAtODg2MCw2ICs4ODYwLDcgQEAgZW51 bSB7Cj4gPiA+ICAjZGVmaW5lICAgICBJQ0xfUENPREVfTUVNX1NTX1JFQURfUUdWX1BPSU5UX0lO Rk8ocG9pbnQpCSgoKHBvaW4KPiA+ID4gdCkgPDwgMTYpIHwgKDB4MSA8PCA4KSkKPiA+ID4gICNk ZWZpbmUgICBHRU42X1BDT0RFX1JFQURfRF9DT01QCQkweDEwCj4gPiA+ICAjZGVmaW5lICAgR0VO Nl9QQ09ERV9XUklURV9EX0NPTVAJCTB4MTEKPiA+ID4gKyNkZWZpbmUgICBJQ0xfUENPREVfRVhJ VF9UQ0NPTEQJCQkweDEyCj4gPiA+ICAjZGVmaW5lICAgSFNXX1BDT0RFX0RFX1dSSVRFX0ZSRVFf UkVRCQkweDE3Cj4gPiA+ICAjZGVmaW5lICAgRElTUExBWV9JUFNfQ09OVFJPTAkJCTB4MTkKPiA+ ID4gICAgICAgICAgICAgIC8qIFNlZSBhbHNvIElQU19DVEwgKi8KPiA+ID4gLS0gCj4gPiA+IDIu MjMuMAo+ID4gPiAKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4