All of lore.kernel.org
 help / color / mirror / Atom feed
From: Luca Coelho <luca@coelho.fi>
To: kvalo@codeaurora.org
Cc: linux-wireless@vger.kernel.org
Subject: [PATCH 02/12] iwlwifi: mvm: remove else-if in iwl_send_phy_cfg_cmd()
Date: Sat, 19 Oct 2019 12:38:52 +0300	[thread overview]
Message-ID: <20191019123747.2ee90c430c5b.I793862b611507a827393d544ffbd4fa7cce3c79c@changeid> (raw)
In-Reply-To: <20191019093902.29823-1-luca@coelho.fi>

From: Luca Coelho <luciano.coelho@intel.com>

We return in the if block, so it's unnecessary to have an else
statement.  Remove it.

Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/fw.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
index 7afdf0c1b1e9..aa644b82e93c 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/fw.c
@@ -512,9 +512,10 @@ static int iwl_send_phy_cfg_cmd(struct iwl_mvm *mvm)
 	enum iwl_ucode_type ucode_type = mvm->fwrt.cur_fw_img;
 
 	if (iwl_mvm_has_unified_ucode(mvm) &&
-	    !mvm->trans->cfg->tx_with_siso_diversity) {
+	    !mvm->trans->cfg->tx_with_siso_diversity)
 		return 0;
-	} else if (mvm->trans->cfg->tx_with_siso_diversity) {
+
+	if (mvm->trans->cfg->tx_with_siso_diversity) {
 		/*
 		 * TODO: currently we don't set the antenna but letting the NIC
 		 * to decide which antenna to use. This should come from BIOS.
-- 
2.23.0


  parent reply	other threads:[~2019-10-19  9:39 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-19  9:38 [PATCH 00/12] iwlwifi: updates intended for v5.5 2019-19 Luca Coelho
2019-10-19  9:38 ` [PATCH 01/12] iwlwifi: mvm: fix support for single antenna diversity Luca Coelho
2019-10-19  9:38 ` Luca Coelho [this message]
2019-10-19  9:38 ` [PATCH 03/12] iwlwifi: nvm: update iwl_uhb_nvm_channels Luca Coelho
2019-10-25  7:46   ` Kalle Valo
2019-11-13  8:53     ` Luca Coelho
2019-11-13  9:29   ` [PATCH v2] " Luca Coelho
2019-11-13 13:20     ` Kalle Valo
2019-10-19  9:38 ` [PATCH 04/12] iwlwifi: mvm: in VHT connection use only VHT capabilities Luca Coelho
2019-10-19  9:38 ` [PATCH 05/12] iwlwifi: pcie: make iwl_pcie_gen2_update_byte_tbl static Luca Coelho
2019-10-19  9:38 ` [PATCH 06/12] iwlwifi: dbg_ini: support dump collection upon assert during D3 Luca Coelho
2019-10-19  9:38 ` [PATCH 07/12] iwlwifi: scan: create function for scan scheduling params Luca Coelho
2019-10-19  9:38 ` [PATCH 08/12] iwlwifi: scan: Create function to build scan cmd Luca Coelho
2019-10-19  9:38 ` [PATCH 09/12] iwlwifi: scan: adapt the code to use api ver 11 Luca Coelho
2019-10-19  9:39 ` [PATCH 10/12] iwlwifi: mvm: print rate_n_flags in a pretty format Luca Coelho
2019-10-19  9:39 ` [PATCH 11/12] iwlwifi: FW API: reference enum in docs of modify_mask Luca Coelho
2019-10-19  9:39 ` [PATCH 12/12] iwlwifi: bump FW API to 51 for 22000 series Luca Coelho

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191019123747.2ee90c430c5b.I793862b611507a827393d544ffbd4fa7cce3c79c@changeid \
    --to=luca@coelho.fi \
    --cc=kvalo@codeaurora.org \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.