All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prabhakar Kushwaha <prabhakar.pkin@gmail.com>
To: linux-kselftest@vger.kernel.org
Cc: skhan@linuxfoundation.org,
	Prabhakar Kushwaha <prabhakar.pkin@gmail.com>,
	Prabhakar Kushwaha <pkushwaha@marvell.com>,
	Cristian Marussi <cristian.marussi@arm.com>
Subject: [PATCH] kselftest: Fix NULL INSTALL_PATH for TARGETS runlist
Date: Sun, 20 Oct 2019 17:54:52 +0530	[thread overview]
Message-ID: <20191020122452.3345-1-prabhakar.pkin@gmail.com> (raw)

As per commit 131b30c94fbc ("kselftest: exclude failed TARGETS from
runlist") failed targets were excluded from the runlist. But value
$$INSTALL_PATH is always NULL. It should be $INSTALL_PATH instead
$$INSTALL_PATH.

So, fix Makefile to use $INSTALL_PATH. 

Signed-off-by: Prabhakar Kushwaha <pkushwaha@marvell.com>
Signed-off-by: Prabhakar Kushwaha <prabhakar.pkin@gmail.com>
CC: Cristian Marussi <cristian.marussi@arm.com>
---
 tools/testing/selftests/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile
index 4cdbae6f4e61..612f6757015d 100644
--- a/tools/testing/selftests/Makefile
+++ b/tools/testing/selftests/Makefile
@@ -213,7 +213,7 @@ ifdef INSTALL_PATH
 	@# included in the generated runlist.
 	for TARGET in $(TARGETS); do \
 		BUILD_TARGET=$$BUILD/$$TARGET;	\
-		[ ! -d $$INSTALL_PATH/$$TARGET ] && echo "Skipping non-existent dir: $$TARGET" && continue; \
+		[ ! -d $(INSTALL_PATH)/$$TARGET ] && echo "Skipping non-existent dir: $$TARGET" && continue; \
 		echo "[ -w /dev/kmsg ] && echo \"kselftest: Running tests in $$TARGET\" >> /dev/kmsg" >> $(ALL_SCRIPT); \
 		echo "cd $$TARGET" >> $(ALL_SCRIPT); \
 		echo -n "run_many" >> $(ALL_SCRIPT); \
-- 
2.17.0


             reply	other threads:[~2019-10-20 12:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-20 12:24 Prabhakar Kushwaha [this message]
2019-10-21 10:45 ` [PATCH] kselftest: Fix NULL INSTALL_PATH for TARGETS runlist Cristian Marussi
2019-10-22  3:52   ` Prabhakar Kushwaha
2019-10-22  9:49     ` Cristian Marussi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191020122452.3345-1-prabhakar.pkin@gmail.com \
    --to=prabhakar.pkin@gmail.com \
    --cc=cristian.marussi@arm.com \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=pkushwaha@marvell.com \
    --cc=skhan@linuxfoundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.