All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sebastian Reichel <sre@kernel.org>
To: Dan Murphy <dmurphy@ti.com>
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] dt: power: Add the bq2515x family dt bindings
Date: Sun, 20 Oct 2019 14:30:14 +0200	[thread overview]
Message-ID: <20191020123014.trvn5auxbv6ftngj@earth.universe> (raw)
In-Reply-To: <20190930143137.21624-2-dmurphy@ti.com>

[-- Attachment #1: Type: text/plain, Size: 2933 bytes --]

Hi Dan,

On Mon, Sep 30, 2019 at 09:31:36AM -0500, Dan Murphy wrote:
> Add the bindings for the bq25150 and bq25155 500mA
>  charging IC from Texas Instruments.
> 
> Datasheet:
> http://www.ti.com/lit/ds/symlink/bq25150.pdf
> http://www.ti.com/lit/ds/symlink/bq25155.pdf
> 
> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> ---
>  .../bindings/power/supply/bq2515x.txt         | 48 +++++++++++++++++++

This should use the new YAML binding style.

>  1 file changed, 48 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/power/supply/bq2515x.txt
> 
> diff --git a/Documentation/devicetree/bindings/power/supply/bq2515x.txt b/Documentation/devicetree/bindings/power/supply/bq2515x.txt
> new file mode 100644
> index 000000000000..98203ab53d44
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/power/supply/bq2515x.txt
> @@ -0,0 +1,48 @@
> +Binding for TI bq25150 500-mA Linear charger
> +
> +The BQ25150 is a highly integrated battery charge management IC that integrates
> +the most common functions for wearable devices, namely a charger, an
> +output voltage rail, ADC for battery and system monitoring, and
> +push-button controller.
> +
> +Required Properties:
> +	- compatible: Should contain one of the following:
> +		"ti,bq25150"
> +		"ti,bq25155"
> +	- reg: int I2c address 0x6b
> +	- #address-cells: 1;
> +	- #size-cells: = 0;
> +
> +Optional Properties:
> +	- ti,battery-regulation-voltage: integer, maximum charging voltage in mV.
> +		Values range from 3600->4600mV
> +	- ti,charge-current: integer, maximum charging current in mA.
> +		Values range from 50->600mA

Those values should be in uV and uA. Also the values basically
describe the dumb battery, so please use this binding:

Documentation/devicetree/bindings/power/supply/battery.txt

> +	- reset-gpios: GPIO used for Master reset
> +	- low-power-gpios: GPIO used for low power mode of IC.
> +	- charge-enable-gpios: GPIO used to turn on and off charging.
> +	- pg-gpios: GPIO used for connecting the bq2515x device PG (Power Good)
> +		pin.  This pin should be used if possible as this is the
> +		recommended way to obtain the charger's input PG state.
> +		If this pin is not specified a software-based approach for PG
> +		detection is used.
> +
> +Example
> +bq25150@6b {

charger@6b

> +	compatible = "ti,bq25150";
> +	reg = <0x6b>;
> +	#address-cells = <1>;
> +	#size-cells = <0>;
> +
> +	pg-gpios = <&gpio1 28 GPIO_ACTIVE_HIGH>;
> +	reset-gpios = <&gpio0 14 GPIO_ACTIVE_HIGH>;
> +	low-power-gpios = <&gpio0 15 GPIO_ACTIVE_HIGH>;
> +	charge-enable-gpios = <&gpio0 13 GPIO_ACTIVE_LOW>;
> +
> +	ti,charge-current = <300>;
> +	ti,battery-regulation-voltage = <4200>;
> +};
> +
> +Reference Datasheet:
> +http://www.ti.com/lit/ds/symlink/bq25150.pdf
> +http://www.ti.com/lit/ds/symlink/bq25155.pdf
> -- 
> 2.22.0.214.g8dca754b1e
> 

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2019-10-20 12:30 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-30 14:31 [PATCH 1/3] power_supply: Add additional health properties to the header Dan Murphy
2019-09-30 14:31 ` [PATCH 2/3] dt: power: Add the bq2515x family dt bindings Dan Murphy
2019-10-20 12:30   ` Sebastian Reichel [this message]
2019-10-21 19:36     ` Dan Murphy
2019-09-30 14:31 ` [PATCH 3/3] power: supply: bq2515x: Introduce the bq2515x family Dan Murphy
2019-10-20 12:15   ` Sebastian Reichel
2019-10-23 19:02     ` Dan Murphy
2019-10-20 12:43   ` Sebastian Reichel
2019-10-20 12:25 ` [PATCH 1/3] power_supply: Add additional health properties to the header Sebastian Reichel
2019-10-21 19:35   ` Dan Murphy

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191020123014.trvn5auxbv6ftngj@earth.universe \
    --to=sre@kernel.org \
    --cc=dmurphy@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.