From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E095FCA9EB5 for ; Mon, 21 Oct 2019 06:16:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AE368206C2 for ; Mon, 21 Oct 2019 06:16:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eG9C2g2A" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726915AbfJUGQB (ORCPT ); Mon, 21 Oct 2019 02:16:01 -0400 Received: from mail-pf1-f196.google.com ([209.85.210.196]:39304 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726125AbfJUGQB (ORCPT ); Mon, 21 Oct 2019 02:16:01 -0400 Received: by mail-pf1-f196.google.com with SMTP id v4so7728843pff.6 for ; Sun, 20 Oct 2019 23:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=z8AislL9bBizOL/3zmH/pFdDSRFzv2U9ezQYDPpf/uY=; b=eG9C2g2A4PaRfDjkuUYycqvHLpwFwwXFoIHPEJB4S4aqUilQqRiRg5/brU94N70PeD +XbbwDmqAiX+M0nZWiPdZ0r1qUm3xvVo2fsi3TL1IMD9cwuZdQeu1BhWWWD3vazDac0O z1Buvm/bypyjVu5q4P3no2LuGvFRpIYNywAetJM8+Gu75G5kIkeStD/j2p7kWv+r2ji8 911oMY2QK9mqZi22+AJOBF/2NTC59N97cofnI1NMRIOMHtRMcTjpRrZRIzalyGpKHNhp Gzw/APURFJ/dMAvGQ7oXi5ITYR04qndf6BcxFQOZ1srgtVPMKwqf58nuZdyTkeaSD2O+ FPyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=z8AislL9bBizOL/3zmH/pFdDSRFzv2U9ezQYDPpf/uY=; b=e0NGZ8y0yv0I2cxqhSn9mt3Yjj1ej5ktyImaA/TYKrPQ9cKDMFEYScLG0LNJeByXKV 8XRg0MG17Gi9D+AIgtXgBixhItDYvVR8o2JbQKWere81fEE5wIVD/Ukau0WEVpfe5VND 8ifMI4OtgROL2R5aFMUKi1ApDZWsOuJ74AREgvees39fLXBqYPa9Qw9He2LzEfW9FR3n bLoBqbnRyWSHsuL6mrhvlkweH2qVXOfAL2/8UJT7+E1P0gZwSrA2Z3oHNwBnsJwrtgBT WKxlDMa6dNUeDxIuG0cMQ8+jv9c9VBV098PyV28Ghk2WmlGYIe4RoaI9XPGxODdvR0+B gpVQ== X-Gm-Message-State: APjAAAXk9IsA2SizhuBOpuCfcEB1soca+6j6NKc5DEDZqZfx0PG1PYbe L1u5qc15DuVUkuAEiJGn1gf8 X-Google-Smtp-Source: APXvYqzq3YMDZBcNbZq7GPKnRRFgy2SO4k0a07WKf/88S3YXLlZv9fCcV5ut+NIOUDsG42YN1kRNVQ== X-Received: by 2002:a63:ea48:: with SMTP id l8mr24258354pgk.160.1571638560579; Sun, 20 Oct 2019 23:16:00 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2405:204:700f:8db6:2442:890f:ac37:8127]) by smtp.gmail.com with ESMTPSA id a13sm16828601pfg.10.2019.10.20.23.15.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 Oct 2019 23:15:59 -0700 (PDT) Date: Mon, 21 Oct 2019 11:45:51 +0530 From: Manivannan Sadhasivam To: Linus Walleij Cc: Bartosz Golaszewski , Linux ARM , linux-unisoc@lists.infradead.org, "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Orson Zhai Subject: Re: [PATCH v2 1/4] dt-bindings: gpio: Add devicetree binding for RDA Micro GPIO controller Message-ID: <20191021061551.GA12001@Mani-XPS-13-9360> References: <20191015173026.9962-1-manivannan.sadhasivam@linaro.org> <20191015173026.9962-2-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org Hi Linus, On Wed, Oct 16, 2019 at 02:27:44PM +0200, Linus Walleij wrote: > On Tue, Oct 15, 2019 at 7:30 PM Manivannan Sadhasivam > wrote: > > > Add YAML devicetree binding for RDA Micro GPIO controller. > > > > Signed-off-by: Manivannan Sadhasivam > > First: this looks awesome to me, > > Second: since this is kind of a first... could we move the standard GPIOchip > YAML business into a generic gpiochip .yaml file? > > We currently only have pl061-gpio.yaml and this would duplicate a lot > of the stuff from that yaml file. > > If you look at how > display/panel/panel-common.yaml > is used from say > display/panel/ti,nspire.yaml > > Could we do something similar and lift out all the generics from > gpio-pl061.yaml to > gpio-common.yaml > and reference that also in the new binding? > > If it seems hard, tell me and I can take a stab at it. > Eventhough I really want to help you here, I'm running out of time (and you know why). Let's consider merging this, and I'll come back at it later. Thanks, Mani > Yours, > Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A4EACA9EB5 for ; Mon, 21 Oct 2019 06:16:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0B72520656 for ; Mon, 21 Oct 2019 06:16:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LwbH+xwW"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="eG9C2g2A" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0B72520656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NN3mEL7BQqN04q9Mnbj+91ssypaPpg1SmC6Cvf5Y/P8=; b=LwbH+xwW2SUq1q 4A6XaGLghaGu7A1z4CS255KD/bNNg9U5kjW4p8fkbZAiROiC2SI/IQAibW3fXvw5fQuXfFWSfhThG SPdN9u7Ufn97r4AW4TODyhc1QkOEtvcRJ0EeB7KXt+sVabZ1VFmhwQh4AKbJqX6TunKvE7wB0N4El d+lRb14JrJx4cL1Jn0s3yB5BQ+lJzlWLvVoN4JdK7VjzukNfeO74wPfnWsyJa5xquKFrmrF60xrN6 dYDJQFi9LiLKCpoGl1pT/A8SWB6ciOF1Ewho/vA/41Wv2VI5LFS3FpSGJYeDM6UeYDg3bK3bMd5Pf 05q+Y+eKchLctD4jEdvA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMQz7-0000s7-Gi; Mon, 21 Oct 2019 06:16:05 +0000 Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMQz3-0000qd-VU for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2019 06:16:03 +0000 Received: by mail-pg1-x543.google.com with SMTP id p12so7106311pgn.6 for ; Sun, 20 Oct 2019 23:16:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=z8AislL9bBizOL/3zmH/pFdDSRFzv2U9ezQYDPpf/uY=; b=eG9C2g2A4PaRfDjkuUYycqvHLpwFwwXFoIHPEJB4S4aqUilQqRiRg5/brU94N70PeD +XbbwDmqAiX+M0nZWiPdZ0r1qUm3xvVo2fsi3TL1IMD9cwuZdQeu1BhWWWD3vazDac0O z1Buvm/bypyjVu5q4P3no2LuGvFRpIYNywAetJM8+Gu75G5kIkeStD/j2p7kWv+r2ji8 911oMY2QK9mqZi22+AJOBF/2NTC59N97cofnI1NMRIOMHtRMcTjpRrZRIzalyGpKHNhp Gzw/APURFJ/dMAvGQ7oXi5ITYR04qndf6BcxFQOZ1srgtVPMKwqf58nuZdyTkeaSD2O+ FPyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=z8AislL9bBizOL/3zmH/pFdDSRFzv2U9ezQYDPpf/uY=; b=LaaTi52zmvXCWPH79OAT0FKfxULYHuZYdkMnHqps5GvOym2DoOpGiwwLDvhm19WIkW CT1HPKq/xzxMmzmZCljvcwStEUIm/QJLwyzu9HlukIUBT9998pKIHxZSrWzcdCMw1dtr 4+n4KtPn8yP5AWewAP9aNMnTrQMgekC94t2Yqb5txOPRsYP8v8ub9mSt4UJumQ/Ix/wU +vHu5GpKkzpmDQFQXh9utYFYTBddw7AfdfclvdCMta+HwoHMzp+BJfIY9DURqhRH7FRk +JU6eN3vyan8g8VPBsIGxN+ssr4+obatZuYfWdTPnzObugo3SnGjUjLunxyGJvbnxQmC aGNg== X-Gm-Message-State: APjAAAVnxwDHOBPPSH+V/oERz6Ips7TdW8CnmQWEgSu2IBVDsq9HREya r0kBlFCNCJfHOxaDxM/0etaQ X-Google-Smtp-Source: APXvYqzq3YMDZBcNbZq7GPKnRRFgy2SO4k0a07WKf/88S3YXLlZv9fCcV5ut+NIOUDsG42YN1kRNVQ== X-Received: by 2002:a63:ea48:: with SMTP id l8mr24258354pgk.160.1571638560579; Sun, 20 Oct 2019 23:16:00 -0700 (PDT) Received: from Mani-XPS-13-9360 ([2405:204:700f:8db6:2442:890f:ac37:8127]) by smtp.gmail.com with ESMTPSA id a13sm16828601pfg.10.2019.10.20.23.15.55 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Sun, 20 Oct 2019 23:15:59 -0700 (PDT) Date: Mon, 21 Oct 2019 11:45:51 +0530 From: Manivannan Sadhasivam To: Linus Walleij Subject: Re: [PATCH v2 1/4] dt-bindings: gpio: Add devicetree binding for RDA Micro GPIO controller Message-ID: <20191021061551.GA12001@Mani-XPS-13-9360> References: <20191015173026.9962-1-manivannan.sadhasivam@linaro.org> <20191015173026.9962-2-manivannan.sadhasivam@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191020_231602_021772_FE4829DF X-CRM114-Status: GOOD ( 14.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:GPIO SUBSYSTEM" , "linux-kernel@vger.kernel.org" , Bartosz Golaszewski , linux-unisoc@lists.infradead.org, Orson Zhai , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Linus, On Wed, Oct 16, 2019 at 02:27:44PM +0200, Linus Walleij wrote: > On Tue, Oct 15, 2019 at 7:30 PM Manivannan Sadhasivam > wrote: > > > Add YAML devicetree binding for RDA Micro GPIO controller. > > > > Signed-off-by: Manivannan Sadhasivam > > First: this looks awesome to me, > > Second: since this is kind of a first... could we move the standard GPIOchip > YAML business into a generic gpiochip .yaml file? > > We currently only have pl061-gpio.yaml and this would duplicate a lot > of the stuff from that yaml file. > > If you look at how > display/panel/panel-common.yaml > is used from say > display/panel/ti,nspire.yaml > > Could we do something similar and lift out all the generics from > gpio-pl061.yaml to > gpio-common.yaml > and reference that also in the new binding? > > If it seems hard, tell me and I can take a stab at it. > Eventhough I really want to help you here, I'm running out of time (and you know why). Let's consider merging this, and I'll come back at it later. Thanks, Mani > Yours, > Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel