From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBE35CA9EB7 for ; Mon, 21 Oct 2019 10:05:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 926F320684 for ; Mon, 21 Oct 2019 10:05:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1571652323; bh=pgSk2KtduBp9PVIz+N5OKtQK4nmDH7RPQ5MQnH3IydA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=n/WS9XXgDUWJeCO+pKQqAr0PEz7vKdlrMhm4TuXeFAIBfixIKvYooJXntcytzihl/ 3EqhOvsa3ZNWQw+QbOHnKN3EZ0Mhgy0PGQ5DWmjzwusZtM89ehk8rMIAiqgJZiYNqU 3ZfHVxE32ErakdnB4huAbrlZboKeMRTvXhZf30u4= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727649AbfJUKFW (ORCPT ); Mon, 21 Oct 2019 06:05:22 -0400 Received: from mail-ed1-f66.google.com ([209.85.208.66]:38865 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727640AbfJUKFW (ORCPT ); Mon, 21 Oct 2019 06:05:22 -0400 Received: by mail-ed1-f66.google.com with SMTP id l21so9545580edr.5; Mon, 21 Oct 2019 03:05:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VIly/GOwYf9JLFy1KZhN7RsSTWZDQWPbQNHGbDM5vaQ=; b=X0mwRGFELBv7O9j88NXVr1S4VmvrFBVjtvLIMn9gg5ebCMAT0Bl8qWds9ACAyMo0Fr oOl99FsTSj5BU7g+QpemgdGTAWMOhvsOfp4bfUrX7XKDR9iFBEJQm0LFqzBF40hWG7eN 8nnUmHVL8QwsJ+hUiredAQGKwfhNKj8/JIZxBgB6N1gj1eu0UB7S+NJuZpFnDTOkfbfK 807wG9t27QV8d2O05j6S8F/taqCZAKgVtqRRPnW1tdzVhxU+FrQyNlR1MsLPdDdiNTlj UX3axoicR/amkhaM3z/yZ6EzMthLGOcj3xbD+fp2vDqOeFa4wRNchNMQBglRBKbCLzgw YiRQ== X-Gm-Message-State: APjAAAXLdTETe5E1VhAlhZ+yX0rE5lVfblaBzMYl1D66lwxOLG0hG+E4 aWXfvEILaQENpm89lYPIm8Y= X-Google-Smtp-Source: APXvYqxQjjcwyceE7CWb0t81HxVmTXnzUIM+gkThYKYGIul4COny7XO62D/6deIRXBTPxyD2sN9ecg== X-Received: by 2002:a05:6402:88c:: with SMTP id e12mr10387252edy.170.1571652320623; Mon, 21 Oct 2019 03:05:20 -0700 (PDT) Received: from pi3 ([194.230.155.217]) by smtp.googlemail.com with ESMTPSA id y7sm253102edb.97.2019.10.21.03.05.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2019 03:05:19 -0700 (PDT) Date: Mon, 21 Oct 2019 12:05:17 +0200 From: Krzysztof Kozlowski To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, Herbert Xu , "David S. Miller" , Eric Biggers , linux-arm-kernel@lists.infradead.org, Vladimir Zapolskiy , Kamil Konieczny , linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 07/25] crypto: s5p - switch to skcipher API Message-ID: <20191021100517.GA1780@pi3> References: <20191014121910.7264-1-ard.biesheuvel@linaro.org> <20191014121910.7264-8-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191014121910.7264-8-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Oct 14, 2019 at 02:18:52PM +0200, Ard Biesheuvel wrote: > Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface") > dated 20 august 2015 introduced the new skcipher API which is supposed to > replace both blkcipher and ablkcipher. While all consumers of the API have > been converted long ago, some producers of the ablkcipher remain, forcing > us to keep the ablkcipher support routines alive, along with the matching > code to expose [a]blkciphers via the skcipher API. > > So switch this driver to the skcipher API, allowing us to finally drop the > blkcipher code in the near future. > > Cc: Krzysztof Kozlowski > Cc: Vladimir Zapolskiy > Cc: Kamil Konieczny > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Ard Biesheuvel > --- > drivers/crypto/s5p-sss.c | 191 ++++++++++---------- > 1 file changed, 91 insertions(+), 100 deletions(-) > > diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c > index 010f1bb20dad..e6f1d4d5186c 100644 > --- a/drivers/crypto/s5p-sss.c > +++ b/drivers/crypto/s5p-sss.c > @@ -303,7 +303,7 @@ struct s5p_aes_dev { > void __iomem *aes_ioaddr; > int irq_fc; > > - struct ablkcipher_request *req; > + struct skcipher_request *req; You mix here indentation. Beside that: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAB0BCA9EAF for ; Mon, 21 Oct 2019 10:05:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9CFC42089C for ; Mon, 21 Oct 2019 10:05:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="csyJ4y62" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9CFC42089C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x6FcgPGtY4bSLOG32JwYp325ahAoPH09i1dHd6f28t8=; b=csyJ4y62lwaidG fT4Mlpur4TFngrQhbImgu1lW+PKTdmx/ho2xWhYXx8kl+9GtpQuBpMkoLbiPJY1R+V/VfuDkWU/Jd 9WTVL5nLI5gt+8Y+vEDLoOpd2JB9chxbLQl94G8kIEYlccA77GmYZk34Kjy+mu5ZziVFlHUKaftcn qdCRQyHXLG6QFkKy9/uZn/CijPoQxl+yal5BccKmoKK6JQ8+t5pWSdBVZ3OdzpBB1oh+1ymDuDpre SaRiVlToCHJOrtZ9A9eE74kpbsxfv+ldzBRks33R8svQtaqFODhXSz5M0dO9zWPKo24jSJ8++ROGL XXwFk/h0vepdY2f+fDSg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMUZ5-0002gm-Sm; Mon, 21 Oct 2019 10:05:27 +0000 Received: from mail-ed1-f67.google.com ([209.85.208.67]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMUZ2-0002gI-Hh for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2019 10:05:25 +0000 Received: by mail-ed1-f67.google.com with SMTP id b72so588379edf.1 for ; Mon, 21 Oct 2019 03:05:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=VIly/GOwYf9JLFy1KZhN7RsSTWZDQWPbQNHGbDM5vaQ=; b=WE3NoZbWuE6bwjCn+enqrmH/k/7aEizBvA5s/r5HGgn6PZKOPE9B/xMGE4uK2kww98 Y1xlxMWc/Gq18IEAIM5SKdeJAO3pMUBUyKA0ZSllAk+aOqZJUzbu4dT8kcAz6UTUdvxQ 726bi8Z3qPttHXJa2bCulExg97t7eqKik+qDxtRTzw8foV4QzeLJ5qvE8hfWUI4JXzbM 99xv5tePqMuu0mIG1dsQN1VYo1A7TH6quZkRrQoT5POXiSj0DlC+L0SphHOzebndr6rb kcP40IavXIIfNJtOxPb+HuVHa7UMtpSRJWdUfWSyuULqm0gshuv5tfcVKNsPLpeRW1m3 iUVA== X-Gm-Message-State: APjAAAU20sdFK4xUwR/hNcVLNi69dImyRH6l2WSmnCgetpGhGwsI8XfT ivhqQ/3nmQ0byQ4hzu9crKA= X-Google-Smtp-Source: APXvYqxQjjcwyceE7CWb0t81HxVmTXnzUIM+gkThYKYGIul4COny7XO62D/6deIRXBTPxyD2sN9ecg== X-Received: by 2002:a05:6402:88c:: with SMTP id e12mr10387252edy.170.1571652320623; Mon, 21 Oct 2019 03:05:20 -0700 (PDT) Received: from pi3 ([194.230.155.217]) by smtp.googlemail.com with ESMTPSA id y7sm253102edb.97.2019.10.21.03.05.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Oct 2019 03:05:19 -0700 (PDT) Date: Mon, 21 Oct 2019 12:05:17 +0200 From: Krzysztof Kozlowski To: Ard Biesheuvel Subject: Re: [PATCH 07/25] crypto: s5p - switch to skcipher API Message-ID: <20191021100517.GA1780@pi3> References: <20191014121910.7264-1-ard.biesheuvel@linaro.org> <20191014121910.7264-8-ard.biesheuvel@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191014121910.7264-8-ard.biesheuvel@linaro.org> User-Agent: Mutt/1.12.1 (2019-06-15) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191021_030524_585251_A461451E X-CRM114-Status: GOOD ( 16.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-samsung-soc@vger.kernel.org, Herbert Xu , Eric Biggers , Vladimir Zapolskiy , linux-crypto@vger.kernel.org, Kamil Konieczny , "David S. Miller" , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 14, 2019 at 02:18:52PM +0200, Ard Biesheuvel wrote: > Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface") > dated 20 august 2015 introduced the new skcipher API which is supposed to > replace both blkcipher and ablkcipher. While all consumers of the API have > been converted long ago, some producers of the ablkcipher remain, forcing > us to keep the ablkcipher support routines alive, along with the matching > code to expose [a]blkciphers via the skcipher API. > > So switch this driver to the skcipher API, allowing us to finally drop the > blkcipher code in the near future. > > Cc: Krzysztof Kozlowski > Cc: Vladimir Zapolskiy > Cc: Kamil Konieczny > Cc: linux-samsung-soc@vger.kernel.org > Signed-off-by: Ard Biesheuvel > --- > drivers/crypto/s5p-sss.c | 191 ++++++++++---------- > 1 file changed, 91 insertions(+), 100 deletions(-) > > diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c > index 010f1bb20dad..e6f1d4d5186c 100644 > --- a/drivers/crypto/s5p-sss.c > +++ b/drivers/crypto/s5p-sss.c > @@ -303,7 +303,7 @@ struct s5p_aes_dev { > void __iomem *aes_ioaddr; > int irq_fc; > > - struct ablkcipher_request *req; > + struct skcipher_request *req; You mix here indentation. Beside that: Acked-by: Krzysztof Kozlowski Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel