From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12797CA9EAF for ; Mon, 21 Oct 2019 11:40:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D9F5D2084C for ; Mon, 21 Oct 2019 11:40:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xIoHYOEM" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728507AbfJULkD (ORCPT ); Mon, 21 Oct 2019 07:40:03 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:43910 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727685AbfJULkD (ORCPT ); Mon, 21 Oct 2019 07:40:03 -0400 Received: by mail-wr1-f66.google.com with SMTP id c2so8331976wrr.10 for ; Mon, 21 Oct 2019 04:40:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=tUXlJyf/EwF52UBQUMrINYmFP1uDjIe8LBm7MrH/x50=; b=xIoHYOEMyhGDXoCpQ9jHFyb0ii1+Dwvu1Q9SEfKtsUww4GbJQQy6Z+jQ8cl+fpelw3 ThXt8MFnHE4WeoE8+UnlJTQA1ZYeRuSyGiCfFTKaC0OBBqbot6eli99dXr5TzBuwDLdg hv/656/7etodYAz4ZGpUNsv4u+8lHsnz3JDcP+0QvO0l0qDRgeRmohlWKezDuIXl11Ai bYLHo0gILQbudud59jMRUdxxPNbWw0pXm0FHqeuVlxs2z/vrj8cchV+e99cxB6Xbntp6 Qh4S59PcwuPmISifpJ/a8LUwevqg/nE1p3vXY/gT+dfP349mVoc7XFJ3DhM7T9EHY4cW un/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=tUXlJyf/EwF52UBQUMrINYmFP1uDjIe8LBm7MrH/x50=; b=qMsTJKiptUC+pupp8Z9IumIxIao0f/DtOpQ2eQ2y0WN10ohWqhk7p58lKysVlh39HX Ow5jGiz+sQyGsj7JTax4RLhurDJE8OyjThCQQcagIwQ5BUv+rpR6ncY2b7b5xAarA34Y OKLbe0lQJy8XdZYZQCGcA+J2TEI9OHclP5x2rIFUAfdYTBVWTskI2xyvAbfKwo5YBvhE SnuSCjlJ0WxX5qUz5yKYz8nVsazWj689YIENIrWM0/1dlCWXqCOyPg9WgkMhhPdCKUZ1 GaJaTToCoJtaqd5uRk4z6RSJQKVYLkSx/tuP7uDF1E57eLBJoR+zXQFkvdo/pymWWsk7 2y3Q== X-Gm-Message-State: APjAAAXV9pvUM3WJiNlH2GGb+DoM1tLxeLa5Xfp2yURGlfj4eF0Og3s1 5wLV6fywF/h1tgFuLYRB+WVp3g== X-Google-Smtp-Source: APXvYqxexJrH8EZOViFVhYDgj4YbzWFLCGz4GvVoQtRfylB+aLylAjaNDXZyGLJlTyeyaGzLKfhkRQ== X-Received: by 2002:a5d:5222:: with SMTP id i2mr14222242wra.271.1571657999840; Mon, 21 Oct 2019 04:39:59 -0700 (PDT) Received: from dell ([95.149.164.99]) by smtp.gmail.com with ESMTPSA id p20sm9851205wmc.23.2019.10.21.04.39.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Oct 2019 04:39:59 -0700 (PDT) Date: Mon, 21 Oct 2019 12:39:57 +0100 From: Lee Jones To: Arnd Bergmann Cc: Daniel Thompson , Mark Brown , Linus Walleij , Barry Song , stephan@gerhold.net, "linux-kernel@vger.kernel.org" , Linux ARM , Daniel Drake , Lubomir Rintel , James Cameron Subject: Re: [PATCH v2 0/9] Simplify MFD Core Message-ID: <20191021113957.GC4365@dell> References: <20191021105822.20271-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Oct 2019, Arnd Bergmann wrote: > On Mon, Oct 21, 2019 at 12:58 PM Lee Jones wrote: > > > > MFD currently has one over-complicated user. CS5535 uses a mixture of > > cell cloning, reference counting and subsystem-level call-backs to > > achieve its goal of requesting an IO memory region only once across 3 > > consumers. The same can be achieved by handling the region centrally > > during the parent device's .probe() sequence. Releasing can be handed > > in a similar way during .remove(). > > > > While we're here, take the opportunity to provide some clean-ups and > > error checking to issues noticed along the way. > > > > This also paves the way for clean cell disabling via Device Tree being > > discussed at [0] > > > > [0] https://lkml.org/lkml/2019/10/18/612. > > As the CS5535 is primarily used on the OLPC XO1, it would be > good to have someone test the series on such a machine. > > I've added a few people to Cc that may be able to help test it, or > know someone who can. Wonderful. Thank you. > For the actual patches, see > https://lore.kernel.org/lkml/20191021105822.20271-1-lee.jones@linaro.org/T/#t > > Arnd -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6683ECA9EAF for ; Mon, 21 Oct 2019 11:40:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3955E20B7C for ; Mon, 21 Oct 2019 11:40:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="P2Dcakz5"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xIoHYOEM" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3955E20B7C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=t2sxnunLHWkwBj4UkLZEGADD7KgqyuZn5wADv0NJ/JI=; b=P2Dcakz5KXOAzF F6BWyWy9dpfjGsvP84RYR9AdPmpyPcl+l61prLB4jgnf76RV3StK9NrJHeikg48Azlj1MuYMMTx4o 7IXI3WpNQJwbxU0uzvZhDFSWZNj/3zEYeoVzO2ErqqpI8xX7dUgB51Gcqbu7SPGAUxHkKbHNg8cvX GrhBhSH+5qboK++nujm3F9WWJtGD22KpThaEO7SIRqgN36aNdBChKyrIHwfx0r0GZ1jvqzpRs8Xm2 jkWS2M38r5mwR6E932AlXX70RkRo3v7Z/8ks9H9pYCTQI6Yvt6EYVDODNF+54zyJJdkbAnMdnl9J0 HoESte6VBQsRnsURlLrQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMW2f-0005Xp-Le; Mon, 21 Oct 2019 11:40:05 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMW2b-0005CY-5x for linux-arm-kernel@lists.infradead.org; Mon, 21 Oct 2019 11:40:02 +0000 Received: by mail-wr1-x442.google.com with SMTP id s1so4811291wro.0 for ; Mon, 21 Oct 2019 04:40:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=tUXlJyf/EwF52UBQUMrINYmFP1uDjIe8LBm7MrH/x50=; b=xIoHYOEMyhGDXoCpQ9jHFyb0ii1+Dwvu1Q9SEfKtsUww4GbJQQy6Z+jQ8cl+fpelw3 ThXt8MFnHE4WeoE8+UnlJTQA1ZYeRuSyGiCfFTKaC0OBBqbot6eli99dXr5TzBuwDLdg hv/656/7etodYAz4ZGpUNsv4u+8lHsnz3JDcP+0QvO0l0qDRgeRmohlWKezDuIXl11Ai bYLHo0gILQbudud59jMRUdxxPNbWw0pXm0FHqeuVlxs2z/vrj8cchV+e99cxB6Xbntp6 Qh4S59PcwuPmISifpJ/a8LUwevqg/nE1p3vXY/gT+dfP349mVoc7XFJ3DhM7T9EHY4cW un/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=tUXlJyf/EwF52UBQUMrINYmFP1uDjIe8LBm7MrH/x50=; b=fmIQFaFUlL5GYFOPvPhKJBxfSEDt0ESKXs1L47DDLvaLdTU47fJ5ffy36o+km8gTPH XK9g2vBTznxqsKXXSyzymIIanPhKvDm0AJ7qMBgik7ZFQmBoxafl6a7RD5KnD7A2koSD 5vSwxesahMkbhnstBlIVuIF4bKJQPC+r6HOkDxpCIvqkq7O0cX6lOVbZvUsz1VHPQN2S txFTPLWTiswwzdPuHqFbHE2NMA8b4BLaj1yzUHDA8LXXwNwOFSyUo3KQlql+xkH7eW7b f2/iUugPO/ADbGppGuz9Ja0NTkFNpmphb59zRec8hhZdUJ6wnTbeZwN7Gtdj0ujdicGS Ctwg== X-Gm-Message-State: APjAAAWHjq0DFgtKj7u6BSyb2WFE8HZY4DNradKsdtmyW9tI2MGJ3Uqr 0NeAxU2F+mlOZxaqWbtlaIsQog== X-Google-Smtp-Source: APXvYqxexJrH8EZOViFVhYDgj4YbzWFLCGz4GvVoQtRfylB+aLylAjaNDXZyGLJlTyeyaGzLKfhkRQ== X-Received: by 2002:a5d:5222:: with SMTP id i2mr14222242wra.271.1571657999840; Mon, 21 Oct 2019 04:39:59 -0700 (PDT) Received: from dell ([95.149.164.99]) by smtp.gmail.com with ESMTPSA id p20sm9851205wmc.23.2019.10.21.04.39.59 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 21 Oct 2019 04:39:59 -0700 (PDT) Date: Mon, 21 Oct 2019 12:39:57 +0100 From: Lee Jones To: Arnd Bergmann Subject: Re: [PATCH v2 0/9] Simplify MFD Core Message-ID: <20191021113957.GC4365@dell> References: <20191021105822.20271-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191021_044001_234637_02CAE814 X-CRM114-Status: GOOD ( 16.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Barry Song , James Cameron , stephan@gerhold.net, Linus Walleij , Daniel Thompson , "linux-kernel@vger.kernel.org" , Lubomir Rintel , Mark Brown , Daniel Drake , Linux ARM Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCAyMSBPY3QgMjAxOSwgQXJuZCBCZXJnbWFubiB3cm90ZToKCj4gT24gTW9uLCBPY3Qg MjEsIDIwMTkgYXQgMTI6NTggUE0gTGVlIEpvbmVzIDxsZWUuam9uZXNAbGluYXJvLm9yZz4gd3Jv dGU6Cj4gPgo+ID4gTUZEIGN1cnJlbnRseSBoYXMgb25lIG92ZXItY29tcGxpY2F0ZWQgdXNlci4g IENTNTUzNSB1c2VzIGEgbWl4dHVyZSBvZgo+ID4gY2VsbCBjbG9uaW5nLCByZWZlcmVuY2UgY291 bnRpbmcgYW5kIHN1YnN5c3RlbS1sZXZlbCBjYWxsLWJhY2tzIHRvCj4gPiBhY2hpZXZlIGl0cyBn b2FsIG9mIHJlcXVlc3RpbmcgYW4gSU8gbWVtb3J5IHJlZ2lvbiBvbmx5IG9uY2UgYWNyb3NzIDMK PiA+IGNvbnN1bWVycy4gIFRoZSBzYW1lIGNhbiBiZSBhY2hpZXZlZCBieSBoYW5kbGluZyB0aGUg cmVnaW9uIGNlbnRyYWxseQo+ID4gZHVyaW5nIHRoZSBwYXJlbnQgZGV2aWNlJ3MgLnByb2JlKCkg c2VxdWVuY2UuICBSZWxlYXNpbmcgY2FuIGJlIGhhbmRlZAo+ID4gaW4gYSBzaW1pbGFyIHdheSBk dXJpbmcgLnJlbW92ZSgpLgo+ID4KPiA+IFdoaWxlIHdlJ3JlIGhlcmUsIHRha2UgdGhlIG9wcG9y dHVuaXR5IHRvIHByb3ZpZGUgc29tZSBjbGVhbi11cHMgYW5kCj4gPiBlcnJvciBjaGVja2luZyB0 byBpc3N1ZXMgbm90aWNlZCBhbG9uZyB0aGUgd2F5Lgo+ID4KPiA+IFRoaXMgYWxzbyBwYXZlcyB0 aGUgd2F5IGZvciBjbGVhbiBjZWxsIGRpc2FibGluZyB2aWEgRGV2aWNlIFRyZWUgYmVpbmcKPiA+ IGRpc2N1c3NlZCBhdCBbMF0KPiA+Cj4gPiBbMF0gaHR0cHM6Ly9sa21sLm9yZy9sa21sLzIwMTkv MTAvMTgvNjEyLgo+IAo+IEFzIHRoZSBDUzU1MzUgaXMgcHJpbWFyaWx5IHVzZWQgb24gdGhlIE9M UEMgWE8xLCBpdCB3b3VsZCBiZQo+IGdvb2QgdG8gaGF2ZSBzb21lb25lIHRlc3QgdGhlIHNlcmll cyBvbiBzdWNoIGEgbWFjaGluZS4KPiAKPiBJJ3ZlIGFkZGVkIGEgZmV3IHBlb3BsZSB0byBDYyB0 aGF0IG1heSBiZSBhYmxlIHRvIGhlbHAgdGVzdCBpdCwgb3IKPiBrbm93IHNvbWVvbmUgd2hvIGNh bi4KCldvbmRlcmZ1bC4gIFRoYW5rIHlvdS4KCj4gRm9yIHRoZSBhY3R1YWwgcGF0Y2hlcywgc2Vl Cj4gaHR0cHM6Ly9sb3JlLmtlcm5lbC5vcmcvbGttbC8yMDE5MTAyMTEwNTgyMi4yMDI3MS0xLWxl ZS5qb25lc0BsaW5hcm8ub3JnL1QvI3QKPiAKPiAgICAgQXJuZAoKLS0gCkxlZSBKb25lcyBb5p2O 55C85pavXQpMaW5hcm8gU2VydmljZXMgVGVjaG5pY2FsIExlYWQKTGluYXJvLm9yZyDilIIgT3Bl biBzb3VyY2Ugc29mdHdhcmUgZm9yIEFSTSBTb0NzCkZvbGxvdyBMaW5hcm86IEZhY2Vib29rIHwg VHdpdHRlciB8IEJsb2cKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlz dHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2xpbnV4LWFybS1rZXJuZWwK