Hi Hannes,

I love your patch! Yet something to improve:

[auto build test ERROR on mkp-scsi/for-next]
[cannot apply to v5.4-rc4 next-20191021]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Hannes-Reinecke/scsi-Revamp-result-values/20191022-004918
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
config: powerpc-defconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

   drivers/scsi/ibmvscsi/ibmvscsi.c: In function 'handle_cmd_rsp':
>> drivers/scsi/ibmvscsi/ibmvscsi.c:989:39: error: 'CHECK_CONDITION' undeclared (first use in this function); did you mean 'H_MR_CONDITION'?
      if (((cmnd->result >> 1) & 0x1f) == CHECK_CONDITION)
                                          ^~~~~~~~~~~~~~~
                                          H_MR_CONDITION
   drivers/scsi/ibmvscsi/ibmvscsi.c:989:39: note: each undeclared identifier is reported only once for each function it appears in

vim +989 drivers/scsi/ibmvscsi/ibmvscsi.c

^1da177e4c3f41 Linus Torvalds  2005-04-16   968  
^1da177e4c3f41 Linus Torvalds  2005-04-16   969  /**
^1da177e4c3f41 Linus Torvalds  2005-04-16   970   * handle_cmd_rsp: -  Handle responses from commands
^1da177e4c3f41 Linus Torvalds  2005-04-16   971   * @evt_struct:	srp_event_struct to be handled
^1da177e4c3f41 Linus Torvalds  2005-04-16   972   *
^1da177e4c3f41 Linus Torvalds  2005-04-16   973   * Used as a callback by when sending scsi cmds.
^1da177e4c3f41 Linus Torvalds  2005-04-16   974   * Gets called by ibmvscsi_handle_crq()
^1da177e4c3f41 Linus Torvalds  2005-04-16   975  */
^1da177e4c3f41 Linus Torvalds  2005-04-16   976  static void handle_cmd_rsp(struct srp_event_struct *evt_struct)
^1da177e4c3f41 Linus Torvalds  2005-04-16   977  {
^1da177e4c3f41 Linus Torvalds  2005-04-16   978  	struct srp_rsp *rsp = &evt_struct->xfer_iu->srp.rsp;
^1da177e4c3f41 Linus Torvalds  2005-04-16   979  	struct scsi_cmnd *cmnd = evt_struct->cmnd;
^1da177e4c3f41 Linus Torvalds  2005-04-16   980  
ef265673434680 FUJITA Tomonori 2006-03-26   981  	if (unlikely(rsp->opcode != SRP_RSP)) {
^1da177e4c3f41 Linus Torvalds  2005-04-16   982  		if (printk_ratelimit())
6c0a60ec52042e Brian King      2007-06-13   983  			dev_warn(evt_struct->hostdata->dev,
15c9274699e8b6 Tyrel Datwyler  2016-12-07   984  				 "bad SRP RSP type %#02x\n", rsp->opcode);
^1da177e4c3f41 Linus Torvalds  2005-04-16   985  	}
^1da177e4c3f41 Linus Torvalds  2005-04-16   986  	
^1da177e4c3f41 Linus Torvalds  2005-04-16   987  	if (cmnd) {
c3a3b55ae80a0d Brian King      2008-04-25   988  		cmnd->result |= rsp->status;
^1da177e4c3f41 Linus Torvalds  2005-04-16  @989  		if (((cmnd->result >> 1) & 0x1f) == CHECK_CONDITION)
^1da177e4c3f41 Linus Torvalds  2005-04-16   990  			memcpy(cmnd->sense_buffer,
ef265673434680 FUJITA Tomonori 2006-03-26   991  			       rsp->data,
72264eb6dbb909 Anton Blanchard 2013-09-03   992  			       be32_to_cpu(rsp->sense_data_len));
^1da177e4c3f41 Linus Torvalds  2005-04-16   993  		unmap_cmd_data(&evt_struct->iu.srp.cmd, 
4dddbc26c3895e James Bottomley 2005-09-06   994  			       evt_struct, 
^1da177e4c3f41 Linus Torvalds  2005-04-16   995  			       evt_struct->hostdata->dev);
^1da177e4c3f41 Linus Torvalds  2005-04-16   996  
ef265673434680 FUJITA Tomonori 2006-03-26   997  		if (rsp->flags & SRP_RSP_FLAG_DOOVER)
72264eb6dbb909 Anton Blanchard 2013-09-03   998  			scsi_set_resid(cmnd,
72264eb6dbb909 Anton Blanchard 2013-09-03   999  				       be32_to_cpu(rsp->data_out_res_cnt));
ef265673434680 FUJITA Tomonori 2006-03-26  1000  		else if (rsp->flags & SRP_RSP_FLAG_DIOVER)
72264eb6dbb909 Anton Blanchard 2013-09-03  1001  			scsi_set_resid(cmnd, be32_to_cpu(rsp->data_in_res_cnt));
^1da177e4c3f41 Linus Torvalds  2005-04-16  1002  	}
^1da177e4c3f41 Linus Torvalds  2005-04-16  1003  
^1da177e4c3f41 Linus Torvalds  2005-04-16  1004  	if (evt_struct->cmnd_done)
^1da177e4c3f41 Linus Torvalds  2005-04-16  1005  		evt_struct->cmnd_done(cmnd);
^1da177e4c3f41 Linus Torvalds  2005-04-16  1006  }
^1da177e4c3f41 Linus Torvalds  2005-04-16  1007  

:::::: The code at line 989 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@ppc970.osdl.org>
:::::: CC: Linus Torvalds <torvalds@ppc970.osdl.org>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation