From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 589B2CA9EB7 for ; Tue, 22 Oct 2019 16:27:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 308AF2084B for ; Tue, 22 Oct 2019 16:27:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Akp0RE/L" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732435AbfJVQ1o (ORCPT ); Tue, 22 Oct 2019 12:27:44 -0400 Received: from mail-pf1-f195.google.com ([209.85.210.195]:45789 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731132AbfJVQ1n (ORCPT ); Tue, 22 Oct 2019 12:27:43 -0400 Received: by mail-pf1-f195.google.com with SMTP id b4so2040835pfr.12 for ; Tue, 22 Oct 2019 09:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yCqef9gQT6nmyTqqGL+wlHZ1CGtJs3cHNc9rYV1fhGQ=; b=Akp0RE/L/DluE7lJNU+chwNolLm4k9jsXnFTp9tcKG5xdcIVWiC2r0h9i0cwWyG7m7 1M0XchljXyxrcF5F3z8kYQRl4stUEGdCXI7OA+TvymmMfiDz9QjnwWIItRChIyof8pgy LqJ1hg3+WyGv6FMYaKq9RKP9Q3ZF+joMQTEmY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yCqef9gQT6nmyTqqGL+wlHZ1CGtJs3cHNc9rYV1fhGQ=; b=YBkjz2rOt13LoUTuJq+nXithA73ElzIeETrJ9I6ceqhA6ygnNXGjbOAtaCRIqgZYIL JlKrYLcXgPQRqrdWHHHE57ihmPhfFMEaYe4qf4vWJiaKhnYIXkuCqDD36lAB5LMfUBHZ xE92JmV9m5JMPZa6TO+zwsbuYtSjI5EAmIVyd8xc/lrabgjDiRzoAKp6oprBlUZbaa1v iss9wUv+gmQpNXDxz250RmiyLraduPSqBbENNI+Lpl1miWopwcf6d6pWPKOJ20pB3L4R d+NhKmkMQHklgLSWoboyQEbshP5grfOhLNa1ljefqFVHPet/bNr3ukhR4UTwj/BdgvUL lWvA== X-Gm-Message-State: APjAAAUjyQ6oaduvykwtDzYFMjBXwTL279sSIHNnV0vI0bm+V4x/R0FL RWZ548loH6VKJjEh5F02VHoD6w== X-Google-Smtp-Source: APXvYqy0V08cVd3k9DTb6b5fAVT9pV7tar1OJtZIZQ+pxwtsG2Lik9okZfxhxg4bRHHBWocLCOzgYQ== X-Received: by 2002:a63:68c8:: with SMTP id d191mr4555216pgc.197.1571761662807; Tue, 22 Oct 2019 09:27:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r30sm20868424pfl.42.2019.10.22.09.27.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 09:27:42 -0700 (PDT) Date: Tue, 22 Oct 2019 09:27:40 -0700 From: Kees Cook To: Mark Rutland Cc: Nick Desaulniers , Sami Tolvanen , Will Deacon , Catalin Marinas , Steven Rostedt , Ard Biesheuvel , Dave Martin , Laura Abbott , clang-built-linux , Kernel Hardening , Linux ARM , LKML Subject: Re: [PATCH 12/18] arm64: reserve x18 only with Shadow Call Stack Message-ID: <201910220926.B78C4D88@keescook> References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-13-samitolvanen@google.com> <20191022160010.GB699@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191022160010.GB699@lakrids.cambridge.arm.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 22, 2019 at 05:00:10PM +0100, Mark Rutland wrote: > If we wanted to, we could periodically grep for x18 to find any illicit > usage. Now we need objtool for arm64! :) (It seems CONFIG_HAVE_STACK_VALIDATION is rather a narrow description for what objtool does now...) -- Kees Cook From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3D4D2CA9EA0 for ; Tue, 22 Oct 2019 16:27:55 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 06ED42084B for ; Tue, 22 Oct 2019 16:27:55 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZjhfSs0R"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="Akp0RE/L" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 06ED42084B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nsxiXF/Xt+eOdNc2uh4cg8R0zrMsK0ktHMs79OabI1U=; b=ZjhfSs0Rzgbtgo qB1q3TnbApiOBJpOH4p/kldjJhTC7M3cEOhHHVVgrShtzTHkMxUicGuWXb1T+6P6oVyX3jfSjhSpD qCVKen+iRAhSVGSAL1zZtctTLugX6SrESKBGG98PsaWNPPH5yxNwpgjPlAAHcJ4DmgUEaHSbDlPti bVj1/57IPbwvABHA4d6UlEZk0dyKnJasbQJW1YptH3r9fajP8UPXzI2t28V2hgRU1iG2Vzj1KLPBh e2CuIxEftPwgJU60VzTZ9Frf4eKxIg3GSB9BB3U/6Qnh3j+/dzLULbWDMZv6u6+TjxDVDWbgga+z5 kup6bhOMZmy3O83p4kNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMx0d-0000q8-4n; Tue, 22 Oct 2019 16:27:47 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMx0a-0000pZ-BB for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2019 16:27:45 +0000 Received: by mail-pf1-x443.google.com with SMTP id v4so10967967pff.6 for ; Tue, 22 Oct 2019 09:27:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=yCqef9gQT6nmyTqqGL+wlHZ1CGtJs3cHNc9rYV1fhGQ=; b=Akp0RE/L/DluE7lJNU+chwNolLm4k9jsXnFTp9tcKG5xdcIVWiC2r0h9i0cwWyG7m7 1M0XchljXyxrcF5F3z8kYQRl4stUEGdCXI7OA+TvymmMfiDz9QjnwWIItRChIyof8pgy LqJ1hg3+WyGv6FMYaKq9RKP9Q3ZF+joMQTEmY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=yCqef9gQT6nmyTqqGL+wlHZ1CGtJs3cHNc9rYV1fhGQ=; b=TzuoUbXy5GLOlqRu32/65cAn49+l5SozRy25Z+K335M574LwXqCPJbVcVDESTZ6YFj RBeMLqstMLHaZxk00u7+ZFIMHIdeslhKut9tkCFTIdHRRRtmxiYYnyGZa1GtQJXkyiT5 BhgzOr42XlDAClOBQ8GuTfQ46T2nmc2bOgQa5Q6tpFJUgDbs5QGH0Dt/PxRcxuEE6/fR yWN1KhrqLZvhaGaRFt1ojmwDeAoHgD5IEZJl8FCGGG5yfrqA64ax+eCTyP3a5RmjkqUs nYHGr0KG8aytnClqtkQ82s1xiMgG2kl66DH30o3fPs+Y0+/kdduj0HB9lf1ALb1vlAFf 7JbA== X-Gm-Message-State: APjAAAXTD6LNGF0DZ+RM3fagVtulLuUtbRMYPKH/xvgQJrPneqg/aExV 8BaNWBzCkRoD41vv49TkSCU3RA== X-Google-Smtp-Source: APXvYqy0V08cVd3k9DTb6b5fAVT9pV7tar1OJtZIZQ+pxwtsG2Lik9okZfxhxg4bRHHBWocLCOzgYQ== X-Received: by 2002:a63:68c8:: with SMTP id d191mr4555216pgc.197.1571761662807; Tue, 22 Oct 2019 09:27:42 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id r30sm20868424pfl.42.2019.10.22.09.27.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Oct 2019 09:27:42 -0700 (PDT) Date: Tue, 22 Oct 2019 09:27:40 -0700 From: Kees Cook To: Mark Rutland Subject: Re: [PATCH 12/18] arm64: reserve x18 only with Shadow Call Stack Message-ID: <201910220926.B78C4D88@keescook> References: <20191018161033.261971-1-samitolvanen@google.com> <20191018161033.261971-13-samitolvanen@google.com> <20191022160010.GB699@lakrids.cambridge.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191022160010.GB699@lakrids.cambridge.arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191022_092744_411110_F55B6917 X-CRM114-Status: UNSURE ( 7.21 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ard Biesheuvel , Catalin Marinas , Kernel Hardening , Nick Desaulniers , LKML , Steven Rostedt , clang-built-linux , Sami Tolvanen , Laura Abbott , Will Deacon , Dave Martin , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 22, 2019 at 05:00:10PM +0100, Mark Rutland wrote: > If we wanted to, we could periodically grep for x18 to find any illicit > usage. Now we need objtool for arm64! :) (It seems CONFIG_HAVE_STACK_VALIDATION is rather a narrow description for what objtool does now...) -- Kees Cook _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel