From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02708CA9EA0 for ; Tue, 22 Oct 2019 11:00:18 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 9D57D2184C for ; Tue, 22 Oct 2019 11:00:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 9D57D2184C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D602A1BEA4; Tue, 22 Oct 2019 13:00:16 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 556221BE98 for ; Tue, 22 Oct 2019 13:00:15 +0200 (CEST) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2019 04:00:13 -0700 X-IronPort-AV: E=Sophos;i="5.67,326,1566889200"; d="scan'208";a="191424277" Received: from bricha3-mobl.ger.corp.intel.com ([10.237.221.95]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-SHA; 22 Oct 2019 04:00:11 -0700 Date: Tue, 22 Oct 2019 12:00:08 +0100 From: Bruce Richardson To: Ye Xiaolong Cc: Andy Pei , dev@dpdk.org, rosen.xu@intel.com, tianfei.zhang@intel.com, qi.z.zhang@intel.com Message-ID: <20191022110008.GA955@bricha3-MOBL.ger.corp.intel.com> References: <1571639001-106193-2-git-send-email-andy.pei@intel.com> <1571641024-114601-1-git-send-email-andy.pei@intel.com> <1571641024-114601-13-git-send-email-andy.pei@intel.com> <20191021072309.GA23340@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191021072309.GA23340@intel.com> User-Agent: Mutt/1.12.1 (2019-06-15) Subject: Re: [dpdk-dev] [PATCH v11 12/19] net/ipn3ke: remove configuration for i40e port bonding X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 21, 2019 at 03:23:09PM +0800, Ye Xiaolong wrote: > +Bruce for the meson change. > > Thanks, > Xiaolong > > On 10/21, Andy Pei wrote: > >From: Rosen Xu > > > >The ipn3ke board FPGA and i40e BDF scan has added in ifpga_rawdev, > >so it doesn't need to provide configuration for i40e port bonding. > > > >Signed-off-by: Rosen Xu > >Signed-off-by: Andy Pei > >--- > > drivers/meson.build | 7 +- > > drivers/net/ipn3ke/Makefile | 2 + > > drivers/net/ipn3ke/ipn3ke_ethdev.c | 289 +++---------------------- > > drivers/net/ipn3ke/ipn3ke_representor.c | 8 +- > > drivers/net/ipn3ke/meson.build | 2 +- > > drivers/raw/ifpga/meson.build | 6 + > > drivers/raw/ifpga/rte_rawdev_ifpga_version.map | 6 + > > 7 files changed, 62 insertions(+), 258 deletions(-) > > > >diff --git a/drivers/meson.build b/drivers/meson.build > >index 2ed2e95..afdbb3b 100644 > >--- a/drivers/meson.build > >+++ b/drivers/meson.build > >@@ -9,12 +9,12 @@ endif > > dpdk_driver_classes = ['common', > > 'bus', > > 'mempool', # depends on common and bus. > >+ 'raw', > > 'net', # depends on common, bus and mempool. > > 'crypto', # depends on common, bus and mempool (net in future). > > 'compress', # depends on common, bus, mempool. > > 'event', # depends on common, bus, mempool and net. > >- 'baseband', # depends on common and bus. > >- 'raw'] # depends on common, bus, mempool, net and event. > >+ 'baseband'] > > This needs an explanation in the commit log, and possibly should be a separate patch. The comment on "net" need to be updated explaining why it comes after raw. > > default_cflags = machine_args > > if cc.has_argument('-Wno-format-truncation') > >@@ -157,6 +157,9 @@ foreach class:dpdk_driver_classes > > > > set_variable('shared_@0@'.format(lib_name), shared_dep) > > set_variable('static_@0@'.format(lib_name), static_dep) > >+ dependency_name = ''.join(lib_name.split('rte_')) > >+ message('drivers/@0@: Defining dependency "@1@"'.format( > >+ drv_path, dependency_name)) > > endif # build > > endforeach > > This doesn't belong in this patch. It's covered by: http://patches.dpdk.org/patch/59470/, so feel free to ack that patch instead. > >diff --git a/drivers/net/ipn3ke/Makefile b/drivers/net/ipn3ke/Makefile > >index 8c3ae37..2c65e49 100644 > >diff --git a/drivers/net/ipn3ke/meson.build b/drivers/net/ipn3ke/meson.build > >index 74b4d7c..4ea57b9 100644 > >--- a/drivers/net/ipn3ke/meson.build > >+++ b/drivers/net/ipn3ke/meson.build > >@@ -14,4 +14,4 @@ sources += files('ipn3ke_ethdev.c', > > 'ipn3ke_representor.c', > > 'ipn3ke_tm.c', > > 'ipn3ke_flow.c') > >-deps += ['bus_ifpga', 'sched'] > >+deps += ['bus_ifpga', 'sched', 'pmd_i40e', 'rawdev', 'rawdev_ifpga'] Minor nit: rawdev_ifpga already depends on rawdev and buf_ifpga, so you can drop them to shorten the list if you like. deps += ['sched', 'pmd_i40e', 'rawdev_ifpga'] > >diff --git a/drivers/raw/ifpga/meson.build b/drivers/raw/ifpga/meson.build > >index 0ab6fd7..dbd74b9 100644 > >--- a/drivers/raw/ifpga/meson.build > >+++ b/drivers/raw/ifpga/meson.build > >@@ -8,13 +8,19 @@ objs = [base_objs] > > > > dep = dependency('libfdt', required: false) > > if not dep.found() > >+ dep = cc.find_library('libfdt', required: false) > >+endif > >+if not dep.found() > > build = false > > reason = 'missing dependency, "libfdt"' > > endif > > deps += ['rawdev', 'pci', 'bus_pci', 'kvargs', > > 'bus_vdev', 'bus_ifpga', 'net'] Similarly, if you want to cut this list down: 'kvargs' is always depended upon by everything since its a dependency of eal, every rawdev already depends upon the rawdev library and bus_pci depends upon pci. deps += ['bus_pci', 'bus_vdev', 'bus_ifpga', 'net'] should work on it's own. Cutting the dependency list can help speed up configuration a little as fewer dependency chains need to be iterated.