Re: [PATCH v4 2/2] dt-bindings: iio: Add ltc2983 documentation

From: Jonathan Cameron <jic23@kernel.org>
To: Rob Herring <robh@kernel.org>
Cc: "Nuno Sá" <nuno.sa@analog.com>,
	"open list:IIO SUBSYSTEM AND DRIVERS" <linux-iio@vger.kernel.org>,
	devicetree@vger.kernel.org, "Hartmut Knaack" <knaack.h@gmx.de>,
	"Lars-Peter Clausen" <lars@metafoo.de>,
	"Peter Meerwald" <pmeerw@pmeerw.net>,
	"Mark Rutland" <mark.rutland@arm.com>
Subject: Re: [PATCH v4 2/2] dt-bindings: iio: Add ltc2983 documentation
Date: Tue, 22 Oct 2019 11:23:46 +0100	[thread overview]
Message-ID: <20191022112346.5b9180f0@archlinux> (raw)
In-Reply-To: <CAL_Jsq+5SYOPDOJJJ8+OuGpQ=PKB2JmbQ=yGN1fyuZnuQnAJ2Q@mail.gmail.com>

On Mon, 21 Oct 2019 12:21:41 -0500
Rob Herring <robh@kernel.org> wrote:

> On Mon, Oct 21, 2019 at 10:27 AM Jonathan Cameron <jic23@kernel.org> wrote:
> >
> > On Tue, 15 Oct 2019 21:44:35 +0100
> > Jonathan Cameron <jic23@kernel.org> wrote:
> >  
> > > On Tue, 15 Oct 2019 09:19:10 -0500
> > > Rob Herring <robh@kernel.org> wrote:
> > >  
> > > > On Mon, Oct 14, 2019 at 9:39 AM Rob Herring <robh@kernel.org> wrote:  
> > > > >
> > > > > On Sat, Oct 12, 2019 at 11:57:45AM +0100, Jonathan Cameron wrote:  
> > > > > > On Fri, 11 Oct 2019 10:40:38 +0200
> > > > > > Nuno Sá <nuno.sa@analog.com> wrote:
> > > > > >  
> > > > > > > Document the LTC2983 temperature sensor devicetree bindings.
> > > > > > >
> > > > > > > Signed-off-by: Nuno Sá <nuno.sa@analog.com>  
> > > > > >
> > > > > > I'm happy with this, but will be waiting for Rob to have a chance
> > > > > > for a final look before applying.  
> > > > >
> > > > > LGTM, but I need to add the int64-matrix type to the core schema first
> > > > > or this will give you errors. I should get to that in the next day or
> > > > > so.  
> > > >
> > > > Now added, so please update dtschema and check.
> > > >
> > > > Reviewed-by: Rob Herring <robh@kernel.org>  
> > >
> > > /home/jic23/src/kernel/iio/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.example.dt.yaml: ltc2983@0: thermocouple@20:adi,custom-thermocouple:0:0: 18446744073659331616 is greater than the maximum of 9223372036854775807
> > > /home/jic23/src/kernel/iio/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.example.dt.yaml: ltc2983@0: thermocouple@20:adi,custom-thermocouple:0:2: 18446744073679351616 is greater than the maximum of 9223372036854775807
> > > /home/jic23/src/kernel/iio/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.example.dt.yaml: ltc2983@0: thermocouple@20:adi,custom-thermocouple:0:4: 18446744073704251616 is greater than the maximum of 9223372036854775807
> > >
> > > Which is odd.  I haven't looked into it beyond testing and reverting the
> > > patch as out of time for today.  
> >
> > I'm still getting this and not sure why.  Rob?  
> 
> Just realized I failed to send my draft...
> 
> This is dtc yaml output not maintaining the sign, so everything is
> unsigned. (I had mentioned this and then promptly forgot.) I'll need
> to figure out how to plumb this thru dtc. For now, its probably
> easiest to just change to uint64-matrix with a comment that it should
> be signed.
> 
> Rob
Thanks.  Made the change and added the note to the docs.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan