From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1C55ECA9EA0 for ; Tue, 22 Oct 2019 20:40:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7C762184C for ; Tue, 22 Oct 2019 20:40:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732157AbfJVUk0 (ORCPT ); Tue, 22 Oct 2019 16:40:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:33800 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727582AbfJVUk0 (ORCPT ); Tue, 22 Oct 2019 16:40:26 -0400 Received: from gandalf.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A9CCC21848; Tue, 22 Oct 2019 20:40:24 +0000 (UTC) Date: Tue, 22 Oct 2019 16:40:23 -0400 From: Steven Rostedt To: Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, mhiramat@kernel.org, bristot@redhat.com, jbaron@akamai.com, torvalds@linux-foundation.org, tglx@linutronix.de, mingo@kernel.org, namit@vmware.com, hpa@zytor.com, luto@kernel.org, ard.biesheuvel@linaro.org, jpoimboe@redhat.com, jeyu@kernel.org Subject: Re: [PATCH v4 15/16] module: Move where we mark modules RO,X Message-ID: <20191022164023.2102fb1a@gandalf.local.home> In-Reply-To: <20191022202401.GO1817@hirez.programming.kicks-ass.net> References: <20191018073525.768931536@infradead.org> <20191018074634.801435443@infradead.org> <20191021222110.49044eb5@oasis.local.home> <20191022202401.GO1817@hirez.programming.kicks-ass.net> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 22 Oct 2019 22:24:01 +0200 Peter Zijlstra wrote: > The below seems to cure it; and seems to generate identical > events/*/format output (for my .config, with the exception of ID). > > It has just one section mismatch report that I'm too tired to look at > just now. Thanks, I'll try to take a look at it tomorrow. > > I'm not particularly proud of the "__function__" hack, but it works :/ I If anything, that should be defined as a macro: #define TRACE_EVENT_FIELD_SPECIAL "__trace_event_special__" And use that to test? > couldn't come up with anything else for [uk]probes which seem to have > dynamic fields and if we're having it then syscall_enter can also make > use of it, the syscall_metadata crud was going to be ugly otherwise. > > (also, win on LOC) I'm more worried about text/data bloat. But if anything, we may be able to deal with that later. -- Steve