From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DDE6CA9EA0 for ; Tue, 22 Oct 2019 18:41:42 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4A93621920 for ; Tue, 22 Oct 2019 18:41:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732710AbfJVSll (ORCPT ); Tue, 22 Oct 2019 14:41:41 -0400 Received: from mga14.intel.com ([192.55.52.115]:11748 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727851AbfJVSlk (ORCPT ); Tue, 22 Oct 2019 14:41:40 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2019 11:41:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,217,1569308400"; d="scan'208";a="222915653" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga004.fm.intel.com with ESMTP; 22 Oct 2019 11:41:39 -0700 Date: Tue, 22 Oct 2019 11:41:39 -0700 From: Sean Christopherson To: Christoffer Dall Cc: Marc Zyngier , James Hogan , Paul Mackerras , Christian Borntraeger , Janosch Frank , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , kvm-ppc@vger.kernel.org, Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , Joerg Roedel , Cornelia Huck , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, Jim Mattson Subject: Re: [PATCH 42/45] KVM: arm64: Free sve_state via arm specific hook Message-ID: <20191022184139.GK2343@linux.intel.com> References: <20191022015925.31916-1-sean.j.christopherson@intel.com> <20191022015925.31916-43-sean.j.christopherson@intel.com> <20191022114342.GB2652@e113682-lin.lund.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191022114342.GB2652@e113682-lin.lund.arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 22, 2019 at 01:43:42PM +0200, Christoffer Dall wrote: > On Mon, Oct 21, 2019 at 06:59:22PM -0700, Sean Christopherson wrote: > > Add an arm specific hook to free the arm64-only sve_state. Doing so > > eliminates the last functional code from kvm_arch_vcpu_uninit() across > > all architectures and paves the way for removing kvm_arch_vcpu_init() > > and kvm_arch_vcpu_uninit() entirely. > > > > Signed-off-by: Sean Christopherson > > --- > > arch/arm/include/asm/kvm_host.h | 1 + > > arch/arm64/include/asm/kvm_host.h | 1 + > > arch/arm64/kvm/reset.c | 5 +++++ > > virt/kvm/arm/arm.c | 2 ++ > > 4 files changed, 9 insertions(+) > > > > diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h > > index 8a37c8e89777..cc414de5acd3 100644 > > --- a/arch/arm/include/asm/kvm_host.h > > +++ b/arch/arm/include/asm/kvm_host.h > > @@ -333,6 +333,7 @@ static inline void kvm_arch_sync_events(struct kvm *kvm) {} > > static inline void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu) {} > > static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, int cpu) {} > > static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {} > > +static inline int kvm_arm_vcpu_destroy(struct kvm_vcpu *vcpu) {} > > > > static inline void kvm_arm_init_debug(void) {} > > static inline void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) {} > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > > index f656169db8c3..92d7c384a4ed 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++ b/arch/arm64/include/asm/kvm_host.h > > @@ -52,6 +52,7 @@ int kvm_arm_init_sve(void); > > > > int __attribute_const__ kvm_target_cpu(void); > > int kvm_reset_vcpu(struct kvm_vcpu *vcpu); > > +int kvm_arm_vcpu_destroy(struct kvm_vcpu *vcpu); > > void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu); > > int kvm_arch_vm_ioctl_check_extension(struct kvm *kvm, long ext); > > void __extended_idmap_trampoline(phys_addr_t boot_pgd, phys_addr_t idmap_start); > > diff --git a/arch/arm64/kvm/reset.c b/arch/arm64/kvm/reset.c > > index f4a8ae918827..98abc4278f42 100644 > > --- a/arch/arm64/kvm/reset.c > > +++ b/arch/arm64/kvm/reset.c > > @@ -205,6 +205,11 @@ bool kvm_arm_vcpu_is_finalized(struct kvm_vcpu *vcpu) > > } > > > > void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu) > > +{ > > + > > +} > > + > > +int kvm_arm_vcpu_destroy(struct kvm_vcpu *vcpu) > > { > > kfree(vcpu->arch.sve_state); > > } > > nit: warning: control reaches end of non-void function Doh, fixed. Thanks for the quick review! From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1FE6CA9EA0 for ; Tue, 22 Oct 2019 18:41:46 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id 507552184C for ; Tue, 22 Oct 2019 18:41:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 507552184C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvmarm-bounces@lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 8D3514A990; Tue, 22 Oct 2019 14:41:45 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id I73bTcngWGsf; Tue, 22 Oct 2019 14:41:44 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 4F3534A993; Tue, 22 Oct 2019 14:41:44 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 72A4A4A98F for ; Tue, 22 Oct 2019 14:41:43 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VE-nNjzZI8SF for ; Tue, 22 Oct 2019 14:41:42 -0400 (EDT) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by mm01.cs.columbia.edu (Postfix) with ESMTPS id C39984A98E for ; Tue, 22 Oct 2019 14:41:41 -0400 (EDT) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2019 11:41:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,217,1569308400"; d="scan'208";a="222915653" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga004.fm.intel.com with ESMTP; 22 Oct 2019 11:41:39 -0700 Date: Tue, 22 Oct 2019 11:41:39 -0700 From: Sean Christopherson To: Christoffer Dall Subject: Re: [PATCH 42/45] KVM: arm64: Free sve_state via arm specific hook Message-ID: <20191022184139.GK2343@linux.intel.com> References: <20191022015925.31916-1-sean.j.christopherson@intel.com> <20191022015925.31916-43-sean.j.christopherson@intel.com> <20191022114342.GB2652@e113682-lin.lund.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191022114342.GB2652@e113682-lin.lund.arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) Cc: Cornelia Huck , Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, Marc Zyngier , Joerg Roedel , David Hildenbrand , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Christian Borntraeger , James Hogan , Paolo Bonzini , Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Jim Mattson X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Tue, Oct 22, 2019 at 01:43:42PM +0200, Christoffer Dall wrote: > On Mon, Oct 21, 2019 at 06:59:22PM -0700, Sean Christopherson wrote: > > Add an arm specific hook to free the arm64-only sve_state. Doing so > > eliminates the last functional code from kvm_arch_vcpu_uninit() across > > all architectures and paves the way for removing kvm_arch_vcpu_init() > > and kvm_arch_vcpu_uninit() entirely. > > > > Signed-off-by: Sean Christopherson > > --- > > arch/arm/include/asm/kvm_host.h | 1 + > > arch/arm64/include/asm/kvm_host.h | 1 + > > arch/arm64/kvm/reset.c | 5 +++++ > > virt/kvm/arm/arm.c | 2 ++ > > 4 files changed, 9 insertions(+) > > > > diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h > > index 8a37c8e89777..cc414de5acd3 100644 > > --- a/arch/arm/include/asm/kvm_host.h > > +++ b/arch/arm/include/asm/kvm_host.h > > @@ -333,6 +333,7 @@ static inline void kvm_arch_sync_events(struct kvm *kvm) {} > > static inline void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu) {} > > static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, int cpu) {} > > static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {} > > +static inline int kvm_arm_vcpu_destroy(struct kvm_vcpu *vcpu) {} > > > > static inline void kvm_arm_init_debug(void) {} > > static inline void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) {} > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > > index f656169db8c3..92d7c384a4ed 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++ b/arch/arm64/include/asm/kvm_host.h > > @@ -52,6 +52,7 @@ int kvm_arm_init_sve(void); > > > > int __attribute_const__ kvm_target_cpu(void); > > int kvm_reset_vcpu(struct kvm_vcpu *vcpu); > > +int kvm_arm_vcpu_destroy(struct kvm_vcpu *vcpu); > > void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu); > > int kvm_arch_vm_ioctl_check_extension(struct kvm *kvm, long ext); > > void __extended_idmap_trampoline(phys_addr_t boot_pgd, phys_addr_t idmap_start); > > diff --git a/arch/arm64/kvm/reset.c b/arch/arm64/kvm/reset.c > > index f4a8ae918827..98abc4278f42 100644 > > --- a/arch/arm64/kvm/reset.c > > +++ b/arch/arm64/kvm/reset.c > > @@ -205,6 +205,11 @@ bool kvm_arm_vcpu_is_finalized(struct kvm_vcpu *vcpu) > > } > > > > void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu) > > +{ > > + > > +} > > + > > +int kvm_arm_vcpu_destroy(struct kvm_vcpu *vcpu) > > { > > kfree(vcpu->arch.sve_state); > > } > > nit: warning: control reaches end of non-void function Doh, fixed. Thanks for the quick review! _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A356CA9EB9 for ; Tue, 22 Oct 2019 18:41:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2C3C42184C for ; Tue, 22 Oct 2019 18:41:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RKRZkdyn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2C3C42184C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zo9n9bL5zROcf8p7Z/tDDNqh4WLHlfucw8uUl6Kpcp8=; b=RKRZkdynJgCfa3 14OFA7Lsx/Y4y1HJ1Yiyuk+GEzWo+amMZcJjErJKM6icAxGvt8Jt8mpBlJhCBCfe+6IbHaVxT8tvA j+dUZM8MthD8J+wvTSboMz7laRrL0gY74eoyhap6oxlezGbzy0SBSghrNRlN+VH0oysbOW1/RuVCn +GzAlyEeOVpTBgQhrUU+32BmPmnIoCENpKx16ERPHifrXnQwuhAuXGTlQ9aD2TJzRxBZnmJMgFIX3 h2uyBX5tPR79dsJp8oxkzCSplpuDbR5WnQlSyyZDKLPy+jjQzHmsUJzXU8eyw0BRry/TTNwQ97VvF f6a5rljnvL7KOk4rR+ew==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMz6I-0000iV-EM; Tue, 22 Oct 2019 18:41:46 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iMz6G-0000gT-3Z for linux-arm-kernel@lists.infradead.org; Tue, 22 Oct 2019 18:41:45 +0000 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Oct 2019 11:41:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,217,1569308400"; d="scan'208";a="222915653" Received: from sjchrist-coffee.jf.intel.com (HELO linux.intel.com) ([10.54.74.41]) by fmsmga004.fm.intel.com with ESMTP; 22 Oct 2019 11:41:39 -0700 Date: Tue, 22 Oct 2019 11:41:39 -0700 From: Sean Christopherson To: Christoffer Dall Subject: Re: [PATCH 42/45] KVM: arm64: Free sve_state via arm specific hook Message-ID: <20191022184139.GK2343@linux.intel.com> References: <20191022015925.31916-1-sean.j.christopherson@intel.com> <20191022015925.31916-43-sean.j.christopherson@intel.com> <20191022114342.GB2652@e113682-lin.lund.arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191022114342.GB2652@e113682-lin.lund.arm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191022_114144_158218_940DDE7F X-CRM114-Status: GOOD ( 15.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Cornelia Huck , Wanpeng Li , Janosch Frank , kvm@vger.kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , Marc Zyngier , Joerg Roedel , David Hildenbrand , linux-mips@vger.kernel.org, kvm-ppc@vger.kernel.org, linux-kernel@vger.kernel.org, Paul Mackerras , Christian Borntraeger , James Hogan , Paolo Bonzini , Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Jim Mattson Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Oct 22, 2019 at 01:43:42PM +0200, Christoffer Dall wrote: > On Mon, Oct 21, 2019 at 06:59:22PM -0700, Sean Christopherson wrote: > > Add an arm specific hook to free the arm64-only sve_state. Doing so > > eliminates the last functional code from kvm_arch_vcpu_uninit() across > > all architectures and paves the way for removing kvm_arch_vcpu_init() > > and kvm_arch_vcpu_uninit() entirely. > > > > Signed-off-by: Sean Christopherson > > --- > > arch/arm/include/asm/kvm_host.h | 1 + > > arch/arm64/include/asm/kvm_host.h | 1 + > > arch/arm64/kvm/reset.c | 5 +++++ > > virt/kvm/arm/arm.c | 2 ++ > > 4 files changed, 9 insertions(+) > > > > diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h > > index 8a37c8e89777..cc414de5acd3 100644 > > --- a/arch/arm/include/asm/kvm_host.h > > +++ b/arch/arm/include/asm/kvm_host.h > > @@ -333,6 +333,7 @@ static inline void kvm_arch_sync_events(struct kvm *kvm) {} > > static inline void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu) {} > > static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, int cpu) {} > > static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {} > > +static inline int kvm_arm_vcpu_destroy(struct kvm_vcpu *vcpu) {} > > > > static inline void kvm_arm_init_debug(void) {} > > static inline void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) {} > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > > index f656169db8c3..92d7c384a4ed 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++ b/arch/arm64/include/asm/kvm_host.h > > @@ -52,6 +52,7 @@ int kvm_arm_init_sve(void); > > > > int __attribute_const__ kvm_target_cpu(void); > > int kvm_reset_vcpu(struct kvm_vcpu *vcpu); > > +int kvm_arm_vcpu_destroy(struct kvm_vcpu *vcpu); > > void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu); > > int kvm_arch_vm_ioctl_check_extension(struct kvm *kvm, long ext); > > void __extended_idmap_trampoline(phys_addr_t boot_pgd, phys_addr_t idmap_start); > > diff --git a/arch/arm64/kvm/reset.c b/arch/arm64/kvm/reset.c > > index f4a8ae918827..98abc4278f42 100644 > > --- a/arch/arm64/kvm/reset.c > > +++ b/arch/arm64/kvm/reset.c > > @@ -205,6 +205,11 @@ bool kvm_arm_vcpu_is_finalized(struct kvm_vcpu *vcpu) > > } > > > > void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu) > > +{ > > + > > +} > > + > > +int kvm_arm_vcpu_destroy(struct kvm_vcpu *vcpu) > > { > > kfree(vcpu->arch.sve_state); > > } > > nit: warning: control reaches end of non-void function Doh, fixed. Thanks for the quick review! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Tue, 22 Oct 2019 18:41:39 +0000 Subject: Re: [PATCH 42/45] KVM: arm64: Free sve_state via arm specific hook Message-Id: <20191022184139.GK2343@linux.intel.com> List-Id: References: <20191022015925.31916-1-sean.j.christopherson@intel.com> <20191022015925.31916-43-sean.j.christopherson@intel.com> <20191022114342.GB2652@e113682-lin.lund.arm.com> In-Reply-To: <20191022114342.GB2652@e113682-lin.lund.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Christoffer Dall Cc: Marc Zyngier , James Hogan , Paul Mackerras , Christian Borntraeger , Janosch Frank , Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , kvm-ppc@vger.kernel.org, Wanpeng Li , kvm@vger.kernel.org, David Hildenbrand , Joerg Roedel , Cornelia Huck , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Vitaly Kuznetsov , kvmarm@lists.cs.columbia.edu, Jim Mattson On Tue, Oct 22, 2019 at 01:43:42PM +0200, Christoffer Dall wrote: > On Mon, Oct 21, 2019 at 06:59:22PM -0700, Sean Christopherson wrote: > > Add an arm specific hook to free the arm64-only sve_state. Doing so > > eliminates the last functional code from kvm_arch_vcpu_uninit() across > > all architectures and paves the way for removing kvm_arch_vcpu_init() > > and kvm_arch_vcpu_uninit() entirely. > > > > Signed-off-by: Sean Christopherson > > --- > > arch/arm/include/asm/kvm_host.h | 1 + > > arch/arm64/include/asm/kvm_host.h | 1 + > > arch/arm64/kvm/reset.c | 5 +++++ > > virt/kvm/arm/arm.c | 2 ++ > > 4 files changed, 9 insertions(+) > > > > diff --git a/arch/arm/include/asm/kvm_host.h b/arch/arm/include/asm/kvm_host.h > > index 8a37c8e89777..cc414de5acd3 100644 > > --- a/arch/arm/include/asm/kvm_host.h > > +++ b/arch/arm/include/asm/kvm_host.h > > @@ -333,6 +333,7 @@ static inline void kvm_arch_sync_events(struct kvm *kvm) {} > > static inline void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu) {} > > static inline void kvm_arch_sched_in(struct kvm_vcpu *vcpu, int cpu) {} > > static inline void kvm_arch_vcpu_block_finish(struct kvm_vcpu *vcpu) {} > > +static inline int kvm_arm_vcpu_destroy(struct kvm_vcpu *vcpu) {} > > > > static inline void kvm_arm_init_debug(void) {} > > static inline void kvm_arm_setup_debug(struct kvm_vcpu *vcpu) {} > > diff --git a/arch/arm64/include/asm/kvm_host.h b/arch/arm64/include/asm/kvm_host.h > > index f656169db8c3..92d7c384a4ed 100644 > > --- a/arch/arm64/include/asm/kvm_host.h > > +++ b/arch/arm64/include/asm/kvm_host.h > > @@ -52,6 +52,7 @@ int kvm_arm_init_sve(void); > > > > int __attribute_const__ kvm_target_cpu(void); > > int kvm_reset_vcpu(struct kvm_vcpu *vcpu); > > +int kvm_arm_vcpu_destroy(struct kvm_vcpu *vcpu); > > void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu); > > int kvm_arch_vm_ioctl_check_extension(struct kvm *kvm, long ext); > > void __extended_idmap_trampoline(phys_addr_t boot_pgd, phys_addr_t idmap_start); > > diff --git a/arch/arm64/kvm/reset.c b/arch/arm64/kvm/reset.c > > index f4a8ae918827..98abc4278f42 100644 > > --- a/arch/arm64/kvm/reset.c > > +++ b/arch/arm64/kvm/reset.c > > @@ -205,6 +205,11 @@ bool kvm_arm_vcpu_is_finalized(struct kvm_vcpu *vcpu) > > } > > > > void kvm_arch_vcpu_uninit(struct kvm_vcpu *vcpu) > > +{ > > + > > +} > > + > > +int kvm_arm_vcpu_destroy(struct kvm_vcpu *vcpu) > > { > > kfree(vcpu->arch.sve_state); > > } > > nit: warning: control reaches end of non-void function Doh, fixed. Thanks for the quick review!