From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8D0A1CA9EB7 for ; Wed, 23 Oct 2019 10:22:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6418121928 for ; Wed, 23 Oct 2019 10:22:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="hNt1lFgV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404297AbfJWKWS (ORCPT ); Wed, 23 Oct 2019 06:22:18 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:36866 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403810AbfJWKWR (ORCPT ); Wed, 23 Oct 2019 06:22:17 -0400 Received: from pendragon.ideasonboard.com (143.121.2.93.rev.sfr.net [93.2.121.143]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 613D5814; Wed, 23 Oct 2019 12:22:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1571826133; bh=eGJOH1VGLoVHmq/1QUJrrmrQnHMBekaXv4x5beDzUns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hNt1lFgV/RYMyeFBPXTgQiKb3GwPw/Wa344JMMSZWnwFmLvL/ZwSc8yFopTSs7O3V 3BEcvANOutiE3Uqo9EUjLPvIH0XYH9JeysLU4k3odp1PfhlVV0P9EFVjba6AUVEZTx Bg5kiEXBNGIQl2WjyNDPL8rSeOPgyZ4CMk60KXUs= Date: Wed, 23 Oct 2019 13:22:07 +0300 From: Laurent Pinchart To: Mark Salyzyn Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, "David S. Miller" , Jonathan Corbet , Ard Biesheuvel , Harry Wentland , Leo Li , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , VMware Graphics , Thomas Hellstrom , Mauro Carvalho Chehab , Trond Myklebust , Anna Schumaker , Alexander Aring , Jukka Rissanen , Alexey Kuznetsov , Hideaki YOSHIFUJI , Jarkko Sakkinen , Ingo Molnar , Matthew Garrett , Hans de Goede , hersen wu , Roman Li , Maxim Martynov , David Ahern , Francesco Ruggeri , Linus =?utf-8?Q?L=C3=BCssing?= , Greg Kroah-Hartman , Feng Tang , "Steven Rostedt (VMware)" , Andrew Morton , Rafael Aquini , netdev@vger.kernel.org, linux-doc@vger.kernel.org, linux-efi@vger.kernel.org, amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-nfs@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org Subject: Re: [PATCH] Cleanup: replace prefered with preferred Message-ID: <20191023102207.GB4763@pendragon.ideasonboard.com> References: <20191022214208.211448-1-salyzyn@android.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191022214208.211448-1-salyzyn@android.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, Thank you for the patch. On Tue, Oct 22, 2019 at 02:41:45PM -0700, Mark Salyzyn wrote: > Replace all occurrences of prefered with preferred to make future > checkpatch.pl's happy. A few places the incorrect spelling is > matched with the correct spelling to preserve existing user space API. > > Signed-off-by: Mark Salyzyn > --- > Documentation/networking/ip-sysctl.txt | 2 +- > .../firmware/efi/libstub/efi-stub-helper.c | 2 +- > .../gpu/drm/amd/display/dc/inc/compressor.h | 4 +- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 +- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 2 +- > drivers/media/usb/uvc/uvc_video.c | 6 +- > fs/nfs/nfs4xdr.c | 2 +- > include/linux/ipv6.h | 2 +- > include/net/addrconf.h | 4 +- > include/net/if_inet6.h | 2 +- > include/net/ndisc.h | 8 +- > include/uapi/linux/if_addr.h | 5 +- > include/uapi/linux/ipv6.h | 4 +- > include/uapi/linux/sysctl.h | 4 +- > include/uapi/linux/usb/video.h | 5 +- > kernel/sysctl_binary.c | 3 +- > net/6lowpan/ndisc.c | 4 +- > net/ipv4/devinet.c | 20 ++-- > net/ipv6/addrconf.c | 113 ++++++++++-------- > 19 files changed, 112 insertions(+), 82 deletions(-) [snip] > diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c > index 8fa77a81dd7f..0096e6aacdb4 100644 > --- a/drivers/media/usb/uvc/uvc_video.c > +++ b/drivers/media/usb/uvc/uvc_video.c > @@ -276,13 +276,13 @@ static int uvc_get_video_ctrl(struct uvc_streaming *stream, > if (size >= 34) { > ctrl->dwClockFrequency = get_unaligned_le32(&data[26]); > ctrl->bmFramingInfo = data[30]; > - ctrl->bPreferedVersion = data[31]; > + ctrl->bPreferredVersion = data[31]; > ctrl->bMinVersion = data[32]; > ctrl->bMaxVersion = data[33]; > } else { > ctrl->dwClockFrequency = stream->dev->clock_frequency; > ctrl->bmFramingInfo = 0; > - ctrl->bPreferedVersion = 0; > + ctrl->bPreferredVersion = 0; > ctrl->bMinVersion = 0; > ctrl->bMaxVersion = 0; > } > @@ -325,7 +325,7 @@ static int uvc_set_video_ctrl(struct uvc_streaming *stream, > if (size >= 34) { > put_unaligned_le32(ctrl->dwClockFrequency, &data[26]); > data[30] = ctrl->bmFramingInfo; > - data[31] = ctrl->bPreferedVersion; > + data[31] = ctrl->bPreferredVersion; > data[32] = ctrl->bMinVersion; > data[33] = ctrl->bMaxVersion; > } [snip] > diff --git a/include/uapi/linux/usb/video.h b/include/uapi/linux/usb/video.h > index d854cb19c42c..59167f0ed5c1 100644 > --- a/include/uapi/linux/usb/video.h > +++ b/include/uapi/linux/usb/video.h > @@ -448,7 +448,10 @@ struct uvc_streaming_control { > __u32 dwMaxPayloadTransferSize; > __u32 dwClockFrequency; > __u8 bmFramingInfo; > - __u8 bPreferedVersion; > + union { > + __u8 bPreferredVersion; > + __u8 bPreferedVersion __attribute__((deprecated)); /* NOTYPO */ > + } __attribute__((__packed__)); Quite interestingly this typo is part of the USB device class definition for video devices (UVC) specification. I thus think we should keep using the field name bPreferedVersion through the code, otherwise it wouldn't match the spec. > __u8 bMinVersion; > __u8 bMaxVersion; > } __attribute__((__packed__)); [snip] -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] Cleanup: replace prefered with preferred Date: Wed, 23 Oct 2019 13:22:07 +0300 Message-ID: <20191023102207.GB4763@pendragon.ideasonboard.com> References: <20191022214208.211448-1-salyzyn@android.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Return-path: Content-Disposition: inline In-Reply-To: <20191022214208.211448-1-salyzyn@android.com> Sender: netdev-owner@vger.kernel.org To: Mark Salyzyn Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, "David S. Miller" , Jonathan Corbet , Ard Biesheuvel , Harry Wentland , Leo Li , Alex Deucher , Christian =?utf-8?B?S8O2bmln?= , "David (ChunMing) Zhou" , David Airlie , Daniel Vetter , VMware Graphics , Thomas Hellstrom , Mauro Carvalho Chehab , Trond Myklebust , Anna Schumaker , Alexander Aring , Jukka Rissanen List-Id: dri-devel@lists.freedesktop.org Hi Mark, Thank you for the patch. On Tue, Oct 22, 2019 at 02:41:45PM -0700, Mark Salyzyn wrote: > Replace all occurrences of prefered with preferred to make future > checkpatch.pl's happy. A few places the incorrect spelling is > matched with the correct spelling to preserve existing user space API. > > Signed-off-by: Mark Salyzyn > --- > Documentation/networking/ip-sysctl.txt | 2 +- > .../firmware/efi/libstub/efi-stub-helper.c | 2 +- > .../gpu/drm/amd/display/dc/inc/compressor.h | 4 +- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.c | 2 +- > drivers/gpu/drm/vmwgfx/vmwgfx_kms.h | 2 +- > drivers/media/usb/uvc/uvc_video.c | 6 +- > fs/nfs/nfs4xdr.c | 2 +- > include/linux/ipv6.h | 2 +- > include/net/addrconf.h | 4 +- > include/net/if_inet6.h | 2 +- > include/net/ndisc.h | 8 +- > include/uapi/linux/if_addr.h | 5 +- > include/uapi/linux/ipv6.h | 4 +- > include/uapi/linux/sysctl.h | 4 +- > include/uapi/linux/usb/video.h | 5 +- > kernel/sysctl_binary.c | 3 +- > net/6lowpan/ndisc.c | 4 +- > net/ipv4/devinet.c | 20 ++-- > net/ipv6/addrconf.c | 113 ++++++++++-------- > 19 files changed, 112 insertions(+), 82 deletions(-) [snip] > diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c > index 8fa77a81dd7f..0096e6aacdb4 100644 > --- a/drivers/media/usb/uvc/uvc_video.c > +++ b/drivers/media/usb/uvc/uvc_video.c > @@ -276,13 +276,13 @@ static int uvc_get_video_ctrl(struct uvc_streaming *stream, > if (size >= 34) { > ctrl->dwClockFrequency = get_unaligned_le32(&data[26]); > ctrl->bmFramingInfo = data[30]; > - ctrl->bPreferedVersion = data[31]; > + ctrl->bPreferredVersion = data[31]; > ctrl->bMinVersion = data[32]; > ctrl->bMaxVersion = data[33]; > } else { > ctrl->dwClockFrequency = stream->dev->clock_frequency; > ctrl->bmFramingInfo = 0; > - ctrl->bPreferedVersion = 0; > + ctrl->bPreferredVersion = 0; > ctrl->bMinVersion = 0; > ctrl->bMaxVersion = 0; > } > @@ -325,7 +325,7 @@ static int uvc_set_video_ctrl(struct uvc_streaming *stream, > if (size >= 34) { > put_unaligned_le32(ctrl->dwClockFrequency, &data[26]); > data[30] = ctrl->bmFramingInfo; > - data[31] = ctrl->bPreferedVersion; > + data[31] = ctrl->bPreferredVersion; > data[32] = ctrl->bMinVersion; > data[33] = ctrl->bMaxVersion; > } [snip] > diff --git a/include/uapi/linux/usb/video.h b/include/uapi/linux/usb/video.h > index d854cb19c42c..59167f0ed5c1 100644 > --- a/include/uapi/linux/usb/video.h > +++ b/include/uapi/linux/usb/video.h > @@ -448,7 +448,10 @@ struct uvc_streaming_control { > __u32 dwMaxPayloadTransferSize; > __u32 dwClockFrequency; > __u8 bmFramingInfo; > - __u8 bPreferedVersion; > + union { > + __u8 bPreferredVersion; > + __u8 bPreferedVersion __attribute__((deprecated)); /* NOTYPO */ > + } __attribute__((__packed__)); Quite interestingly this typo is part of the USB device class definition for video devices (UVC) specification. I thus think we should keep using the field name bPreferedVersion through the code, otherwise it wouldn't match the spec. > __u8 bMinVersion; > __u8 bMaxVersion; > } __attribute__((__packed__)); [snip] -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 635CFCA9EB6 for ; Wed, 23 Oct 2019 10:22:18 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3B9DB20650 for ; Wed, 23 Oct 2019 10:22:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3B9DB20650 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7C48D6EA2F; Wed, 23 Oct 2019 10:22:17 +0000 (UTC) Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 500576EA2F for ; Wed, 23 Oct 2019 10:22:16 +0000 (UTC) Received: from pendragon.ideasonboard.com (143.121.2.93.rev.sfr.net [93.2.121.143]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 613D5814; Wed, 23 Oct 2019 12:22:13 +0200 (CEST) Date: Wed, 23 Oct 2019 13:22:07 +0300 From: Laurent Pinchart To: Mark Salyzyn Subject: Re: [PATCH] Cleanup: replace prefered with preferred Message-ID: <20191023102207.GB4763@pendragon.ideasonboard.com> References: <20191022214208.211448-1-salyzyn@android.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191022214208.211448-1-salyzyn@android.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1571826133; bh=eGJOH1VGLoVHmq/1QUJrrmrQnHMBekaXv4x5beDzUns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hNt1lFgV/RYMyeFBPXTgQiKb3GwPw/Wa344JMMSZWnwFmLvL/ZwSc8yFopTSs7O3V 3BEcvANOutiE3Uqo9EUjLPvIH0XYH9JeysLU4k3odp1PfhlVV0P9EFVjba6AUVEZTx Bg5kiEXBNGIQl2WjyNDPL8rSeOPgyZ4CMk60KXUs= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Aring , linux-efi@vger.kernel.org, Linus =?utf-8?Q?L=C3=BCssing?= , Greg Kroah-Hartman , David Airlie , Feng Tang , Jarkko Sakkinen , Roman Li , "David S. Miller" , netdev@vger.kernel.org, Ingo Molnar , Rafael Aquini , Thomas Hellstrom , Jonathan Corbet , Francesco Ruggeri , Matthew Garrett , amd-gfx@lists.freedesktop.org, VMware Graphics , Alexey Kuznetsov , kernel-team@android.com, linux-media@vger.kernel.org, Leo Li , "Steven Rostedt \(VMware\)" , Hans de Goede , hersen wu , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Trond Myklebust , linux-nfs@vger.kernel.org, Andrew Morton , Ard Biesheuvel , Hideaki YOSHIFUJI , Maxim Martynov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Anna Schumaker , linux-bluetooth@vger.kernel.org, David Ahern , Alex Deucher , Jukka Rissanen , linux-wpan@vger.kernel.org, Christian =?utf-8?B?S8O2bmln?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191023102207.4vwhPruZ9RSf84mWRv2-D-igrxpD5gwNJk0s3M8fOZA@z> SGkgTWFyaywKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gVHVlLCBPY3QgMjIsIDIwMTkg YXQgMDI6NDE6NDVQTSAtMDcwMCwgTWFyayBTYWx5enluIHdyb3RlOgo+IFJlcGxhY2UgYWxsIG9j Y3VycmVuY2VzIG9mIHByZWZlcmVkIHdpdGggcHJlZmVycmVkIHRvIG1ha2UgZnV0dXJlCj4gY2hl Y2twYXRjaC5wbCdzIGhhcHB5LiAgQSBmZXcgcGxhY2VzIHRoZSBpbmNvcnJlY3Qgc3BlbGxpbmcg aXMKPiBtYXRjaGVkIHdpdGggdGhlIGNvcnJlY3Qgc3BlbGxpbmcgdG8gcHJlc2VydmUgZXhpc3Rp bmcgdXNlciBzcGFjZSBBUEkuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFyayBTYWx5enluIDxzYWx5 enluQGFuZHJvaWQuY29tPgo+IC0tLQo+ICBEb2N1bWVudGF0aW9uL25ldHdvcmtpbmcvaXAtc3lz Y3RsLnR4dCAgICAgICAgfCAgIDIgKy0KPiAgLi4uL2Zpcm13YXJlL2VmaS9saWJzdHViL2VmaS1z dHViLWhlbHBlci5jICAgIHwgICAyICstCj4gIC4uLi9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2lu Yy9jb21wcmVzc29yLmggICB8ICAgNCArLQo+ICBkcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dm eF9rbXMuYyAgICAgICAgICAgfCAgIDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdn Znhfa21zLmggICAgICAgICAgIHwgICAyICstCj4gIGRyaXZlcnMvbWVkaWEvdXNiL3V2Yy91dmNf dmlkZW8uYyAgICAgICAgICAgICB8ICAgNiArLQo+ICBmcy9uZnMvbmZzNHhkci5jICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAgIDIgKy0KPiAgaW5jbHVkZS9saW51eC9pcHY2LmggICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAyICstCj4gIGluY2x1ZGUvbmV0L2FkZHJjb25mLmgg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgNCArLQo+ICBpbmNsdWRlL25ldC9pZl9pbmV0Ni5o ICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDIgKy0KPiAgaW5jbHVkZS9uZXQvbmRpc2MuaCAg ICAgICAgICAgICAgICAgICAgICAgICAgIHwgICA4ICstCj4gIGluY2x1ZGUvdWFwaS9saW51eC9p Zl9hZGRyLmggICAgICAgICAgICAgICAgICB8ICAgNSArLQo+ICBpbmNsdWRlL3VhcGkvbGludXgv aXB2Ni5oICAgICAgICAgICAgICAgICAgICAgfCAgIDQgKy0KPiAgaW5jbHVkZS91YXBpL2xpbnV4 L3N5c2N0bC5oICAgICAgICAgICAgICAgICAgIHwgICA0ICstCj4gIGluY2x1ZGUvdWFwaS9saW51 eC91c2IvdmlkZW8uaCAgICAgICAgICAgICAgICB8ICAgNSArLQo+ICBrZXJuZWwvc3lzY3RsX2Jp bmFyeS5jICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDMgKy0KPiAgbmV0LzZsb3dwYW4vbmRp c2MuYyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICA0ICstCj4gIG5ldC9pcHY0L2Rldmlu ZXQuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAyMCArKy0tCj4gIG5ldC9pcHY2L2Fk ZHJjb25mLmMgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDExMyArKysrKysrKysrLS0tLS0t LS0KPiAgMTkgZmlsZXMgY2hhbmdlZCwgMTEyIGluc2VydGlvbnMoKyksIDgyIGRlbGV0aW9ucygt KQoKW3NuaXBdCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3VzYi91dmMvdXZjX3ZpZGVv LmMgYi9kcml2ZXJzL21lZGlhL3VzYi91dmMvdXZjX3ZpZGVvLmMKPiBpbmRleCA4ZmE3N2E4MWRk N2YuLjAwOTZlNmFhY2RiNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21lZGlhL3VzYi91dmMvdXZj X3ZpZGVvLmMKPiArKysgYi9kcml2ZXJzL21lZGlhL3VzYi91dmMvdXZjX3ZpZGVvLmMKPiBAQCAt Mjc2LDEzICsyNzYsMTMgQEAgc3RhdGljIGludCB1dmNfZ2V0X3ZpZGVvX2N0cmwoc3RydWN0IHV2 Y19zdHJlYW1pbmcgKnN0cmVhbSwKPiAgCWlmIChzaXplID49IDM0KSB7Cj4gIAkJY3RybC0+ZHdD bG9ja0ZyZXF1ZW5jeSA9IGdldF91bmFsaWduZWRfbGUzMigmZGF0YVsyNl0pOwo+ICAJCWN0cmwt PmJtRnJhbWluZ0luZm8gPSBkYXRhWzMwXTsKPiAtCQljdHJsLT5iUHJlZmVyZWRWZXJzaW9uID0g ZGF0YVszMV07Cj4gKwkJY3RybC0+YlByZWZlcnJlZFZlcnNpb24gPSBkYXRhWzMxXTsKPiAgCQlj dHJsLT5iTWluVmVyc2lvbiA9IGRhdGFbMzJdOwo+ICAJCWN0cmwtPmJNYXhWZXJzaW9uID0gZGF0 YVszM107Cj4gIAl9IGVsc2Ugewo+ICAJCWN0cmwtPmR3Q2xvY2tGcmVxdWVuY3kgPSBzdHJlYW0t PmRldi0+Y2xvY2tfZnJlcXVlbmN5Owo+ICAJCWN0cmwtPmJtRnJhbWluZ0luZm8gPSAwOwo+IC0J CWN0cmwtPmJQcmVmZXJlZFZlcnNpb24gPSAwOwo+ICsJCWN0cmwtPmJQcmVmZXJyZWRWZXJzaW9u ID0gMDsKPiAgCQljdHJsLT5iTWluVmVyc2lvbiA9IDA7Cj4gIAkJY3RybC0+Yk1heFZlcnNpb24g PSAwOwo+ICAJfQo+IEBAIC0zMjUsNyArMzI1LDcgQEAgc3RhdGljIGludCB1dmNfc2V0X3ZpZGVv X2N0cmwoc3RydWN0IHV2Y19zdHJlYW1pbmcgKnN0cmVhbSwKPiAgCWlmIChzaXplID49IDM0KSB7 Cj4gIAkJcHV0X3VuYWxpZ25lZF9sZTMyKGN0cmwtPmR3Q2xvY2tGcmVxdWVuY3ksICZkYXRhWzI2 XSk7Cj4gIAkJZGF0YVszMF0gPSBjdHJsLT5ibUZyYW1pbmdJbmZvOwo+IC0JCWRhdGFbMzFdID0g Y3RybC0+YlByZWZlcmVkVmVyc2lvbjsKPiArCQlkYXRhWzMxXSA9IGN0cmwtPmJQcmVmZXJyZWRW ZXJzaW9uOwo+ICAJCWRhdGFbMzJdID0gY3RybC0+Yk1pblZlcnNpb247Cj4gIAkJZGF0YVszM10g PSBjdHJsLT5iTWF4VmVyc2lvbjsKPiAgCX0KCltzbmlwXQoKPiBkaWZmIC0tZ2l0IGEvaW5jbHVk ZS91YXBpL2xpbnV4L3VzYi92aWRlby5oIGIvaW5jbHVkZS91YXBpL2xpbnV4L3VzYi92aWRlby5o Cj4gaW5kZXggZDg1NGNiMTljNDJjLi41OTE2N2YwZWQ1YzEgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVk ZS91YXBpL2xpbnV4L3VzYi92aWRlby5oCj4gKysrIGIvaW5jbHVkZS91YXBpL2xpbnV4L3VzYi92 aWRlby5oCj4gQEAgLTQ0OCw3ICs0NDgsMTAgQEAgc3RydWN0IHV2Y19zdHJlYW1pbmdfY29udHJv bCB7Cj4gIAlfX3UzMiBkd01heFBheWxvYWRUcmFuc2ZlclNpemU7Cj4gIAlfX3UzMiBkd0Nsb2Nr RnJlcXVlbmN5Owo+ICAJX191OCAgYm1GcmFtaW5nSW5mbzsKPiAtCV9fdTggIGJQcmVmZXJlZFZl cnNpb247Cj4gKwl1bmlvbiB7Cj4gKwkJX191OCBiUHJlZmVycmVkVmVyc2lvbjsKPiArCQlfX3U4 IGJQcmVmZXJlZFZlcnNpb24gX19hdHRyaWJ1dGVfXygoZGVwcmVjYXRlZCkpOyAvKiBOT1RZUE8g Ki8KPiArCX0gX19hdHRyaWJ1dGVfXygoX19wYWNrZWRfXykpOwoKUXVpdGUgaW50ZXJlc3Rpbmds eSB0aGlzIHR5cG8gaXMgcGFydCBvZiB0aGUgVVNCIGRldmljZSBjbGFzcyBkZWZpbml0aW9uCmZv ciB2aWRlbyBkZXZpY2VzIChVVkMpIHNwZWNpZmljYXRpb24uIEkgdGh1cyB0aGluayB3ZSBzaG91 bGQga2VlcCB1c2luZwp0aGUgZmllbGQgbmFtZSBiUHJlZmVyZWRWZXJzaW9uIHRocm91Z2ggdGhl IGNvZGUsIG90aGVyd2lzZSBpdCB3b3VsZG4ndAptYXRjaCB0aGUgc3BlYy4KCj4gIAlfX3U4ICBi TWluVmVyc2lvbjsKPiAgCV9fdTggIGJNYXhWZXJzaW9uOwo+ICB9IF9fYXR0cmlidXRlX18oKF9f cGFja2VkX18pKTsKCltzbmlwXQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWls aW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZy ZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAC0ECA9EB6 for ; Wed, 23 Oct 2019 10:29:36 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B4A7D20659 for ; Wed, 23 Oct 2019 10:29:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B4A7D20659 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 732F96EA31; Wed, 23 Oct 2019 10:29:36 +0000 (UTC) X-Greylist: delayed 436 seconds by postgrey-1.36 at gabe; Wed, 23 Oct 2019 10:29:34 UTC Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6A0B46EA31 for ; Wed, 23 Oct 2019 10:29:34 +0000 (UTC) Received: from pendragon.ideasonboard.com (143.121.2.93.rev.sfr.net [93.2.121.143]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 613D5814; Wed, 23 Oct 2019 12:22:13 +0200 (CEST) Date: Wed, 23 Oct 2019 13:22:07 +0300 From: Laurent Pinchart To: Mark Salyzyn Subject: Re: [PATCH] Cleanup: replace prefered with preferred Message-ID: <20191023102207.GB4763@pendragon.ideasonboard.com> References: <20191022214208.211448-1-salyzyn@android.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191022214208.211448-1-salyzyn@android.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1571826133; bh=eGJOH1VGLoVHmq/1QUJrrmrQnHMBekaXv4x5beDzUns=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hNt1lFgV/RYMyeFBPXTgQiKb3GwPw/Wa344JMMSZWnwFmLvL/ZwSc8yFopTSs7O3V 3BEcvANOutiE3Uqo9EUjLPvIH0XYH9JeysLU4k3odp1PfhlVV0P9EFVjba6AUVEZTx Bg5kiEXBNGIQl2WjyNDPL8rSeOPgyZ4CMk60KXUs= X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Alexander Aring , linux-efi@vger.kernel.org, Linus =?utf-8?Q?L=C3=BCssing?= , Greg Kroah-Hartman , David Airlie , Feng Tang , Jarkko Sakkinen , Roman Li , "David S. Miller" , netdev@vger.kernel.org, Ingo Molnar , Rafael Aquini , "David \(ChunMing\) Zhou" , Thomas Hellstrom , Jonathan Corbet , Francesco Ruggeri , Matthew Garrett , amd-gfx@lists.freedesktop.org, VMware Graphics , Alexey Kuznetsov , kernel-team@android.com, linux-media@vger.kernel.org, Leo Li , "Steven Rostedt \(VMware\)" , Hans de Goede , hersen wu , dri-devel@lists.freedesktop.org, Mauro Carvalho Chehab , Trond Myklebust , linux-nfs@vger.kernel.org, Andrew Morton , Ard Biesheuvel , Hideaki YOSHIFUJI , Harry Wentland , Maxim Martynov , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Anna Schumaker , linux-bluetooth@vger.kernel.org, Daniel Vetter , David Ahern , Alex Deucher , Jukka Rissanen , linux-wpan@vger.kernel.org, Christian =?utf-8?B?S8O2bmln?= Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Message-ID: <20191023102207.nnIb8sVYWZb_ka4LPg0QXl1wE8NEt11K50TOV3Nbi10@z> SGkgTWFyaywKClRoYW5rIHlvdSBmb3IgdGhlIHBhdGNoLgoKT24gVHVlLCBPY3QgMjIsIDIwMTkg YXQgMDI6NDE6NDVQTSAtMDcwMCwgTWFyayBTYWx5enluIHdyb3RlOgo+IFJlcGxhY2UgYWxsIG9j Y3VycmVuY2VzIG9mIHByZWZlcmVkIHdpdGggcHJlZmVycmVkIHRvIG1ha2UgZnV0dXJlCj4gY2hl Y2twYXRjaC5wbCdzIGhhcHB5LiAgQSBmZXcgcGxhY2VzIHRoZSBpbmNvcnJlY3Qgc3BlbGxpbmcg aXMKPiBtYXRjaGVkIHdpdGggdGhlIGNvcnJlY3Qgc3BlbGxpbmcgdG8gcHJlc2VydmUgZXhpc3Rp bmcgdXNlciBzcGFjZSBBUEkuCj4gCj4gU2lnbmVkLW9mZi1ieTogTWFyayBTYWx5enluIDxzYWx5 enluQGFuZHJvaWQuY29tPgo+IC0tLQo+ICBEb2N1bWVudGF0aW9uL25ldHdvcmtpbmcvaXAtc3lz Y3RsLnR4dCAgICAgICAgfCAgIDIgKy0KPiAgLi4uL2Zpcm13YXJlL2VmaS9saWJzdHViL2VmaS1z dHViLWhlbHBlci5jICAgIHwgICAyICstCj4gIC4uLi9ncHUvZHJtL2FtZC9kaXNwbGF5L2RjL2lu Yy9jb21wcmVzc29yLmggICB8ICAgNCArLQo+ICBkcml2ZXJzL2dwdS9kcm0vdm13Z2Z4L3Ztd2dm eF9rbXMuYyAgICAgICAgICAgfCAgIDIgKy0KPiAgZHJpdmVycy9ncHUvZHJtL3Ztd2dmeC92bXdn Znhfa21zLmggICAgICAgICAgIHwgICAyICstCj4gIGRyaXZlcnMvbWVkaWEvdXNiL3V2Yy91dmNf dmlkZW8uYyAgICAgICAgICAgICB8ICAgNiArLQo+ICBmcy9uZnMvbmZzNHhkci5jICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgfCAgIDIgKy0KPiAgaW5jbHVkZS9saW51eC9pcHY2LmggICAg ICAgICAgICAgICAgICAgICAgICAgIHwgICAyICstCj4gIGluY2x1ZGUvbmV0L2FkZHJjb25mLmgg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgNCArLQo+ICBpbmNsdWRlL25ldC9pZl9pbmV0Ni5o ICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDIgKy0KPiAgaW5jbHVkZS9uZXQvbmRpc2MuaCAg ICAgICAgICAgICAgICAgICAgICAgICAgIHwgICA4ICstCj4gIGluY2x1ZGUvdWFwaS9saW51eC9p Zl9hZGRyLmggICAgICAgICAgICAgICAgICB8ICAgNSArLQo+ICBpbmNsdWRlL3VhcGkvbGludXgv aXB2Ni5oICAgICAgICAgICAgICAgICAgICAgfCAgIDQgKy0KPiAgaW5jbHVkZS91YXBpL2xpbnV4 L3N5c2N0bC5oICAgICAgICAgICAgICAgICAgIHwgICA0ICstCj4gIGluY2x1ZGUvdWFwaS9saW51 eC91c2IvdmlkZW8uaCAgICAgICAgICAgICAgICB8ICAgNSArLQo+ICBrZXJuZWwvc3lzY3RsX2Jp bmFyeS5jICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDMgKy0KPiAgbmV0LzZsb3dwYW4vbmRp c2MuYyAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgICA0ICstCj4gIG5ldC9pcHY0L2Rldmlu ZXQuYyAgICAgICAgICAgICAgICAgICAgICAgICAgICB8ICAyMCArKy0tCj4gIG5ldC9pcHY2L2Fk ZHJjb25mLmMgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDExMyArKysrKysrKysrLS0tLS0t LS0KPiAgMTkgZmlsZXMgY2hhbmdlZCwgMTEyIGluc2VydGlvbnMoKyksIDgyIGRlbGV0aW9ucygt KQoKW3NuaXBdCgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL21lZGlhL3VzYi91dmMvdXZjX3ZpZGVv LmMgYi9kcml2ZXJzL21lZGlhL3VzYi91dmMvdXZjX3ZpZGVvLmMKPiBpbmRleCA4ZmE3N2E4MWRk N2YuLjAwOTZlNmFhY2RiNCAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21lZGlhL3VzYi91dmMvdXZj X3ZpZGVvLmMKPiArKysgYi9kcml2ZXJzL21lZGlhL3VzYi91dmMvdXZjX3ZpZGVvLmMKPiBAQCAt Mjc2LDEzICsyNzYsMTMgQEAgc3RhdGljIGludCB1dmNfZ2V0X3ZpZGVvX2N0cmwoc3RydWN0IHV2 Y19zdHJlYW1pbmcgKnN0cmVhbSwKPiAgCWlmIChzaXplID49IDM0KSB7Cj4gIAkJY3RybC0+ZHdD bG9ja0ZyZXF1ZW5jeSA9IGdldF91bmFsaWduZWRfbGUzMigmZGF0YVsyNl0pOwo+ICAJCWN0cmwt PmJtRnJhbWluZ0luZm8gPSBkYXRhWzMwXTsKPiAtCQljdHJsLT5iUHJlZmVyZWRWZXJzaW9uID0g ZGF0YVszMV07Cj4gKwkJY3RybC0+YlByZWZlcnJlZFZlcnNpb24gPSBkYXRhWzMxXTsKPiAgCQlj dHJsLT5iTWluVmVyc2lvbiA9IGRhdGFbMzJdOwo+ICAJCWN0cmwtPmJNYXhWZXJzaW9uID0gZGF0 YVszM107Cj4gIAl9IGVsc2Ugewo+ICAJCWN0cmwtPmR3Q2xvY2tGcmVxdWVuY3kgPSBzdHJlYW0t PmRldi0+Y2xvY2tfZnJlcXVlbmN5Owo+ICAJCWN0cmwtPmJtRnJhbWluZ0luZm8gPSAwOwo+IC0J CWN0cmwtPmJQcmVmZXJlZFZlcnNpb24gPSAwOwo+ICsJCWN0cmwtPmJQcmVmZXJyZWRWZXJzaW9u ID0gMDsKPiAgCQljdHJsLT5iTWluVmVyc2lvbiA9IDA7Cj4gIAkJY3RybC0+Yk1heFZlcnNpb24g PSAwOwo+ICAJfQo+IEBAIC0zMjUsNyArMzI1LDcgQEAgc3RhdGljIGludCB1dmNfc2V0X3ZpZGVv X2N0cmwoc3RydWN0IHV2Y19zdHJlYW1pbmcgKnN0cmVhbSwKPiAgCWlmIChzaXplID49IDM0KSB7 Cj4gIAkJcHV0X3VuYWxpZ25lZF9sZTMyKGN0cmwtPmR3Q2xvY2tGcmVxdWVuY3ksICZkYXRhWzI2 XSk7Cj4gIAkJZGF0YVszMF0gPSBjdHJsLT5ibUZyYW1pbmdJbmZvOwo+IC0JCWRhdGFbMzFdID0g Y3RybC0+YlByZWZlcmVkVmVyc2lvbjsKPiArCQlkYXRhWzMxXSA9IGN0cmwtPmJQcmVmZXJyZWRW ZXJzaW9uOwo+ICAJCWRhdGFbMzJdID0gY3RybC0+Yk1pblZlcnNpb247Cj4gIAkJZGF0YVszM10g PSBjdHJsLT5iTWF4VmVyc2lvbjsKPiAgCX0KCltzbmlwXQoKPiBkaWZmIC0tZ2l0IGEvaW5jbHVk ZS91YXBpL2xpbnV4L3VzYi92aWRlby5oIGIvaW5jbHVkZS91YXBpL2xpbnV4L3VzYi92aWRlby5o Cj4gaW5kZXggZDg1NGNiMTljNDJjLi41OTE2N2YwZWQ1YzEgMTAwNjQ0Cj4gLS0tIGEvaW5jbHVk ZS91YXBpL2xpbnV4L3VzYi92aWRlby5oCj4gKysrIGIvaW5jbHVkZS91YXBpL2xpbnV4L3VzYi92 aWRlby5oCj4gQEAgLTQ0OCw3ICs0NDgsMTAgQEAgc3RydWN0IHV2Y19zdHJlYW1pbmdfY29udHJv bCB7Cj4gIAlfX3UzMiBkd01heFBheWxvYWRUcmFuc2ZlclNpemU7Cj4gIAlfX3UzMiBkd0Nsb2Nr RnJlcXVlbmN5Owo+ICAJX191OCAgYm1GcmFtaW5nSW5mbzsKPiAtCV9fdTggIGJQcmVmZXJlZFZl cnNpb247Cj4gKwl1bmlvbiB7Cj4gKwkJX191OCBiUHJlZmVycmVkVmVyc2lvbjsKPiArCQlfX3U4 IGJQcmVmZXJlZFZlcnNpb24gX19hdHRyaWJ1dGVfXygoZGVwcmVjYXRlZCkpOyAvKiBOT1RZUE8g Ki8KPiArCX0gX19hdHRyaWJ1dGVfXygoX19wYWNrZWRfXykpOwoKUXVpdGUgaW50ZXJlc3Rpbmds eSB0aGlzIHR5cG8gaXMgcGFydCBvZiB0aGUgVVNCIGRldmljZSBjbGFzcyBkZWZpbml0aW9uCmZv ciB2aWRlbyBkZXZpY2VzIChVVkMpIHNwZWNpZmljYXRpb24uIEkgdGh1cyB0aGluayB3ZSBzaG91 bGQga2VlcCB1c2luZwp0aGUgZmllbGQgbmFtZSBiUHJlZmVyZWRWZXJzaW9uIHRocm91Z2ggdGhl IGNvZGUsIG90aGVyd2lzZSBpdCB3b3VsZG4ndAptYXRjaCB0aGUgc3BlYy4KCj4gIAlfX3U4ICBi TWluVmVyc2lvbjsKPiAgCV9fdTggIGJNYXhWZXJzaW9uOwo+ICB9IF9fYXR0cmlidXRlX18oKF9f cGFja2VkX18pKTsKCltzbmlwXQoKLS0gClJlZ2FyZHMsCgpMYXVyZW50IFBpbmNoYXJ0Cl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGlu ZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA==