From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07596CA9EB6 for ; Wed, 23 Oct 2019 12:22:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CCC582086D for ; Wed, 23 Oct 2019 12:22:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="i4gpfqId" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405319AbfJWMWa (ORCPT ); Wed, 23 Oct 2019 08:22:30 -0400 Received: from mail-wr1-f66.google.com ([209.85.221.66]:32947 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726636AbfJWMWa (ORCPT ); Wed, 23 Oct 2019 08:22:30 -0400 Received: by mail-wr1-f66.google.com with SMTP id s1so13103226wro.0 for ; Wed, 23 Oct 2019 05:22:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e3FCsAeT5K9ZdHIcSbJyMOoHwnh6UPbcGp5phHrUoac=; b=i4gpfqIdPEPkJ1QTxEJgpm5N7TxdtUNBaeo3ktliHpa/YrfYV2a3i2DLSwCxuUukH9 5TBN+AvjFQiQA0UV/Hkv6aO5jNaR4406iJlviEAeXPGBQaTJ5GD0Kdm8oFZ1SzW+QcXp iF+D5gv+SV4HN074ghZz+TnklNwpyqUjIAwUMtudRiYI1ar4jdk21PUbwtx/1FHTsU2k 61hNyMVQzIbPy8GPcmcLnu0hTRDyF2h0Fc1ULq+DPnDucNhBlXLz5rfO32KQr34Trwlf 7RBEdT//fDSlbCU/5Z/W7DqNLzDRCiJGL7TqE/xY5T5qCc9qf7iV1yzXr9sEZu5nAg/T PJwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=e3FCsAeT5K9ZdHIcSbJyMOoHwnh6UPbcGp5phHrUoac=; b=shOXXJ0up4/FdtrmxGj5SaMxdCO3p9eucZH+sxSStIJzuxJEaw6mCO5R00X2vnl/F3 7OA+9/xng1ZH6qwYOaCCXTyGuRofqMYz5rz5HUrmeLNzbDDs9FjL8VtiRkscf5vlQIBy b8nUk8xcNijtbFiyYfTZdzH4ivEjVaGNDEUBNsol2QyPaUA9khvdvc/8ixyZBR9ejOXm OeM4RCg2eqKDJyqPjYVxgBhvx3jprEnsQuM5PTjFApVmboDDrawAJ/Lg1B2hiBzFewlw u+xTQVplkEYYI+1SIYuaWBGD2fKJlnYD6AmoL5xA5XlcHb7Jgx1OVp3n/+kA8bA7BHnF 74Sw== X-Gm-Message-State: APjAAAXK1bLJL2xq5tgoJ6Aj4LMB8cCuQ3IMrWYVOSkhDWvXaC8kR5LK bp124GH9xJEimimHHJftHnWtOSeWMzw= X-Google-Smtp-Source: APXvYqw1NcJwe73jzpm/8PbdxicLWL/zyK/dS0vS9s2mDoXESRNQsH6ykzl6XO+SGpl9tHwnGk+JPg== X-Received: by 2002:a5d:614e:: with SMTP id y14mr8543618wrt.329.1571833348216; Wed, 23 Oct 2019 05:22:28 -0700 (PDT) Received: from cizrna.lan ([109.72.12.196]) by smtp.gmail.com with ESMTPSA id x21sm9773421wmj.42.2019.10.23.05.22.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2019 05:22:26 -0700 (PDT) From: Tomeu Vizoso To: linux-kernel@vger.kernel.org Cc: Tomeu Vizoso , Chen-Yu Tsai , Robin Murphy , Rob Herring , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org Subject: [PATCH v2] panfrost: Properly undo pm_runtime_enable when deferring a probe Date: Wed, 23 Oct 2019 14:21:57 +0200 Message-Id: <20191023122157.32067-1-tomeu.vizoso@collabora.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191023120925.30668-1-tomeu.vizoso@collabora.com> References: <20191023120925.30668-1-tomeu.vizoso@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org When deferring the probe because of a missing regulator, we were calling pm_runtime_disable even if pm_runtime_enable wasn't called. Move the call to pm_runtime_disable to the right place. Signed-off-by: Tomeu Vizoso Reported-by: Chen-Yu Tsai Cc: Robin Murphy Fixes: f4a3c6a44b35 ("drm/panfrost: Disable PM on probe failure") --- drivers/gpu/drm/panfrost/panfrost_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panfrost/panfrost_drv.c b/drivers/gpu/drm/panfrost/panfrost_drv.c index bc2ddeb55f5d..f21bc8a7ee3a 100644 --- a/drivers/gpu/drm/panfrost/panfrost_drv.c +++ b/drivers/gpu/drm/panfrost/panfrost_drv.c @@ -556,11 +556,11 @@ static int panfrost_probe(struct platform_device *pdev) return 0; err_out2: + pm_runtime_disable(pfdev->dev); panfrost_devfreq_fini(pfdev); err_out1: panfrost_device_fini(pfdev); err_out0: - pm_runtime_disable(pfdev->dev); drm_dev_put(ddev); return err; } -- 2.20.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4025CCA9EB9 for ; Wed, 23 Oct 2019 12:22:32 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1DADE2086D for ; Wed, 23 Oct 2019 12:22:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DADE2086D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id AE4CB6EA77; Wed, 23 Oct 2019 12:22:31 +0000 (UTC) Received: from mail-wr1-x444.google.com (mail-wr1-x444.google.com [IPv6:2a00:1450:4864:20::444]) by gabe.freedesktop.org (Postfix) with ESMTPS id A019F6EA77 for ; Wed, 23 Oct 2019 12:22:29 +0000 (UTC) Received: by mail-wr1-x444.google.com with SMTP id o28so21847315wro.7 for ; Wed, 23 Oct 2019 05:22:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=e3FCsAeT5K9ZdHIcSbJyMOoHwnh6UPbcGp5phHrUoac=; b=Vt9/wxvP5fyoAsM4RhfJo1VaukH72ObWA0f3SJzXqXSuw1p1HRCp12D/L6sKQvWTR5 taronmVfAmR1VbBQ/sHskFih5pEVnWBdnpZfciH0yeri+ssXceSseRy/xyO7lZ6G+rFA fB7LC6gM0QjYxfEdV1sxOhqOLaE3M+Tw4VMfQQQViurdrDMTQjHz1jm4Di+CaPGEI6KS 3eydEq5vv7+8B9SwD9KD63KwmQWuOjlRXxBe5W48vL8Rb4uqz1WQFjawOg+wVMkc6nt7 +eQ4IDHbXFJx/LXfK57QBpHYqD+7Dn4uE8rctNmZO2Xi+fKPuE4DIPwOGOm94wwUMycr m+3w== X-Gm-Message-State: APjAAAUMM1Vq3o+myIljrZHSC+fCq7Z3HSktkMuYD0cpIkamoUVFGSw1 1Uatks6SZRZmOHn34Ti71Fw= X-Google-Smtp-Source: APXvYqw1NcJwe73jzpm/8PbdxicLWL/zyK/dS0vS9s2mDoXESRNQsH6ykzl6XO+SGpl9tHwnGk+JPg== X-Received: by 2002:a5d:614e:: with SMTP id y14mr8543618wrt.329.1571833348216; Wed, 23 Oct 2019 05:22:28 -0700 (PDT) Received: from cizrna.lan ([109.72.12.196]) by smtp.gmail.com with ESMTPSA id x21sm9773421wmj.42.2019.10.23.05.22.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Oct 2019 05:22:26 -0700 (PDT) From: Tomeu Vizoso To: linux-kernel@vger.kernel.org Subject: [PATCH v2] panfrost: Properly undo pm_runtime_enable when deferring a probe Date: Wed, 23 Oct 2019 14:21:57 +0200 Message-Id: <20191023122157.32067-1-tomeu.vizoso@collabora.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191023120925.30668-1-tomeu.vizoso@collabora.com> References: <20191023120925.30668-1-tomeu.vizoso@collabora.com> MIME-Version: 1.0 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=e3FCsAeT5K9ZdHIcSbJyMOoHwnh6UPbcGp5phHrUoac=; b=i4gpfqIdPEPkJ1QTxEJgpm5N7TxdtUNBaeo3ktliHpa/YrfYV2a3i2DLSwCxuUukH9 5TBN+AvjFQiQA0UV/Hkv6aO5jNaR4406iJlviEAeXPGBQaTJ5GD0Kdm8oFZ1SzW+QcXp iF+D5gv+SV4HN074ghZz+TnklNwpyqUjIAwUMtudRiYI1ar4jdk21PUbwtx/1FHTsU2k 61hNyMVQzIbPy8GPcmcLnu0hTRDyF2h0Fc1ULq+DPnDucNhBlXLz5rfO32KQr34Trwlf 7RBEdT//fDSlbCU/5Z/W7DqNLzDRCiJGL7TqE/xY5T5qCc9qf7iV1yzXr9sEZu5nAg/T PJwg== X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tomeu Vizoso , David Airlie , dri-devel@lists.freedesktop.org, Chen-Yu Tsai , Robin Murphy Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Message-ID: <20191023122157.92W_6eGq4g5-nLww44JE88hxof07se_Kvhk397kUi0E@z> V2hlbiBkZWZlcnJpbmcgdGhlIHByb2JlIGJlY2F1c2Ugb2YgYSBtaXNzaW5nIHJlZ3VsYXRvciwg d2Ugd2VyZSBjYWxsaW5nCnBtX3J1bnRpbWVfZGlzYWJsZSBldmVuIGlmIHBtX3J1bnRpbWVfZW5h YmxlIHdhc24ndCBjYWxsZWQuCgpNb3ZlIHRoZSBjYWxsIHRvIHBtX3J1bnRpbWVfZGlzYWJsZSB0 byB0aGUgcmlnaHQgcGxhY2UuCgpTaWduZWQtb2ZmLWJ5OiBUb21ldSBWaXpvc28gPHRvbWV1LnZp em9zb0Bjb2xsYWJvcmEuY29tPgpSZXBvcnRlZC1ieTogQ2hlbi1ZdSBUc2FpIDx3ZW5zQGNzaWUu b3JnPgpDYzogUm9iaW4gTXVycGh5IDxyb2Jpbi5tdXJwaHlAYXJtLmNvbT4KRml4ZXM6IGY0YTNj NmE0NGIzNSAoImRybS9wYW5mcm9zdDogRGlzYWJsZSBQTSBvbiBwcm9iZSBmYWlsdXJlIikKLS0t CiBkcml2ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZHJ2LmMgfCAyICstCiAxIGZpbGUg Y2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEgZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZHJ2LmMgYi9kcml2ZXJzL2dwdS9kcm0vcGFu ZnJvc3QvcGFuZnJvc3RfZHJ2LmMKaW5kZXggYmMyZGRlYjU1ZjVkLi5mMjFiYzhhN2VlM2EgMTAw NjQ0Ci0tLSBhL2RyaXZlcnMvZ3B1L2RybS9wYW5mcm9zdC9wYW5mcm9zdF9kcnYuYworKysgYi9k cml2ZXJzL2dwdS9kcm0vcGFuZnJvc3QvcGFuZnJvc3RfZHJ2LmMKQEAgLTU1NiwxMSArNTU2LDEx IEBAIHN0YXRpYyBpbnQgcGFuZnJvc3RfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRl dikKIAlyZXR1cm4gMDsKIAogZXJyX291dDI6CisJcG1fcnVudGltZV9kaXNhYmxlKHBmZGV2LT5k ZXYpOwogCXBhbmZyb3N0X2RldmZyZXFfZmluaShwZmRldik7CiBlcnJfb3V0MToKIAlwYW5mcm9z dF9kZXZpY2VfZmluaShwZmRldik7CiBlcnJfb3V0MDoKLQlwbV9ydW50aW1lX2Rpc2FibGUocGZk ZXYtPmRldik7CiAJZHJtX2Rldl9wdXQoZGRldik7CiAJcmV0dXJuIGVycjsKIH0KLS0gCjIuMjAu MQoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8v bGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs