From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55BFBCA9EB9 for ; Wed, 23 Oct 2019 15:45:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2C8F721D7F for ; Wed, 23 Oct 2019 15:45:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2406899AbfJWPpU (ORCPT ); Wed, 23 Oct 2019 11:45:20 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:37708 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404032AbfJWPpU (ORCPT ); Wed, 23 Oct 2019 11:45:20 -0400 Received: from localhost.localdomain (unknown [IPv6:2a01:e0a:2c:6930:5cf4:84a1:2763:fe0d]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: bbrezillon) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 2922228F907; Wed, 23 Oct 2019 16:45:18 +0100 (BST) From: Boris Brezillon To: dri-devel@lists.freedesktop.org Cc: Lucas Stach , Chris Healy , Andrey Smirnov , Nikita Yushchenko , kernel@collabora.com, Daniel Vetter , Inki Dae , Joonyoung Shim , Seung-Woo Kim , Kyungmin Park , Thierry Reding , Sam Ravnborg , Philipp Zabel , Rob Clark , Andrzej Hajda , Neil Armstrong , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Rob Herring , Mark Rutland , devicetree@vger.kernel.org, Boris Brezillon , Laurent Pinchart Subject: [PATCH v3 02/21] drm/exynos: Don't reset bridge->next Date: Wed, 23 Oct 2019 17:44:53 +0200 Message-Id: <20191023154512.9762-3-boris.brezillon@collabora.com> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20191023154512.9762-1-boris.brezillon@collabora.com> References: <20191023154512.9762-1-boris.brezillon@collabora.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org bridge->next is only points to the new bridge if drm_bridge_attach() succeeds. No need to reset it manually here. Note that this change is part of the attempt to make the bridge chain a double-linked list. In order to do that we must patch all drivers manipulating the bridge->next field. Signed-off-by: Boris Brezillon Reviewed-by: Laurent Pinchart --- Changes in v2: * Add Laurent's R-b (I'd like to have a R-b from the DRM exynos maintainers before applying that one) --- drivers/gpu/drm/exynos/exynos_dp.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c index 1e6aa24bf45e..4785885c0f4f 100644 --- a/drivers/gpu/drm/exynos/exynos_dp.c +++ b/drivers/gpu/drm/exynos/exynos_dp.c @@ -110,7 +110,6 @@ static int exynos_dp_bridge_attach(struct analogix_dp_plat_data *plat_data, if (ret) { DRM_DEV_ERROR(dp->dev, "Failed to attach bridge to drm\n"); - bridge->next = NULL; return ret; } } -- 2.21.0 From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Brezillon Subject: [PATCH v3 02/21] drm/exynos: Don't reset bridge->next Date: Wed, 23 Oct 2019 17:44:53 +0200 Message-ID: <20191023154512.9762-3-boris.brezillon@collabora.com> References: <20191023154512.9762-1-boris.brezillon@collabora.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from bhuna.collabora.co.uk (bhuna.collabora.co.uk [IPv6:2a00:1098:0:82:1000:25:2eeb:e3e3]) by gabe.freedesktop.org (Postfix) with ESMTPS id 071606EB1A for ; Wed, 23 Oct 2019 15:45:20 +0000 (UTC) In-Reply-To: <20191023154512.9762-1-boris.brezillon@collabora.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: Mark Rutland , Neil Armstrong , Thierry Reding , Laurent Pinchart , kernel@collabora.com, Sam Ravnborg , Nikita Yushchenko , Andrey Smirnov , Kyungmin Park , Chris Healy , devicetree@vger.kernel.org, Jonas Karlman , Rob Herring , Jernej Skrabec , Seung-Woo Kim , Boris Brezillon List-Id: dri-devel@lists.freedesktop.org YnJpZGdlLT5uZXh0IGlzIG9ubHkgcG9pbnRzIHRvIHRoZSBuZXcgYnJpZGdlIGlmIGRybV9icmlk Z2VfYXR0YWNoKCkKc3VjY2VlZHMuIE5vIG5lZWQgdG8gcmVzZXQgaXQgbWFudWFsbHkgaGVyZS4K Ck5vdGUgdGhhdCB0aGlzIGNoYW5nZSBpcyBwYXJ0IG9mIHRoZSBhdHRlbXB0IHRvIG1ha2UgdGhl IGJyaWRnZSBjaGFpbgphIGRvdWJsZS1saW5rZWQgbGlzdC4gSW4gb3JkZXIgdG8gZG8gdGhhdCB3 ZSBtdXN0IHBhdGNoIGFsbCBkcml2ZXJzCm1hbmlwdWxhdGluZyB0aGUgYnJpZGdlLT5uZXh0IGZp ZWxkLgoKU2lnbmVkLW9mZi1ieTogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AY29s bGFib3JhLmNvbT4KUmV2aWV3ZWQtYnk6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hh cnRAaWRlYXNvbmJvYXJkLmNvbT4KLS0tCkNoYW5nZXMgaW4gdjI6CiogQWRkIExhdXJlbnQncyBS LWIgKEknZCBsaWtlIHRvIGhhdmUgYSBSLWIgZnJvbSB0aGUgRFJNIGV4eW5vcwogIG1haW50YWlu ZXJzIGJlZm9yZSBhcHBseWluZyB0aGF0IG9uZSkKLS0tCiBkcml2ZXJzL2dwdS9kcm0vZXh5bm9z L2V4eW5vc19kcC5jIHwgMSAtCiAxIGZpbGUgY2hhbmdlZCwgMSBkZWxldGlvbigtKQoKZGlmZiAt LWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RwLmMgYi9kcml2ZXJzL2dwdS9k cm0vZXh5bm9zL2V4eW5vc19kcC5jCmluZGV4IDFlNmFhMjRiZjQ1ZS4uNDc4NTg4NWMwZjRmIDEw MDY0NAotLS0gYS9kcml2ZXJzL2dwdS9kcm0vZXh5bm9zL2V4eW5vc19kcC5jCisrKyBiL2RyaXZl cnMvZ3B1L2RybS9leHlub3MvZXh5bm9zX2RwLmMKQEAgLTExMCw3ICsxMTAsNiBAQCBzdGF0aWMg aW50IGV4eW5vc19kcF9icmlkZ2VfYXR0YWNoKHN0cnVjdCBhbmFsb2dpeF9kcF9wbGF0X2RhdGEg KnBsYXRfZGF0YSwKIAkJaWYgKHJldCkgewogCQkJRFJNX0RFVl9FUlJPUihkcC0+ZGV2LAogCQkJ CSAgICAgICJGYWlsZWQgdG8gYXR0YWNoIGJyaWRnZSB0byBkcm1cbiIpOwotCQkJYnJpZGdlLT5u ZXh0ID0gTlVMTDsKIAkJCXJldHVybiByZXQ7CiAJCX0KIAl9Ci0tIAoyLjIxLjAKCl9fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5n IGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVk ZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbA==