From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F3F6CA9EB9 for ; Wed, 23 Oct 2019 22:57:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1A50920663 for ; Wed, 23 Oct 2019 22:57:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392707AbfJWW5b (ORCPT ); Wed, 23 Oct 2019 18:57:31 -0400 Received: from mga04.intel.com ([192.55.52.120]:43380 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727831AbfJWW5b (ORCPT ); Wed, 23 Oct 2019 18:57:31 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 15:57:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,222,1569308400"; d="scan'208";a="202133555" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga006.jf.intel.com with ESMTP; 23 Oct 2019 15:57:31 -0700 Date: Wed, 23 Oct 2019 16:01:52 -0700 From: Jacob Pan To: Lu Baolu Cc: "Raj, Ashok" , iommu@lists.linux-foundation.org, LKML , Joerg Roedel , David Woodhouse , Alex Williamson , Jean-Philippe Brucker , Yi Liu , "Tian, Kevin" , Christoph Hellwig , Jonathan Cameron , Eric Auger , jacob.jun.pan@linux.intel.com Subject: Re: [PATCH v6 02/10] iommu/vt-d: Add custom allocator for IOASID Message-ID: <20191023160152.07305918@jacob-builder> In-Reply-To: <0a0f33b8-e3d8-3d29-ca71-552f1875bc62@linux.intel.com> References: <1571788403-42095-1-git-send-email-jacob.jun.pan@linux.intel.com> <1571788403-42095-3-git-send-email-jacob.jun.pan@linux.intel.com> <20191023005129.GC100970@otc-nc-03> <0a0f33b8-e3d8-3d29-ca71-552f1875bc62@linux.intel.com> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 23 Oct 2019 10:21:51 +0800 Lu Baolu wrote: > >> +#ifdef CONFIG_INTEL_IOMMU_SVM > > > > Maybe move them to intel-svm.c instead? that's where the bulk > > of the svm support is? > > I think this is a generic PASID allocator for guest IOMMU although > vSVA is currently the only consumer. Instead of making it SVM > specific, I'd like to suggest moving it to intel-pasid.c and replace > the @svm parameter with a void * one in intel_ioasid_free(). make sense to use void*, no need to tie that to svm bind data type. In terms of location, perhaps we can move if we have more consumers of custom allocator? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BFC79CA9EBC for ; Wed, 23 Oct 2019 22:57:33 +0000 (UTC) Received: from mail.linuxfoundation.org (mail.linuxfoundation.org [140.211.169.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 936E02084C for ; Wed, 23 Oct 2019 22:57:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 936E02084C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from mail.linux-foundation.org (localhost [127.0.0.1]) by mail.linuxfoundation.org (Postfix) with ESMTP id 65A14CC6; Wed, 23 Oct 2019 22:57:33 +0000 (UTC) Received: from smtp1.linuxfoundation.org (smtp1.linux-foundation.org [172.17.192.35]) by mail.linuxfoundation.org (Postfix) with ESMTPS id 343BC92F for ; Wed, 23 Oct 2019 22:57:32 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by smtp1.linuxfoundation.org (Postfix) with ESMTPS id DC00314D for ; Wed, 23 Oct 2019 22:57:31 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 23 Oct 2019 15:57:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,222,1569308400"; d="scan'208";a="202133555" Received: from jacob-builder.jf.intel.com (HELO jacob-builder) ([10.7.199.155]) by orsmga006.jf.intel.com with ESMTP; 23 Oct 2019 15:57:31 -0700 Date: Wed, 23 Oct 2019 16:01:52 -0700 From: Jacob Pan To: Lu Baolu Subject: Re: [PATCH v6 02/10] iommu/vt-d: Add custom allocator for IOASID Message-ID: <20191023160152.07305918@jacob-builder> In-Reply-To: <0a0f33b8-e3d8-3d29-ca71-552f1875bc62@linux.intel.com> References: <1571788403-42095-1-git-send-email-jacob.jun.pan@linux.intel.com> <1571788403-42095-3-git-send-email-jacob.jun.pan@linux.intel.com> <20191023005129.GC100970@otc-nc-03> <0a0f33b8-e3d8-3d29-ca71-552f1875bc62@linux.intel.com> Organization: OTC X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Cc: "Tian, Kevin" , "Raj, Ashok" , Jean-Philippe Brucker , iommu@lists.linux-foundation.org, LKML , Alex Williamson , David Woodhouse , Jonathan Cameron X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.12 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: iommu-bounces@lists.linux-foundation.org Errors-To: iommu-bounces@lists.linux-foundation.org On Wed, 23 Oct 2019 10:21:51 +0800 Lu Baolu wrote: > >> +#ifdef CONFIG_INTEL_IOMMU_SVM > > > > Maybe move them to intel-svm.c instead? that's where the bulk > > of the svm support is? > > I think this is a generic PASID allocator for guest IOMMU although > vSVA is currently the only consumer. Instead of making it SVM > specific, I'd like to suggest moving it to intel-pasid.c and replace > the @svm parameter with a void * one in intel_ioasid_free(). make sense to use void*, no need to tie that to svm bind data type. In terms of location, perhaps we can move if we have more consumers of custom allocator? _______________________________________________ iommu mailing list iommu@lists.linux-foundation.org https://lists.linuxfoundation.org/mailman/listinfo/iommu