From: Bart Van Assche <bvanassche@acm.org> To: "Martin K . Petersen" <martin.petersen@oracle.com> Cc: Mike Christie <mchristi@redhat.com>, Christoph Hellwig <hch@lst.de>, target-devel@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>, Dan Carpenter <dan.carpenter@oracle.com>, Varun Prakash <varun@chelsio.com>, Nicholas Bellinger <nab@linux-iscsi.org>, stable@vger.kernel.org Subject: [PATCH] target/cxgbit: Fix cxgbit_fw4_ack() Date: Wed, 23 Oct 2019 20:21:50 +0000 [thread overview] Message-ID: <20191023202150.22173-1-bvanassche@acm.org> (raw) Use the pointer 'p' after having tested that pointer instead of before. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: Varun Prakash <varun@chelsio.com> Cc: Nicholas Bellinger <nab@linux-iscsi.org> Cc: <stable@vger.kernel.org> Fixes: 5cadafb236df ("target/cxgbit: Fix endianness annotations") Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/target/iscsi/cxgbit/cxgbit_cm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/target/iscsi/cxgbit/cxgbit_cm.c b/drivers/target/iscsi/cxgbit/cxgbit_cm.c index c70caf4ea490..a2b5c796bbc4 100644 --- a/drivers/target/iscsi/cxgbit/cxgbit_cm.c +++ b/drivers/target/iscsi/cxgbit/cxgbit_cm.c @@ -1831,7 +1831,7 @@ static void cxgbit_fw4_ack(struct cxgbit_sock *csk, struct sk_buff *skb) while (credits) { struct sk_buff *p = cxgbit_sock_peek_wr(csk); - const u32 csum = (__force u32)p->csum; + u32 csum; if (unlikely(!p)) { pr_err("csk 0x%p,%u, cr %u,%u+%u, empty.\n", @@ -1840,6 +1840,7 @@ static void cxgbit_fw4_ack(struct cxgbit_sock *csk, struct sk_buff *skb) break; } + csum = (__force u32)p->csum; if (unlikely(credits < csum)) { pr_warn("csk 0x%p,%u, cr %u,%u+%u, < %u.\n", csk, csk->tid, -- 2.23.0
WARNING: multiple messages have this Message-ID
From: Bart Van Assche <bvanassche@acm.org> To: "Martin K . Petersen" <martin.petersen@oracle.com> Cc: Mike Christie <mchristi@redhat.com>, Christoph Hellwig <hch@lst.de>, target-devel@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>, Dan Carpenter <dan.carpenter@oracle.com>, Varun Prakash <varun@chelsio.com>, Nicholas Bellinger <nab@linux-iscsi.org>, stable@vger.kernel.org Subject: [PATCH] target/cxgbit: Fix cxgbit_fw4_ack() Date: Wed, 23 Oct 2019 13:21:50 -0700 [thread overview] Message-ID: <20191023202150.22173-1-bvanassche@acm.org> (raw) Use the pointer 'p' after having tested that pointer instead of before. Reported-by: Dan Carpenter <dan.carpenter@oracle.com> Cc: Varun Prakash <varun@chelsio.com> Cc: Nicholas Bellinger <nab@linux-iscsi.org> Cc: <stable@vger.kernel.org> Fixes: 5cadafb236df ("target/cxgbit: Fix endianness annotations") Signed-off-by: Bart Van Assche <bvanassche@acm.org> --- drivers/target/iscsi/cxgbit/cxgbit_cm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/target/iscsi/cxgbit/cxgbit_cm.c b/drivers/target/iscsi/cxgbit/cxgbit_cm.c index c70caf4ea490..a2b5c796bbc4 100644 --- a/drivers/target/iscsi/cxgbit/cxgbit_cm.c +++ b/drivers/target/iscsi/cxgbit/cxgbit_cm.c @@ -1831,7 +1831,7 @@ static void cxgbit_fw4_ack(struct cxgbit_sock *csk, struct sk_buff *skb) while (credits) { struct sk_buff *p = cxgbit_sock_peek_wr(csk); - const u32 csum = (__force u32)p->csum; + u32 csum; if (unlikely(!p)) { pr_err("csk 0x%p,%u, cr %u,%u+%u, empty.\n", @@ -1840,6 +1840,7 @@ static void cxgbit_fw4_ack(struct cxgbit_sock *csk, struct sk_buff *skb) break; } + csum = (__force u32)p->csum; if (unlikely(credits < csum)) { pr_warn("csk 0x%p,%u, cr %u,%u+%u, < %u.\n", csk, csk->tid, -- 2.23.0
next reply other threads:[~2019-10-23 20:21 UTC|newest] Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-10-23 20:21 Bart Van Assche [this message] 2019-10-23 20:21 ` Bart Van Assche 2019-10-25 0:22 ` Martin K. Petersen 2019-10-25 0:22 ` Martin K. Petersen
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20191023202150.22173-1-bvanassche@acm.org \ --to=bvanassche@acm.org \ --cc=dan.carpenter@oracle.com \ --cc=hch@lst.de \ --cc=martin.petersen@oracle.com \ --cc=mchristi@redhat.com \ --cc=nab@linux-iscsi.org \ --cc=stable@vger.kernel.org \ --cc=target-devel@vger.kernel.org \ --cc=varun@chelsio.com \ --subject='Re: [PATCH] target/cxgbit: Fix cxgbit_fw4_ack()' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.