All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: mcroce@redhat.com
Cc: netdev@vger.kernel.org, j.vosburgh@gmail.com, vfalico@gmail.com,
	andy@greyhouse.net, sdf@google.com, daniel@iogearbox.net,
	songliubraving@fb.com, ast@kernel.org, paulb@mellanox.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 0/4] ICMP flow improvements
Date: Thu, 24 Oct 2019 15:05:03 -0700 (PDT)	[thread overview]
Message-ID: <20191024.150503.272673272041377721.davem@davemloft.net> (raw)
In-Reply-To: <20191021200948.23775-1-mcroce@redhat.com>

From: Matteo Croce <mcroce@redhat.com>
Date: Mon, 21 Oct 2019 22:09:44 +0200

> This series improves the flow inspector handling of ICMP packets:
> The first two patches just add some comments in the code which would have saved
> me a few minutes of time, and refactor a piece of code.
> The third one adds to the flow inspector the capability to extract the
> Identifier field, if present, so echo requests and replies are classified
> as part of the same flow.
> The fourth patch uses the function introduced earlier to the bonding driver,
> so echo replies can be balanced across bonding slaves.

Simon has unaddressed feedback for patch #3, and this has been sitting in that
state for several days.

Please repost this series when everything is sorted, thank you.

      parent reply	other threads:[~2019-10-24 22:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-21 20:09 [PATCH net-next 0/4] ICMP flow improvements Matteo Croce
2019-10-21 20:09 ` [PATCH net-next 1/4] flow_dissector: add meaningful comments Matteo Croce
2019-10-23  9:57   ` Simon Horman
2019-10-21 20:09 ` [PATCH net-next 2/4] flow_dissector: skip the ICMP dissector for non ICMP packets Matteo Croce
2019-10-23  9:57   ` Simon Horman
2019-10-21 20:09 ` [PATCH net-next 3/4] flow_dissector: extract more ICMP information Matteo Croce
2019-10-23 10:00   ` Simon Horman
2019-10-23 10:53     ` Matteo Croce
2019-10-23 17:55       ` Simon Horman
2019-10-25  0:27         ` Matteo Croce
2019-10-25  6:28           ` Simon Horman
2019-10-25 18:24             ` Matteo Croce
2019-10-26  7:55               ` Simon Horman
2019-10-21 20:09 ` [PATCH net-next 4/4] bonding: balance ICMP echoes in layer3+4 mode Matteo Croce
2019-10-23 10:01   ` Simon Horman
2019-10-23 16:58     ` Matteo Croce
2019-10-23 18:00       ` Simon Horman
2019-10-24 22:05 ` David Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024.150503.272673272041377721.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=andy@greyhouse.net \
    --cc=ast@kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=j.vosburgh@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mcroce@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=paulb@mellanox.com \
    --cc=sdf@google.com \
    --cc=songliubraving@fb.com \
    --cc=vfalico@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.