From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A837CA9EB9 for ; Thu, 24 Oct 2019 01:15:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E7A352084B for ; Thu, 24 Oct 2019 01:15:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392203AbfJXBPz (ORCPT ); Wed, 23 Oct 2019 21:15:55 -0400 Received: from verein.lst.de ([213.95.11.211]:43058 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390315AbfJXBPz (ORCPT ); Wed, 23 Oct 2019 21:15:55 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id B2D1F68BE1; Thu, 24 Oct 2019 03:15:53 +0200 (CEST) Date: Thu, 24 Oct 2019 03:15:53 +0200 From: Christoph Hellwig To: Logan Gunthorpe Cc: linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Max Gurtovoy , Stephen Bates Subject: Re: [PATCH 2/7] nvmet-tcp: Don't set the request's data_len Message-ID: <20191024011553.GB5190@lst.de> References: <20191023163545.4193-1-logang@deltatee.com> <20191023163545.4193-3-logang@deltatee.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191023163545.4193-3-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 23, 2019 at 10:35:40AM -0600, Logan Gunthorpe wrote: > It's not apprporiate for the transports to set the data_len > field of the request which is only used by the core. > > In this case, just use a variable on the stack to store the > length of the sgl for comparison. > > Signed-off-by: Logan Gunthorpe Looks good, Reviewed-by: Christoph Hellwig From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D183CCA9EB9 for ; Thu, 24 Oct 2019 01:15:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7B1F2084B for ; Thu, 24 Oct 2019 01:15:59 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LDLGH9WK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7B1F2084B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DIWUFy0P5qPZ9GyzShIUndVElx+6dwJgBQ7qdbx1kOQ=; b=LDLGH9WK1aGtzS 7j4aNwDhdtqUxVu0rpgeqc3ARlpeLnzn5vO15xyjoAn0xaRlc/bcIBfVHGYFQZQrm8fW5fmn5ZG0J gN/GiZPJ/aMUG6lpuGhm2GA6W39F17VWl9iqgUNKFdPkaOVMOUl36O0S/3SQ5pyxGdn01r6jf2sB7 D258YWv0hJPWBCBG7nzVdV5R0NJw69tNab0RJrJdf7tn79iwaA1yhgi/EvenqC/+vlv+GVrsomtf1 dJolavzYAdNoeFfW4gyc8p/xycsf/FwiO1IIzI21zEzkUdbWABCstm5R2JUYDm8onqh9boL83/u2A mxJXgP41UneXy3PFEmWw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNRjK-0004DC-NM; Thu, 24 Oct 2019 01:15:58 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNRjH-0004CU-Jl for linux-nvme@lists.infradead.org; Thu, 24 Oct 2019 01:15:56 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id B2D1F68BE1; Thu, 24 Oct 2019 03:15:53 +0200 (CEST) Date: Thu, 24 Oct 2019 03:15:53 +0200 From: Christoph Hellwig To: Logan Gunthorpe Subject: Re: [PATCH 2/7] nvmet-tcp: Don't set the request's data_len Message-ID: <20191024011553.GB5190@lst.de> References: <20191023163545.4193-1-logang@deltatee.com> <20191023163545.4193-3-logang@deltatee.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191023163545.4193-3-logang@deltatee.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191023_181555_796791_AE754A46 X-CRM114-Status: UNSURE ( 9.38 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , Chaitanya Kulkarni , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Stephen Bates , Max Gurtovoy , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Oct 23, 2019 at 10:35:40AM -0600, Logan Gunthorpe wrote: > It's not apprporiate for the transports to set the data_len > field of the request which is only used by the core. > > In this case, just use a variable on the stack to store the > length of the sgl for comparison. > > Signed-off-by: Logan Gunthorpe Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme