All of lore.kernel.org
 help / color / mirror / Atom feed
From: Qu Wenruo <wqu@suse.com>
To: linux-btrfs@vger.kernel.org
Subject: [PATCH v2] btrfs: Remove btrfs_bio::flags member
Date: Thu, 24 Oct 2019 09:38:29 +0800	[thread overview]
Message-ID: <20191024013829.17931-1-wqu@suse.com> (raw)

This member is not used by any one, just remove it.

And since it's between two pointers, such removal should save us a
pointer size of the structure.

The last user of btrfs_bio::flags is removed in commit 326e1dbb5736
("block: remove management of bi_remaining when restoring original
bi_end_io").

Signed-off-by: Qu Wenruo <wqu@suse.com>
---
Changelog:
v2:
- Mention the when last user of btrfs_bio::flags is removed.
- Don't mention btrfs_bio::map_type in commit message.
  Since btrfs_bio::flags is for another purpose, it has nothing to do
  with btrfs_bio::map_type.
---
 fs/btrfs/volumes.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/btrfs/volumes.h b/fs/btrfs/volumes.h
index a7da1f3e3627..5acf5c507ec2 100644
--- a/fs/btrfs/volumes.h
+++ b/fs/btrfs/volumes.h
@@ -330,7 +330,6 @@ struct btrfs_bio {
 	u64 map_type; /* get from map_lookup->type */
 	bio_end_io_t *end_io;
 	struct bio *orig_bio;
-	unsigned long flags;
 	void *private;
 	atomic_t error;
 	int max_errors;
-- 
2.23.0


             reply	other threads:[~2019-10-24  1:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24  1:38 Qu Wenruo [this message]
2019-10-24 11:17 ` [PATCH v2] btrfs: Remove btrfs_bio::flags member David Sterba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024013829.17931-1-wqu@suse.com \
    --to=wqu@suse.com \
    --cc=linux-btrfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.