From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1907CA9EB9 for ; Thu, 24 Oct 2019 02:16:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 794BA20856 for ; Thu, 24 Oct 2019 02:16:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="B8SvHU/r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2436824AbfJXCQa (ORCPT ); Wed, 23 Oct 2019 22:16:30 -0400 Received: from bombadil.infradead.org ([198.137.202.133]:42348 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2436605AbfJXCQa (ORCPT ); Wed, 23 Oct 2019 22:16:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=n82/LvZl+GucMZK4YinIAcI1lwtheo/oC9RuQSaBEMw=; b=B8SvHU/rhOG2NTh0SA61tiq9d /tnJ+Pnfo/sCYaSQnLryDLbk+1rrK/SmAQd3WgNQLcZ7DwqzDGBG2mMg4QObmjgvhVa1gpSnTZo/T MdRG+p4o4mSxouvzqD3Zxa/sJBs1yeIWfiJbuntnoyXmhmjn2qHcktB6zH0bb8si41epnCyehBnVg 5aJP+oYOuo5EFYwmpGPWXa4wippARZBVovs68kwbw+NXXmMsZCdb5vkavMox6M/adYn0OKU/0WRVb OrohiMBsAKyzJxA3L3gWuY7NZRpkuW8v4tRtHZMOTo05gMp+AUh7bS5kexyR4NrOJtDqQytRomB+3 jrn0SJR6w==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNSfp-0002vA-89; Thu, 24 Oct 2019 02:16:25 +0000 Date: Wed, 23 Oct 2019 19:16:25 -0700 From: Christoph Hellwig To: Jason Gunthorpe Cc: Jerome Glisse , "christian.koenig@amd.com" , Andrea Arcangeli , "Yang, Philip" , Ralph Campbell , "linux-rdma@vger.kernel.org" , John Hubbard , "Kuehling, Felix" , "amd-gfx@lists.freedesktop.org" , "linux-mm@kvack.org" , "dri-devel@lists.freedesktop.org" , Ben Skeggs Subject: Re: [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking Message-ID: <20191024021625.GA5893@infradead.org> References: <20191021135744.GA25164@mellanox.com> <20191021151221.GC25164@mellanox.com> <20191022075735.GV11828@phenom.ffwll.local> <20191022150109.GF22766@mellanox.com> <20191023090858.GV11828@phenom.ffwll.local> <13edf841-421e-3522-fcec-ef919c2013ef@gmail.com> <20191023165223.GA4163@redhat.com> <20191023172442.GX22766@mellanox.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191023172442.GX22766@mellanox.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-rdma-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org On Wed, Oct 23, 2019 at 05:24:45PM +0000, Jason Gunthorpe wrote: > mlx5 is similar, but not currently coded quite right, there is one > lock that protects the command queue for submitting invalidations to > the HW and it doesn't make a lot of sense to have additional fine > grained locking beyond that. IFF all drivers could agree on a lock type (rw_semaphore?) for this protection you could add a pointer to the range which would clear things up a lot. I'm just not sure you could get everyone to agree. From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking Date: Wed, 23 Oct 2019 19:16:25 -0700 Message-ID: <20191024021625.GA5893@infradead.org> References: <20191021135744.GA25164@mellanox.com> <20191021151221.GC25164@mellanox.com> <20191022075735.GV11828@phenom.ffwll.local> <20191022150109.GF22766@mellanox.com> <20191023090858.GV11828@phenom.ffwll.local> <13edf841-421e-3522-fcec-ef919c2013ef@gmail.com> <20191023165223.GA4163@redhat.com> <20191023172442.GX22766@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20191023172442.GX22766-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Jason Gunthorpe Cc: Andrea Arcangeli , "Yang, Philip" , Ralph Campbell , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , John Hubbard , "Kuehling, Felix" , "amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" , Jerome Glisse , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "christian.koenig-5C7GfCeVMHo@public.gmane.org" , Ben Skeggs List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCBPY3QgMjMsIDIwMTkgYXQgMDU6MjQ6NDVQTSArMDAwMCwgSmFzb24gR3VudGhvcnBl IHdyb3RlOgo+IG1seDUgaXMgc2ltaWxhciwgYnV0IG5vdCBjdXJyZW50bHkgY29kZWQgcXVpdGUg cmlnaHQsIHRoZXJlIGlzIG9uZQo+IGxvY2sgdGhhdCBwcm90ZWN0cyB0aGUgY29tbWFuZCBxdWV1 ZSBmb3Igc3VibWl0dGluZyBpbnZhbGlkYXRpb25zIHRvCj4gdGhlIEhXIGFuZCBpdCBkb2Vzbid0 IG1ha2UgYSBsb3Qgb2Ygc2Vuc2UgdG8gaGF2ZSBhZGRpdGlvbmFsIGZpbmUKPiBncmFpbmVkIGxv Y2tpbmcgYmV5b25kIHRoYXQuCgpJRkYgYWxsIGRyaXZlcnMgY291bGQgYWdyZWUgb24gYSBsb2Nr IHR5cGUgKHJ3X3NlbWFwaG9yZT8pIGZvciB0aGlzCnByb3RlY3Rpb24geW91IGNvdWxkIGFkZCBh IHBvaW50ZXIgdG8gdGhlIHJhbmdlIHdoaWNoIHdvdWxkIGNsZWFyCnRoaW5ncyB1cCBhIGxvdC4g IEknbSBqdXN0IG5vdCBzdXJlIHlvdSBjb3VsZCBnZXQgZXZlcnlvbmUgdG8KYWdyZWUuCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGlu ZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02BD0CA9EAF for ; Thu, 24 Oct 2019 07:31:08 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5F6020856 for ; Thu, 24 Oct 2019 07:31:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5F6020856 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=amd-gfx-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B8A96E112; Thu, 24 Oct 2019 07:31:06 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:e::133]) by gabe.freedesktop.org (Postfix) with ESMTPS id 429E56E064; Thu, 24 Oct 2019 02:16:31 +0000 (UTC) Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNSfp-0002vA-89; Thu, 24 Oct 2019 02:16:25 +0000 Date: Wed, 23 Oct 2019 19:16:25 -0700 From: Christoph Hellwig To: Jason Gunthorpe Subject: Re: [PATCH hmm 00/15] Consolidate the mmu notifier interval_tree and locking Message-ID: <20191024021625.GA5893@infradead.org> References: <20191021135744.GA25164@mellanox.com> <20191021151221.GC25164@mellanox.com> <20191022075735.GV11828@phenom.ffwll.local> <20191022150109.GF22766@mellanox.com> <20191023090858.GV11828@phenom.ffwll.local> <13edf841-421e-3522-fcec-ef919c2013ef@gmail.com> <20191023165223.GA4163@redhat.com> <20191023172442.GX22766@mellanox.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191023172442.GX22766@mellanox.com> User-Agent: Mutt/1.12.1 (2019-06-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Mailman-Approved-At: Thu, 24 Oct 2019 07:31:04 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=n82/LvZl+GucMZK4YinIAcI1lwtheo/oC9RuQSaBEMw=; b=B8SvHU/rhOG2NTh0SA61tiq9d /tnJ+Pnfo/sCYaSQnLryDLbk+1rrK/SmAQd3WgNQLcZ7DwqzDGBG2mMg4QObmjgvhVa1gpSnTZo/T MdRG+p4o4mSxouvzqD3Zxa/sJBs1yeIWfiJbuntnoyXmhmjn2qHcktB6zH0bb8si41epnCyehBnVg 5aJP+oYOuo5EFYwmpGPWXa4wippARZBVovs68kwbw+NXXmMsZCdb5vkavMox6M/adYn0OKU/0WRVb OrohiMBsAKyzJxA3L3gWuY7NZRpkuW8v4tRtHZMOTo05gMp+AUh7bS5kexyR4NrOJtDqQytRomB+3 jrn0SJR6w==; X-BeenThere: amd-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Discussion list for AMD gfx List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrea Arcangeli , "Yang, Philip" , Ralph Campbell , "linux-rdma@vger.kernel.org" , John Hubbard , "Kuehling, Felix" , "amd-gfx@lists.freedesktop.org" , "linux-mm@kvack.org" , Jerome Glisse , "dri-devel@lists.freedesktop.org" , "christian.koenig@amd.com" , Ben Skeggs Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: amd-gfx-bounces@lists.freedesktop.org Sender: "amd-gfx" Message-ID: <20191024021625.T4GvV1dcH0SpS81Gh1i9TdprdBeEYFbBg8lnGKK_8fE@z> T24gV2VkLCBPY3QgMjMsIDIwMTkgYXQgMDU6MjQ6NDVQTSArMDAwMCwgSmFzb24gR3VudGhvcnBl IHdyb3RlOgo+IG1seDUgaXMgc2ltaWxhciwgYnV0IG5vdCBjdXJyZW50bHkgY29kZWQgcXVpdGUg cmlnaHQsIHRoZXJlIGlzIG9uZQo+IGxvY2sgdGhhdCBwcm90ZWN0cyB0aGUgY29tbWFuZCBxdWV1 ZSBmb3Igc3VibWl0dGluZyBpbnZhbGlkYXRpb25zIHRvCj4gdGhlIEhXIGFuZCBpdCBkb2Vzbid0 IG1ha2UgYSBsb3Qgb2Ygc2Vuc2UgdG8gaGF2ZSBhZGRpdGlvbmFsIGZpbmUKPiBncmFpbmVkIGxv Y2tpbmcgYmV5b25kIHRoYXQuCgpJRkYgYWxsIGRyaXZlcnMgY291bGQgYWdyZWUgb24gYSBsb2Nr IHR5cGUgKHJ3X3NlbWFwaG9yZT8pIGZvciB0aGlzCnByb3RlY3Rpb24geW91IGNvdWxkIGFkZCBh IHBvaW50ZXIgdG8gdGhlIHJhbmdlIHdoaWNoIHdvdWxkIGNsZWFyCnRoaW5ncyB1cCBhIGxvdC4g IEknbSBqdXN0IG5vdCBzdXJlIHlvdSBjb3VsZCBnZXQgZXZlcnlvbmUgdG8KYWdyZWUuCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmFtZC1nZnggbWFpbGlu ZyBsaXN0CmFtZC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vYW1kLWdmeA==