All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Jones <drjones@redhat.com>
To: kvm@vger.kernel.org
Cc: pbonzini@redhat.com, Andre Przywara <andre.przywara@arm.com>
Subject: [PULL 06/10] arm: Add missing test name prefix calls
Date: Thu, 24 Oct 2019 15:06:57 +0200	[thread overview]
Message-ID: <20191024130701.31238-7-drjones@redhat.com> (raw)
In-Reply-To: <20191024130701.31238-1-drjones@redhat.com>

From: Andre Przywara <andre.przywara@arm.com>

When running the unit tests in TAP mode (./run_tests.sh -t), every single
test result is printed. This works fine for most tests which use the
reporting prefix feature to indicate the actual test name.
However psci and pci were missing those names, so the reporting left
people scratching their head what was actually tested:
...
ok 74 - invalid-function
ok 75 - affinity-info-on
ok 76 - affinity-info-off
ok 77 - cpu-on

Push a "psci" prefix before running those tests to make those report
lines more descriptive.
While at it, do the same for pci, even though it is less ambigious there.
Also the GIC ITARGETSR test was missing a report_prefix_pop().

Signed-off-by: Andre Przywara <andre.przywara@arm.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Andrew Jones <drjones@redhat.com>
---
 arm/gic.c      | 2 ++
 arm/pci-test.c | 2 ++
 arm/psci.c     | 2 ++
 3 files changed, 6 insertions(+)

diff --git a/arm/gic.c b/arm/gic.c
index 02d292807c9b..adb6aa464513 100644
--- a/arm/gic.c
+++ b/arm/gic.c
@@ -480,6 +480,8 @@ static void test_targets(int nr_irqs)
 	test_byte_access(targetsptr + GIC_FIRST_SPI, pattern, cpu_mask);
 
 	writel(orig_targets, targetsptr + GIC_FIRST_SPI);
+
+	report_prefix_pop();
 }
 
 static void gic_test_mmio(void)
diff --git a/arm/pci-test.c b/arm/pci-test.c
index cf128ac1b032..7c3836e5cd63 100644
--- a/arm/pci-test.c
+++ b/arm/pci-test.c
@@ -19,6 +19,8 @@ int main(void)
 		return report_summary();
 	}
 
+	report_prefix_push("pci");
+
 	pci_print();
 
 	ret = pci_testdev();
diff --git a/arm/psci.c b/arm/psci.c
index 5cb4d5c7c233..536c9b742033 100644
--- a/arm/psci.c
+++ b/arm/psci.c
@@ -126,6 +126,8 @@ int main(void)
 {
 	int ver = psci_invoke(PSCI_0_2_FN_PSCI_VERSION, 0, 0, 0);
 
+	report_prefix_push("psci");
+
 	if (nr_cpus < 2) {
 		report_skip("At least 2 cpus required");
 		goto done;
-- 
2.21.0


  parent reply	other threads:[~2019-10-24 13:07 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-24 13:06 [PULL kvm-unit-tests 00/10] arm/arm64 updates Andrew Jones
2019-10-24 13:06 ` [PULL 01/10] arm: gic: check_acked: add test description Andrew Jones
2019-10-24 13:06 ` [PULL 02/10] arm: gic: Split variable output data from test name Andrew Jones
2019-10-24 13:06 ` [PULL 03/10] arm: timer: " Andrew Jones
2019-10-24 13:06 ` [PULL 04/10] arm: selftest: " Andrew Jones
2019-10-24 13:06 ` [PULL 05/10] arm: selftest: Make MPIDR output stable Andrew Jones
2019-10-24 13:06 ` Andrew Jones [this message]
2019-10-24 13:06 ` [PULL 07/10] lib: arm64: Add missing ISB in flush_tlb_page Andrew Jones
2019-10-24 13:06 ` [PULL 08/10] lib: arm/arm64: Add function to clear the PTE_USER bit Andrew Jones
2019-10-24 13:07 ` [PULL 09/10] arm64: Add cache code generation test Andrew Jones
2019-10-24 13:07 ` [PULL 10/10] arm: Add PL031 test Andrew Jones
2019-10-24 20:30 ` [PULL kvm-unit-tests 00/10] arm/arm64 updates Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191024130701.31238-7-drjones@redhat.com \
    --to=drjones@redhat.com \
    --cc=andre.przywara@arm.com \
    --cc=kvm@vger.kernel.org \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.