From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A2BCCA9EBC for ; Thu, 24 Oct 2019 16:41:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2939E21906 for ; Thu, 24 Oct 2019 16:41:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407572AbfJXQk7 (ORCPT ); Thu, 24 Oct 2019 12:40:59 -0400 Received: from foss.arm.com ([217.140.110.172]:56418 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2405516AbfJXQkt (ORCPT ); Thu, 24 Oct 2019 12:40:49 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CF60232B; Thu, 24 Oct 2019 09:35:19 -0700 (PDT) Received: from bogus (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E738E3F71F; Thu, 24 Oct 2019 09:35:17 -0700 (PDT) Date: Thu, 24 Oct 2019 17:35:15 +0100 From: Sudeep Holla To: Ulf Hansson Cc: "Rafael J . Wysocki" , Daniel Lezcano , Lorenzo Pieralisi , Mark Rutland , Lina Iyer , linux-pm@vger.kernel.org, Rob Herring , Vincent Guittot , Stephen Boyd , Sudeep Holla , Bjorn Andersson , Kevin Hilman , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: Re: [PATCH 11/13] cpuidle: psci: Attach CPU devices to their PM domains Message-ID: <20191024163515.GD22036@bogus> References: <20191010113937.15962-1-ulf.hansson@linaro.org> <20191010113937.15962-12-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191010113937.15962-12-ulf.hansson@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Thu, Oct 10, 2019 at 01:39:35PM +0200, Ulf Hansson wrote: > In order to enable a CPU to be power managed through its PM domain, let's > try to attach it by calling psci_dt_attach_cpu() during the cpuidle > initialization. > > psci_dt_attach_cpu() returns a pointer to the attached struct device, which > later should be used for runtime PM, hence we need to store it somewhere. > Rather than adding yet another per CPU variable, let's create a per CPU > struct to collect the relevant per CPU variables. > > Signed-off-by: Ulf Hansson > --- > drivers/cpuidle/cpuidle-psci.c | 23 +++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle-psci.c b/drivers/cpuidle/cpuidle-psci.c > index a16467daf99d..1510422c7a53 100644 > --- a/drivers/cpuidle/cpuidle-psci.c > +++ b/drivers/cpuidle/cpuidle-psci.c > @@ -23,7 +23,12 @@ > #include "cpuidle-psci.h" > #include "dt_idle_states.h" > > -static DEFINE_PER_CPU_READ_MOSTLY(u32 *, psci_power_state); > +struct psci_cpuidle_data { > + u32 *psci_states; > + struct device *dev; > +}; > + > +static DEFINE_PER_CPU_READ_MOSTLY(struct psci_cpuidle_data, psci_cpuidle_data); > static DEFINE_PER_CPU(u32, domain_state); > /me just thinking still: If it make sense to keep psci_states separate and domain_state and only other things needed for RPM/OSI in the structure. I do understand that we modify domain_state and hence we can't use READ_MOSTLY then. Let's see, for now keep it as is, thought I will think out aloud. -- Regards, Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C772CA9EAF for ; Thu, 24 Oct 2019 16:35:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F386121A4A for ; Thu, 24 Oct 2019 16:35:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="jb5suj0M" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F386121A4A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7pforWXfhGdPO2y6Z7Y8otPyK3JMSSXvMDxWl9XtrSA=; b=jb5suj0M0ynSD2 aJLwxUQvoJcdAxBd/4zeT1EC/W2pxyOu8guo6QL0vfVxLTWV1jxyS6N7BxEa0wYFB38ZufhFf3DTY g+XHLa4a7BpZQ/6FKKmv4woTywFsgj4OmAB4Wpsdms/xQ1JYS4PlgcXQ0Qkhs6fYawkdG6pDfVGV1 ANF02AbeuCUpVPseur4KQypnqOcYUNDIzHtS0BGvS4PW9TQFmPhjid5CtXarhfRbskikFsPTHx6it FA5gLh/SWeKsxRbwm5ye/2w/z79/HP3IwSF6unAy3g0FZPbGfEbtY0/Yo4RqeExK+vK88DTjbgSTq hDxvTe6hj8jiT/Ealw5A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNg5F-0004G0-T0; Thu, 24 Oct 2019 16:35:33 +0000 Received: from [217.140.110.172] (helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iNg5C-0004Ed-Jd for linux-arm-kernel@lists.infradead.org; Thu, 24 Oct 2019 16:35:32 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id CF60232B; Thu, 24 Oct 2019 09:35:19 -0700 (PDT) Received: from bogus (e107155-lin.cambridge.arm.com [10.1.196.42]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id E738E3F71F; Thu, 24 Oct 2019 09:35:17 -0700 (PDT) Date: Thu, 24 Oct 2019 17:35:15 +0100 From: Sudeep Holla To: Ulf Hansson Subject: Re: [PATCH 11/13] cpuidle: psci: Attach CPU devices to their PM domains Message-ID: <20191024163515.GD22036@bogus> References: <20191010113937.15962-1-ulf.hansson@linaro.org> <20191010113937.15962-12-ulf.hansson@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191010113937.15962-12-ulf.hansson@linaro.org> User-Agent: Mutt/1.9.4 (2018-02-28) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191024_093530_692715_8A69AC78 X-CRM114-Status: GOOD ( 15.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Lorenzo Pieralisi , linux-pm@vger.kernel.org, Stephen Boyd , linux-arm-msm@vger.kernel.org, Daniel Lezcano , "Rafael J . Wysocki" , Lina Iyer , Bjorn Andersson , Kevin Hilman , Rob Herring , Sudeep Holla , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 10, 2019 at 01:39:35PM +0200, Ulf Hansson wrote: > In order to enable a CPU to be power managed through its PM domain, let's > try to attach it by calling psci_dt_attach_cpu() during the cpuidle > initialization. > > psci_dt_attach_cpu() returns a pointer to the attached struct device, which > later should be used for runtime PM, hence we need to store it somewhere. > Rather than adding yet another per CPU variable, let's create a per CPU > struct to collect the relevant per CPU variables. > > Signed-off-by: Ulf Hansson > --- > drivers/cpuidle/cpuidle-psci.c | 23 +++++++++++++++++++---- > 1 file changed, 19 insertions(+), 4 deletions(-) > > diff --git a/drivers/cpuidle/cpuidle-psci.c b/drivers/cpuidle/cpuidle-psci.c > index a16467daf99d..1510422c7a53 100644 > --- a/drivers/cpuidle/cpuidle-psci.c > +++ b/drivers/cpuidle/cpuidle-psci.c > @@ -23,7 +23,12 @@ > #include "cpuidle-psci.h" > #include "dt_idle_states.h" > > -static DEFINE_PER_CPU_READ_MOSTLY(u32 *, psci_power_state); > +struct psci_cpuidle_data { > + u32 *psci_states; > + struct device *dev; > +}; > + > +static DEFINE_PER_CPU_READ_MOSTLY(struct psci_cpuidle_data, psci_cpuidle_data); > static DEFINE_PER_CPU(u32, domain_state); > /me just thinking still: If it make sense to keep psci_states separate and domain_state and only other things needed for RPM/OSI in the structure. I do understand that we modify domain_state and hence we can't use READ_MOSTLY then. Let's see, for now keep it as is, thought I will think out aloud. -- Regards, Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel