All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Stanley <joel@jms.id.au>
To: Jeremy Kerr <jk@ozlabs.org>, Andrew Jeffery <andrew@aj.id.au>
Cc: openbmc@lists.ozlabs.org
Subject: [PATCH linux dev-5.3 2/7] fsi: master: Change default divisor to 14
Date: Fri, 25 Oct 2019 12:03:46 +1100	[thread overview]
Message-ID: <20191025010351.30298-3-joel@jms.id.au> (raw)
In-Reply-To: <20191025010351.30298-1-joel@jms.id.au>

We were running at 127, which equates to a bus clock speed of approx
1.4MHz. This changes that to approx 14MHz, which works on the EVB and is
reliable on the Tacoma systems.

Signed-off-by: Joel Stanley <joel@jms.id.au>
---
 drivers/fsi/fsi-master-aspeed.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/fsi/fsi-master-aspeed.c b/drivers/fsi/fsi-master-aspeed.c
index 59537cab4f68..bef7690a0ddf 100644
--- a/drivers/fsi/fsi-master-aspeed.c
+++ b/drivers/fsi/fsi-master-aspeed.c
@@ -76,6 +76,8 @@
 
 #define FSI_NUM_DEBUGFS_ENTRIES		17
 
+#define DEFAULT_DIVISOR			14
+
 struct fsi_master_aspeed;
 
 struct fsi_master_aspeed_debugfs_entry {
@@ -441,7 +443,8 @@ static int aspeed_master_init(struct fsi_master_aspeed *aspeed)
 	opb_write(aspeed->base, ctrl_base + FSI_MECTRL, reg, 4);
 
 	reg = cpu_to_be32(FSI_MMODE_ECRC | FSI_MMODE_EPC
-			| fsi_mmode_crs0(0x7f) | fsi_mmode_crs1(0x7f)
+			| fsi_mmode_crs0(DEFAULT_DIVISOR)
+			| fsi_mmode_crs1(DEFAULT_DIVISOR)
 			| FSI_MMODE_P8_TO_LSB);
 	opb_write(aspeed->base, ctrl_base + FSI_MMODE, reg, 4);
 
-- 
2.23.0

  parent reply	other threads:[~2019-10-25  1:04 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25  1:03 [PATCH linux dev-5.3 0/7] AST2600 FSI speed improvements Joel Stanley
2019-10-25  1:03 ` [PATCH linux dev-5.3 1/7] fsi: aspeed: busy loop in the write case Joel Stanley
2019-10-25  1:52   ` Andrew Jeffery
2019-10-25  1:03 ` Joel Stanley [this message]
2019-10-25  1:56   ` [PATCH linux dev-5.3 2/7] fsi: master: Change default divisor to 14 Andrew Jeffery
2019-10-25  1:03 ` [PATCH linux dev-5.3 3/7] fsi: aspeed: Enable relative addressing Joel Stanley
2019-10-25  1:57   ` Andrew Jeffery
2019-10-25  1:03 ` [PATCH linux dev-5.3 4/7] fsi: aspeed: Only select OPB0 once Joel Stanley
2019-10-25  1:59   ` Andrew Jeffery
2019-10-25  1:03 ` [PATCH linux dev-5.3 5/7] fsi: aspeed: Avoid copying read data twice Joel Stanley
2019-10-25  2:09   ` Andrew Jeffery
2019-10-25  1:03 ` [PATCH linux dev-5.3 6/7] fsi: aspeed: Pass fsi_master_aspeed insead of base Joel Stanley
2019-10-25  1:03 ` [PATCH linux dev-5.3 7/7] fsi: aspeed: Special case repeated full word reads Joel Stanley
2019-10-29  3:16   ` Jeremy Kerr
2019-10-29  3:53     ` Joel Stanley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191025010351.30298-3-joel@jms.id.au \
    --to=joel@jms.id.au \
    --cc=andrew@aj.id.au \
    --cc=jk@ozlabs.org \
    --cc=openbmc@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.