Re: [RFC PATCH 2/2] tee: add AMD-TEE driver

[kbuild test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3254 bytes --]

Hi Rijo-john",

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on linus/master]
[cannot apply to v5.4-rc4 next-20191024]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Thomas-Rijo-john/TEE-driver-for-AMD-APUs/20191025-081700
base:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 39a38bcba4ab6e5285b07675b0e42c96eec35e67
config: x86_64-allyesconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-14) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers//tee/amdtee/shm_pool.c: In function 'amdtee_config_shm':
>> drivers//tee/amdtee/shm_pool.c:128:2: warning: 'dmabuf_mgr' may be used uninitialized in this function [-Wmaybe-uninitialized]
     kfree(dmabuf_mgr);
     ^~~~~~~~~~~~~~~~~
>> drivers//tee/amdtee/shm_pool.c:127:2: warning: 'priv_mgr' may be used uninitialized in this function [-Wmaybe-uninitialized]
     kfree(priv_mgr);
     ^~~~~~~~~~~~~~~

vim +/dmabuf_mgr +128 drivers//tee/amdtee/shm_pool.c

    77	
    78	struct tee_shm_pool *amdtee_config_shm(void)
    79	{
    80		struct tee_shm_pool *pool = NULL;
    81		struct tee_shm_pool_mgr *priv_mgr;
    82		struct tee_shm_pool_mgr *dmabuf_mgr;
    83		int ret;
    84	
    85		pool = kzalloc(sizeof(*pool), GFP_KERNEL);
    86		if (!pool) {
    87			ret = -ENOMEM;
    88			goto err;
    89		}
    90	
    91		priv_mgr = kzalloc(sizeof(*priv_mgr), GFP_KERNEL);
    92		if (!priv_mgr) {
    93			ret = -ENOMEM;
    94			goto err;
    95		}
    96	
    97		dmabuf_mgr = kzalloc(sizeof(*dmabuf_mgr), GFP_KERNEL);
    98		if (!dmabuf_mgr) {
    99			ret = -ENOMEM;
   100			goto err;
   101		}
   102	
   103		pool->private_mgr = priv_mgr;
   104		pool->dma_buf_mgr = dmabuf_mgr;
   105		/*
   106		 * Initialize memory manager for driver private shared memory
   107		 */
   108		ret = pool_mem_mgr_init(pool->private_mgr, 3 /* 8 byte aligned */);
   109		if (ret)
   110			goto err;
   111	
   112		/*
   113		 * Initialize memory manager for dma_buf shared memory
   114		 */
   115		ret = pool_mem_mgr_init(pool->dma_buf_mgr, PAGE_SHIFT);
   116		if (ret)
   117			goto err;
   118	
   119		return pool;
   120	err:
   121		if (ret == -ENOMEM)
   122			pr_err("%s: failed to configure shared memory pool\n",
   123			       __func__);
   124		if (pool && pool->private_mgr->private_data)
   125			kfree(pool->private_mgr->private_data);
   126		kfree(pool);
 > 127		kfree(priv_mgr);
 > 128		kfree(dmabuf_mgr);

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 70234 bytes --]