From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A5B47CA9EA0 for ; Fri, 25 Oct 2019 18:10:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 768A021D7F for ; Fri, 25 Oct 2019 18:10:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="TkkERhIk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388096AbfJYSKj (ORCPT ); Fri, 25 Oct 2019 14:10:39 -0400 Received: from mail.andi.de1.cc ([85.214.55.253]:58994 "EHLO mail.andi.de1.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732355AbfJYSIC (ORCPT ); Fri, 25 Oct 2019 14:08:02 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ukusdiIWPioOyFF8K+EMog1oWe2UbKn/QGBiyiSBlcI=; b=TkkERhIk8BBAwoGeaxAN1ziqjG l+PP57GcZFlFrZe+8Ex1cit7g7VgrEpsXkPptk1n8IbWDzMu4ghOXS5+62xp6kJ68ILnVYvF6h+T/ HtNN8wIp29Z8E9XjPQBeBDXoJGiW4TzIZZPdYPZ+jLas/GjF5jghcn34foMfTYFkiKO8=; Received: from p200300ccff09ca001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff09:ca00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iO401-0005qr-ID; Fri, 25 Oct 2019 20:07:45 +0200 Date: Fri, 25 Oct 2019 20:07:43 +0200 From: Andreas Kemnade To: Shawn Guo Cc: robh+dt@kernel.org, mark.rutland@arm.com, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, manivannan.sadhasivam@linaro.org, andrew.smirnov@gmail.com, marex@denx.de, angus@akkea.ca, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, j.neuschaefer@gmx.net, Discussions about the Letux Kernel , Marco Felsch Subject: Re: [PATCH v3 3/3] ARM: dts: imx: add devicetree for Kobo Clara HD Message-ID: <20191025200743.48455cc9@aktux> In-Reply-To: <20191025134621.GN3208@dragon> References: <20191010192357.27884-1-andreas@kemnade.info> <20191010192357.27884-4-andreas@kemnade.info> <20191025134621.GN3208@dragon> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On Fri, 25 Oct 2019 21:46:24 +0800 Shawn Guo wrote: [...] > > + > > + pinctrl_wifi_reset: wifi_reset_grp { > > + fsl,pins = < > > + MX6SLL_PAD_SD2_DATA7__GPIO5_IO00 0x10059 /* WIFI_RST */ > > + >; > > + }; > > + > > + pinctrl_wifi_power: wifi_power_grp { > > I guess you can have one pinctrl node to include both reset and power > pins? Also, to be consistent with other pinctrl nodes on naming, the > node name should probably be wifigrp. > well, the problems they are used in different nodes, so I cannot do that: reg_wifi: regulator-wifi { compatible = "regulator-fixed"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_wifi_power>; regulator-name = "SD3_SPWR"; regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>; enable-active-high; }; wifi_pwrseq: wifi_pwrseq { compatible = "mmc-pwrseq-simple"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_wifi_reset>; post-power-on-delay-ms = <20>; reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; }; So having them combined breaks the mux where you use it rule. I got in earlier mails: > > + wifi_pwrseq: wifi_pwrseq { > > + compatible = "mmc-pwrseq-simple"; > > + post-power-on-delay-ms = <20>; > > + reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; > Can you add a pinctrl-entry here please? The general rule is to mux > things where you use it [...] > > + compatible = "regulator-fixed"; > > + regulator-name = "SD3_SPWR"; > > + regulator-min-microvolt = <3000000>; > > + regulator-max-microvolt = <3000000>; > > + > > + gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>; > Please add a pinctrl here to mux this gpio. Regards, Andreas From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4F47CA9EBC for ; Fri, 25 Oct 2019 18:08:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B691821D7F for ; Fri, 25 Oct 2019 18:08:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="XOVUFkXw"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kemnade.info header.i=@kemnade.info header.b="TkkERhIk" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B691821D7F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kemnade.info Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ucXP+Zrfl1Uy1Jy4XKtmX0LM5qZabvYu4ZpQ+KViVxo=; b=XOVUFkXww8b7g3 Spu+8oA5sjRPLDPj/tn/6rdV/qJ7EWq++A3TS+vm/FQS3NQdf+tD8faML4iD2jZUCpDWa9wsiQ0QW YSb/fCaVRUM750z4uvkOAIuUr0tnBz8ibnXpXf/N6yIH5ncjbhYi9O/NgQxcow3dZKpQmiMHeyBhb tmTmrp6i1zV+dJXWP2Ay/w8bk3Ofr7Fm58HpzBbSNJGkAkBLvkOqv58plmv7rUDc5MEqoiv+v9KSH M8g4FbJebY+A+sqcetg46aDRwgrLfELRTVUqgubyN0iT9LI2ZcAgukHq7mfJiOTI7semxa1f0TXOd 5z2SmjMapF8gBCltylEQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iO40Q-0003X4-4L; Fri, 25 Oct 2019 18:08:10 +0000 Received: from mail.andi.de1.cc ([2a01:238:4321:8900:456f:ecd6:43e:202c]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iO40L-0003Vp-Sm for linux-arm-kernel@lists.infradead.org; Fri, 25 Oct 2019 18:08:07 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=kemnade.info; s=20180802; h=Content-Transfer-Encoding:Content-Type: MIME-Version:References:In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=ukusdiIWPioOyFF8K+EMog1oWe2UbKn/QGBiyiSBlcI=; b=TkkERhIk8BBAwoGeaxAN1ziqjG l+PP57GcZFlFrZe+8Ex1cit7g7VgrEpsXkPptk1n8IbWDzMu4ghOXS5+62xp6kJ68ILnVYvF6h+T/ HtNN8wIp29Z8E9XjPQBeBDXoJGiW4TzIZZPdYPZ+jLas/GjF5jghcn34foMfTYFkiKO8=; Received: from p200300ccff09ca001a3da2fffebfd33a.dip0.t-ipconnect.de ([2003:cc:ff09:ca00:1a3d:a2ff:febf:d33a] helo=aktux) by mail.andi.de1.cc with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iO401-0005qr-ID; Fri, 25 Oct 2019 20:07:45 +0200 Date: Fri, 25 Oct 2019 20:07:43 +0200 From: Andreas Kemnade To: Shawn Guo Subject: Re: [PATCH v3 3/3] ARM: dts: imx: add devicetree for Kobo Clara HD Message-ID: <20191025200743.48455cc9@aktux> In-Reply-To: <20191025134621.GN3208@dragon> References: <20191010192357.27884-1-andreas@kemnade.info> <20191010192357.27884-4-andreas@kemnade.info> <20191025134621.GN3208@dragon> X-Mailer: Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191025_110806_232622_3B6B7473 X-CRM114-Status: GOOD ( 13.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, marex@denx.de, Marco Felsch , devicetree@vger.kernel.org, andrew.smirnov@gmail.com, s.hauer@pengutronix.de, angus@akkea.ca, linux-kernel@vger.kernel.org, j.neuschaefer@gmx.net, robh+dt@kernel.org, linux-imx@nxp.com, kernel@pengutronix.de, manivannan.sadhasivam@linaro.org, Discussions about the Letux Kernel , festevam@gmail.com, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi, On Fri, 25 Oct 2019 21:46:24 +0800 Shawn Guo wrote: [...] > > + > > + pinctrl_wifi_reset: wifi_reset_grp { > > + fsl,pins = < > > + MX6SLL_PAD_SD2_DATA7__GPIO5_IO00 0x10059 /* WIFI_RST */ > > + >; > > + }; > > + > > + pinctrl_wifi_power: wifi_power_grp { > > I guess you can have one pinctrl node to include both reset and power > pins? Also, to be consistent with other pinctrl nodes on naming, the > node name should probably be wifigrp. > well, the problems they are used in different nodes, so I cannot do that: reg_wifi: regulator-wifi { compatible = "regulator-fixed"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_wifi_power>; regulator-name = "SD3_SPWR"; regulator-min-microvolt = <3000000>; regulator-max-microvolt = <3000000>; gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>; enable-active-high; }; wifi_pwrseq: wifi_pwrseq { compatible = "mmc-pwrseq-simple"; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_wifi_reset>; post-power-on-delay-ms = <20>; reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; }; So having them combined breaks the mux where you use it rule. I got in earlier mails: > > + wifi_pwrseq: wifi_pwrseq { > > + compatible = "mmc-pwrseq-simple"; > > + post-power-on-delay-ms = <20>; > > + reset-gpios = <&gpio5 0 GPIO_ACTIVE_LOW>; > Can you add a pinctrl-entry here please? The general rule is to mux > things where you use it [...] > > + compatible = "regulator-fixed"; > > + regulator-name = "SD3_SPWR"; > > + regulator-min-microvolt = <3000000>; > > + regulator-max-microvolt = <3000000>; > > + > > + gpio = <&gpio4 29 GPIO_ACTIVE_HIGH>; > Please add a pinctrl here to mux this gpio. Regards, Andreas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel