All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH 0/3] Fixes to recent updates in count
Date: Sat, 26 Oct 2019 16:04:24 -0700	[thread overview]
Message-ID: <20191026230424.GF4465@paulmck-ThinkPad-P72> (raw)
In-Reply-To: <74f205ba-a530-288b-d211-8ef8db70f365@gmail.com>

On Sat, Oct 26, 2019 at 09:18:27AM +0900, Akira Yokosawa wrote:
> Hi Paul,
> 
> So you had (or still have?) a chance to run the parallel count algorithms
> on the large x86 (224-core with HT) system. Interesting data.

Yes, but access is still a bit patchy.  I probably should have waited,
but I was too pleased to have large-scale data.  What can I say?  ;-)

> This patch set is to adjust a few contexts with existing contents.
> 
> Patch #1 adjusts horizontal spacing of tables getting wider than 1c
> column width.

Good point -- I should have checked, thank you for catching this!
Would it make sense to rotate the "Exact?" heading 90 degrees and
to put the "(ns)" underneath the "Updates"?  Those two changes
might make Figure 5.2 fit horizontally.

> Patch #2 adds a dashed line mentioned in Quick Quiz 5.8.
> Patch #3 substitutes "x86" for "POWER6".

Good catches, all three queued and pushed, thank you!

> If you have conflicting local updates, I'd be happy to rebase.

No problem, as my updates didn't conflict.  Sometimes we get lucky.  ;-)

> Also, you might want to add a Quick Quiz on the slope changes in
> Figure 5.1 at number of CPUs 2 and 28. I think you know what I mean.

You are right, that would be good.  I believe that at least some of
the change in slope is due to hyperthreading, but I do not believe that
this is the only effect.  But I need to get the system into better shape
before I will be able to track this down, which might be a few weeks.

If I forget, please feel free to remind me again, though!

							Thanx, Paul

>         Thanks, Akira
> --
> Akira Yokosawa (3):
>   count: Tweak horizontal spacing of wide tables in 1c layout
>   count: Add dashed line indicating ideal time of (non-atomic) increment
>   count: Update CPU type/system
> 
>  CodeSamples/count/atomic_hps.eps | 111 ++++++++++++++++++++++++++++++-
>  CodeSamples/count/atomic_hps.png | Bin 3113 -> 3120 bytes
>  CodeSamples/count/plots.sh       |   2 +-
>  count/count.tex                  |  12 ++--
>  4 files changed, 117 insertions(+), 8 deletions(-)
> 
> -- 
> 2.17.1
> 

  parent reply	other threads:[~2019-10-26 23:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-26  0:18 [PATCH 0/3] Fixes to recent updates in count Akira Yokosawa
2019-10-26  0:19 ` [PATCH 1/3] count: Tweak horizontal spacing of wide tables in 1c layout Akira Yokosawa
2019-10-26  0:21 ` [PATCH 2/3] count: Add dashed line indicating ideal time of (non-atomic) increment Akira Yokosawa
2019-10-26  0:22 ` [PATCH 3/3] count: Update CPU type/system Akira Yokosawa
2019-10-26 23:04 ` Paul E. McKenney [this message]
2019-10-27 15:24   ` [RFC PATCH] count: Merge tables of statistical and limited counter performance Akira Yokosawa
2019-10-27 17:09     ` Paul E. McKenney
2019-10-28 14:44       ` [PATCH] count: Reduce width of performance table Akira Yokosawa
2019-10-28 18:07         ` Paul E. McKenney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191026230424.GF4465@paulmck-ThinkPad-P72 \
    --to=paulmck@kernel.org \
    --cc=akiyks@gmail.com \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.