From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7248CA9EBC for ; Mon, 28 Oct 2019 07:39:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C64F7214E0 for ; Mon, 28 Oct 2019 07:39:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733015AbfJ1Hj5 (ORCPT ); Mon, 28 Oct 2019 03:39:57 -0400 Received: from verein.lst.de ([213.95.11.211]:33113 "EHLO verein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730952AbfJ1Hj4 (ORCPT ); Mon, 28 Oct 2019 03:39:56 -0400 Received: by verein.lst.de (Postfix, from userid 2407) id 480AA68C65; Mon, 28 Oct 2019 08:39:53 +0100 (CET) Date: Mon, 28 Oct 2019 08:39:53 +0100 From: Christoph Hellwig To: Guenter Roeck Cc: Keith Busch , Chris Healy , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Akinobu Mita , linux-pm@vger.kernel.org Subject: Re: [PATCH] nvme: Add hardware monitoring support Message-ID: <20191028073953.GA20443@lst.de> References: <20191028024156.23964-1-linux@roeck-us.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191028024156.23964-1-linux@roeck-us.net> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Oct 27, 2019 at 07:41:56PM -0700, Guenter Roeck wrote: > nvme devices report temperature information in the controller information > (for limits) and in the smart log. Currently, the only means to retrieve > this information is the nvme command line interface, which requires > super-user privileges. > > At the same time, it would be desirable to use NVME temperature information > for thermal control. > > This patch adds support to read NVME temperatures from the kernel using the > hwmon API and adds temperature zones for NVME drives. The thermal subsystem > can use this information to set thermal policies, and userspace can access > it using libsensors and/or the "sensors" command. So these reported values seem to generate some interest. Adding Akinobu Mita who also planned to wire them up to the thermal framework. I don't really know either upper layer so I'm not sure which is the right one, but with this just like with the previous series I am quite worried that we add a lot of kernel boilerplate code for information people can trivially get using nvme-cli. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B760ACA9EA0 for ; Mon, 28 Oct 2019 07:40:11 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8C634214E0 for ; Mon, 28 Oct 2019 07:40:11 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="UZbqAU6p" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8C634214E0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=lst.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4qHCHOQu3921nLWBH9pJvdUH2DVa3eJ3kwz9GYO8SR0=; b=UZbqAU6pGrzyu6 z9GS1CPh+LpwbMu8RCIZRavB2+snb1jpo8qf6Bfgmrk1x4m+KP9q4RT9uQeyhByMI9ub9iKZODDa1 153EAmuL40mBMhZtksOoii2Tr5Z/w5NLkHki7j9eg3vmBDu/SZ5nDI8cg5btRCs3nKrQ7uBst48sj 49kD7BDkf4p6lBiUGP1OuRmFtKwTfpCSl2MAbSmDxSZwr63fpW+hDDn35Q+EqibkeVksE4+UnFXor 6Fh4Ri1xxAM1pjulSk7Q3f+89c33v6t5p62VkTdMg4ZNl4zkBonEG1bTA9SKdNmgrEmexr1lw7kTv hmyPUFIsgWPZ2PilQscA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iOzd8-0006Zy-Ko; Mon, 28 Oct 2019 07:39:58 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iOzd6-0006ZO-1F for linux-nvme@lists.infradead.org; Mon, 28 Oct 2019 07:39:57 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 480AA68C65; Mon, 28 Oct 2019 08:39:53 +0100 (CET) Date: Mon, 28 Oct 2019 08:39:53 +0100 From: Christoph Hellwig To: Guenter Roeck Subject: Re: [PATCH] nvme: Add hardware monitoring support Message-ID: <20191028073953.GA20443@lst.de> References: <20191028024156.23964-1-linux@roeck-us.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20191028024156.23964-1-linux@roeck-us.net> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191028_003956_220611_AD22C842 X-CRM114-Status: GOOD ( 14.38 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagi Grimberg , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Akinobu Mita , Jens Axboe , Chris Healy , Keith Busch , Christoph Hellwig Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Sun, Oct 27, 2019 at 07:41:56PM -0700, Guenter Roeck wrote: > nvme devices report temperature information in the controller information > (for limits) and in the smart log. Currently, the only means to retrieve > this information is the nvme command line interface, which requires > super-user privileges. > > At the same time, it would be desirable to use NVME temperature information > for thermal control. > > This patch adds support to read NVME temperatures from the kernel using the > hwmon API and adds temperature zones for NVME drives. The thermal subsystem > can use this information to set thermal policies, and userspace can access > it using libsensors and/or the "sensors" command. So these reported values seem to generate some interest. Adding Akinobu Mita who also planned to wire them up to the thermal framework. I don't really know either upper layer so I'm not sure which is the right one, but with this just like with the previous series I am quite worried that we add a lot of kernel boilerplate code for information people can trivially get using nvme-cli. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme