From: Rain Wang <Rain_Wang@Jabil.com>
To: Jean Delvare <jdelvare@suse.de>
Cc: Guenter Roeck <linux@roeck-us.net>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-hwmon@vger.kernel.org" <linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH] lm75: add lm75b detection
Date: Mon, 28 Oct 2019 11:37:24 +0000 [thread overview]
Message-ID: <20191028113717.GB10006@rainw-fedora28-jabil.corp.jabil.org> (raw)
> Please send hwmon-related patches to the linux-hwmon list.
Sure, will do in future.
> I'm positively certain I don't want this. Ideally there should be no
> detection at all for device without ID registers. The only reason there
> are some occurrences of that is because there were no way to explicitly
> instantiate I2C devices back then, and we have left the detection in
> place to avoid perceived regressions. But today there are plenty of
> ways to explicitly instantiate your I2C devices so there are no excuses
> for more crappy detect functions. Ideally we would even get rid of
> existing ones at some point in the future.
I understand the concern, but there could be scenarios device tree doesn't
apply while some dynamic detection is still a valid requirement, not sure
maybe I'm wrong from beginning.
> This patch is bad anyway as it only changes the device name without
> implementing proper support for the LM75B.
This is only change we made just have our Intel C1516 board with LM75B sensor
working anyway, while majority common features of LM75 just work.
Regards
Rain
next reply other threads:[~2019-10-28 11:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 11:37 Rain Wang [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-10-28 11:28 [PATCH] lm75: add lm75b detection Rain Wang
2019-10-26 8:10 Rain Wang
2019-10-27 23:03 ` Guenter Roeck
2019-10-28 9:46 ` Jean Delvare
2019-10-29 14:02 ` Guenter Roeck
2019-11-07 6:18 ` Rain Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191028113717.GB10006@rainw-fedora28-jabil.corp.jabil.org \
--to=rain_wang@jabil.com \
--cc=jdelvare@suse.de \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.