From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1iP3C2-00013u-9P for mharc-grub-devel@gnu.org; Mon, 28 Oct 2019 07:28:15 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45866) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iP3Bv-00010W-Ay for grub-devel@gnu.org; Mon, 28 Oct 2019 07:28:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iP3Bu-0007nZ-6B for grub-devel@gnu.org; Mon, 28 Oct 2019 07:28:07 -0400 Received: from mail-wm1-x331.google.com ([2a00:1450:4864:20::331]:32828) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iP3Bs-0007n7-FU for grub-devel@gnu.org; Mon, 28 Oct 2019 07:28:06 -0400 Received: by mail-wm1-x331.google.com with SMTP id 6so9337281wmf.0 for ; Mon, 28 Oct 2019 04:28:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version; bh=FUOkUY69v94yW+6V/4UMi0AQd5dcnfsS10TZHkJ9AH0=; b=R68fy0ZWXKw0+QnuYy/iTdyRMNkJHJFwPtCNGv5cQPpeP9wvFihOftks4nA3wnfl9U uNgfl5K7FBL21WagyVlmVFTRBXHANKrvtyekK5M6Ei5/hxWbi3MTbIOQWyPd9bPBEp9V mxuSW4MUK67xREhIbZjmggq2cS6bYsqP10uK3hJcSEm/YJ36RB/kwu70NO4Anurv/dtJ zw575oqssJ7ImHScDpzYMGh5cB6Mr8f5XdnN/SmtsM1+gu7N6cJVqPv0aaHWKZCdFnyv JZR5iFa927K/x9NHyZGI4IoYnfwl6PBeWA/G4Xc6ahQpLodA651Xp4GSSC2eF9Cyddfg bCmw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version; bh=FUOkUY69v94yW+6V/4UMi0AQd5dcnfsS10TZHkJ9AH0=; b=ksDzbCyBEOsI1aGPFXeXBm16Y0/LvtM1LfRl9B4sLLFfvThuiobvytS2DULJ3OO4S0 fNQICDo+RErC38ujuj7bA3eeFEGLR2+mQUxqrUiU+CQLSVaekzbBmICozEtpj5TK+DZ3 SZsQ1QBFlDvAcaEJM7NgC9l71jkS3SzfSfTIt9vFprZYyDCLOjKVcG6Bc0w2R79ryxrm C4JqIWGy4J3VWqj3fVDcTsCL1R+2bFUJdKNOZJuylECTSwGkrKz4mQegm3jSXMDvPTND LOSMPVS47+MuA58H4THSrMufG5olZaord8GmNPlt45/Zn7SvIotSSjvNnkUyLHDETG5I bDFA== X-Gm-Message-State: APjAAAXeJ2ISInw8rQYnVfzGn8WFrhl4szT7whipY+vHJGPSwlKBmlhq RlIdJk3DLy2XLAeltPEoFHE= X-Google-Smtp-Source: APXvYqzFlBKGTmaI+OO7HEgxz87Dp2ykF5gX+G0OOXXGwGpCaEOQdQ6n9BSGEpaeLsr/Qc9D6peoig== X-Received: by 2002:a7b:c01a:: with SMTP id c26mr13603770wmb.45.1572262082484; Mon, 28 Oct 2019 04:28:02 -0700 (PDT) Received: from localhost (115.201.218.87.dynamic.jazztel.es. [87.218.201.115]) by smtp.gmail.com with ESMTPSA id u1sm15087290wru.90.2019.10.28.04.28.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Oct 2019 04:28:02 -0700 (PDT) Date: Mon, 28 Oct 2019 12:27:43 +0100 From: Miguel Arruga Vivas To: grub-devel@gnu.org Cc: Daniel Kiper Subject: [PATCH] install: Free allocated path for grub.efi. Message-ID: <20191028122743.098fcb72@gmail.com> In-Reply-To: <20191028122531.188744b3@gmail.com> References: <20191021163021.1a3ca543@gmail.com> <20191023090907.6sfuq6ne5mipdc5r@tomti.i.net-space.pl> <20191028122531.188744b3@gmail.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="MP_/raiLu7tnNJHl1G33+Uy+c9+" X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::331 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 28 Oct 2019 11:28:10 -0000 --MP_/raiLu7tnNJHl1G33+Uy+c9+ Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Content-Disposition: inline Hi, This patch is a minor issue, but in terms of correctness I think this free is missing. Happy hacking, Miguel --MP_/raiLu7tnNJHl1G33+Uy+c9+ Content-Type: text/x-patch Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=0001-install-Free-allocated-path-for-grub.efi.patch >From 1720e89de777fd3a30a6824797d97855b7bb8b68 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Miguel=20=C3=81ngel=20Arruga=20Vivas?= Date: Mon, 28 Oct 2019 10:08:25 +0100 Subject: [PATCH 1/2] install: Free allocated path for grub.efi. * util/grub-install.c (main): Free local variable allocated with grub_util_path_concat. --- util/grub-install.c | 1 + 1 file changed, 1 insertion(+) diff --git a/util/grub-install.c b/util/grub-install.c index 8970b73aa..8f84bf8cd 100644 --- a/util/grub-install.c +++ b/util/grub-install.c @@ -1664,6 +1664,7 @@ main (int argc, char *argv[]) /* memdisk */ NULL, have_load_cfg ? load_cfg : NULL, /* image target */ mkimage_target, 0); + free (dst); } break; case GRUB_INSTALL_PLATFORM_ARM_EFI: -- 2.23.0 --MP_/raiLu7tnNJHl1G33+Uy+c9+--