All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Kiper <dkiper@net-space.pl>
To: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>,
	mjg59@google.com
Cc: Mathieu Trudel-Lapierre <mathieu.tl@gmail.com>,
	The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: [PATCH] tpm: Pass unknown error as non-fatal, but debug print the error we got
Date: Mon, 28 Oct 2019 17:53:07 +0100	[thread overview]
Message-ID: <20191028165307.4xjdg2kvfmagfee6@tomti.i.net-space.pl> (raw)
In-Reply-To: <CAF_rnBTmaYMpAK9SfRvv1t+HwpRznuctjKUK=34a3vJJZcQ3xQ@mail.gmail.com>

Adding Matthew...

Matthew, whole thread is at [1].

Daniel

[1] https://lists.gnu.org/archive/html/grub-devel/2019-10/msg00103.html

On Fri, Oct 25, 2019 at 10:48:43AM -0400, Mathieu Trudel-Lapierre wrote:
> On Fri, Oct 25, 2019 at 10:28 AM Mathieu Trudel-Lapierre
> <mathieu.tl@gmail.com> wrote:
> >
> > Signed-off-by: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
> > Patch-Name: ubuntu-tpm-unknown-error-non-fatal.patch
> > ---
> >  grub-core/commands/efi/tpm.c | 12 ++++++++----
> >  1 file changed, 8 insertions(+), 4 deletions(-)
> >
>
> I see I omitted to explain why I'm proposing this.
>
> I've seen a couple of reports so far of issues with booting with TPM
> measurement enabled, when the firmware has TPM enabled, on some
> hardware.
>
> In particular, this has happened on a Dell laptop at Plumbers this
> year (an older model XPS15 IIRC), and a few different models of
> laptops/motherboards. Some report having a TPM, and some do not:
>
> HP EliteBook 820 G4 (Infineon SLB9670?)
> ASUS M32CD4-K motherboard (unknown)
> ASUS ROG GL553VE Laptop (unknown)
> ASUS ZenBook 3 UX390UA (unknown)
> ASUS Zenbook UX305FA (unspecified TPM)
> ASUS ZenBook UX303UA (unknown)
> ASUS 2O7HSV6 ??
>
> See https://bugs.launchpad.net/ubuntu/+source/grub2/+bug/1848892.
>
> Unfortunately the reports are not of great quality, but I'm starting
> to worry about what exactly is wrong, if it's really a firmware / TPM
> issue or a bug in the TPM code.
>
> For now, it seems like the best is to get more information as to what
> exactly the failure is (hence grub_dprintf()), and treating these
> errors as non-fatal so people can still boot.
>
> After briefly discussing this with others, it's not clear whether all
> the affected systems really do have a TPM, but they might still report
> in firmware that they do. Are we running into a case where the
> firmware wrongly reports there is a TPM, but fails to do any
> measurements?
>
> Kindly,
>
> --
>
> Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonical.com>
> Freenode: cyphermox, Jabber: mathieu.tl@gmail.com
> 4096R/65B58DA1 818A D123 0992 275B 23C2  CF89 C67B B4D6 65B5 8DA1


      parent reply	other threads:[~2019-10-28 16:53 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-25 14:27 [PATCH] tpm: Pass unknown error as non-fatal, but debug print the error we got Mathieu Trudel-Lapierre
2019-10-25 14:48 ` Mathieu Trudel-Lapierre
2019-10-25 17:36   ` Javier Martinez Canillas
2019-10-29 10:49     ` Max Tottenham
2019-10-29 12:12       ` Javier Martinez Canillas
2019-11-06 11:37         ` Daniel Kiper
2019-11-06 14:04           ` Max Tottenham
2019-10-28 16:53   ` Daniel Kiper [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191028165307.4xjdg2kvfmagfee6@tomti.i.net-space.pl \
    --to=dkiper@net-space.pl \
    --cc=grub-devel@gnu.org \
    --cc=mathieu.tl@gmail.com \
    --cc=mathieu.trudel-lapierre@canonical.com \
    --cc=mjg59@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.