All of lore.kernel.org
 help / color / mirror / Atom feed
From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.01.org
Subject: [PATCH 2/3] auto-t: fix random failures in testEAP-MSCHAPV2
Date: Mon, 28 Oct 2019 12:52:00 -0700	[thread overview]
Message-ID: <20191028195201.21904-2-prestwoj@gmail.com> (raw)
In-Reply-To: <20191028195201.21904-1-prestwoj@gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1289 bytes --]

Its difficult to know 100%, but this random test failures appeared
to be caused by two issues. One was that get_ordered_network is being
checked for None, when it was returning a zero length array. Because
of this the scanning block was never executed in any cases. This was
fixed in the previous commit. The other issue was the disconnect at
the start of the tests. The disconnect will cause all pending scans
to cancel, which appeared to cause the scanning block below to be
skipped over quickly if the timing was right. Then, afterwards,
getting a single network failed because scanning was not complete.
---
 autotests/testEAP-MSCHAPV2/connection_test.py | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/autotests/testEAP-MSCHAPV2/connection_test.py b/autotests/testEAP-MSCHAPV2/connection_test.py
index d38f4b09..35926375 100644
--- a/autotests/testEAP-MSCHAPV2/connection_test.py
+++ b/autotests/testEAP-MSCHAPV2/connection_test.py
@@ -19,11 +19,6 @@ class Test(unittest.TestCase):
         devices = wd.list_devices(1)
         device = devices[0]
 
-        try:
-            device.disconnect()
-        except:
-            pass
-
         condition = 'not obj.scanning'
         wd.wait_for_object_condition(device, condition)
 
-- 
2.17.1

  reply	other threads:[~2019-10-28 19:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 19:51 [PATCH 1/3] auto-t: return None with get_ordered_network(s) James Prestwood
2019-10-28 19:52 ` James Prestwood [this message]
2019-10-28 19:52 ` [PATCH 3/3] auto-t: update testEAP-TLS to use HostapdCLI James Prestwood
2019-10-28 20:01 ` [PATCH 1/3] auto-t: return None with get_ordered_network(s) Denis Kenzior

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191028195201.21904-2-prestwoj@gmail.com \
    --to=prestwoj@gmail.com \
    --cc=iwd@lists.01.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.