All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ye Xiaolong <xiaolong.ye@intel.com>
To: Qi Zhang <qi.z.zhang@intel.com>
Cc: Qiming.Yang@intel.com, dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] net/ice: fix unexpected link down
Date: Tue, 29 Oct 2019 13:35:04 +0800	[thread overview]
Message-ID: <20191029053504.GF12923@intel.com> (raw)
In-Reply-To: <20191029051649.25253-1-qi.z.zhang@intel.com>

Hi, Qi

On 10/29, Qi Zhang wrote:
>Not to turn down link during dev_stop, it will cause the device
>can't be bind by kernel driver after DPDK driver quit.
>
>Fixes: e6161345d8a9 ("net/ice: support link status change")
>Cc: stable@dpdk.org
>
>Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
>---
> drivers/net/ice/ice_ethdev.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c
>index d74675842..ae6eba63e 100644
>--- a/drivers/net/ice/ice_ethdev.c
>+++ b/drivers/net/ice/ice_ethdev.c
>@@ -2277,8 +2277,6 @@ ice_dev_stop(struct rte_eth_dev *dev)
> 	/* Clear all queues and release mbufs */
> 	ice_clear_queues(dev);
> 
>-	ice_dev_set_link_down(dev);
>-

Is this ice specific issue? Calling set_link_down seems correct thing to do in stop
ops, as we can see in other PMDs like i40e, mvneta, ... 

Thanks,
Xiaolong


> 	/* Clean datapath event and queue/vec mapping */
> 	rte_intr_efd_disable(intr_handle);
> 	if (intr_handle->intr_vec) {
>-- 
>2.13.6
>

  reply	other threads:[~2019-10-29  5:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29  5:16 [dpdk-dev] [PATCH] net/ice: fix unexpected link down Qi Zhang
2019-10-29  5:35 ` Ye Xiaolong [this message]
2019-10-31 21:52   ` Stillwell Jr, Paul M

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029053504.GF12923@intel.com \
    --to=xiaolong.ye@intel.com \
    --cc=Qiming.Yang@intel.com \
    --cc=dev@dpdk.org \
    --cc=qi.z.zhang@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.