All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tiwei Bie <tiwei.bie@intel.com>
To: Jin Yu <jin.yu@intel.com>
Cc: dev@dpdk.org, stable@dpdk.org
Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] vhost: fix compile error
Date: Tue, 29 Oct 2019 21:35:44 +0800	[thread overview]
Message-ID: <20191029133544.GA18351@___> (raw)
In-Reply-To: <20191028103443.42346-1-jin.yu@intel.com>

On Mon, Oct 28, 2019 at 06:34:43PM +0800, Jin Yu wrote:
> Compile librte_vhost/vhost_crypto.c needs the rte_hash.h
> So we need the librte_hash to be compiled before vhost.
> Add the DEPDIRs to make sure this.
> 
> Bugzilla ID: 356
> Cc: stable@dpdk.org

Fixes: 939066d96563 ("vhost/crypto: add public function implementation")

> 
> Signed-off-by: Jin Yu <jin.yu@intel.com>
> ---
>  lib/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/Makefile b/lib/Makefile
> index 41c463d92..a30accb29 100644
> --- a/lib/Makefile
> +++ b/lib/Makefile
> @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev
>  DEPDIRS-librte_rawdev := librte_eal librte_ethdev
>  DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost
>  DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \
> -			librte_net
> +			librte_net librte_hash

Do we also depend on cryptodev (rte_cryptodev.h)?


>  DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash
>  DEPDIRS-librte_hash := librte_eal librte_ring
>  DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd
> -- 
> 2.17.2
> 

  reply	other threads:[~2019-10-29 13:34 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-28 10:34 [dpdk-dev] [PATCH] vhost: fix compile error Jin Yu
2019-10-29 13:35 ` Tiwei Bie [this message]
2019-10-30  1:41   ` [dpdk-dev] [dpdk-stable] " Yu, Jin
2019-10-30  9:37 ` [dpdk-dev] " Jin Yu
2019-10-30  9:40 ` [dpdk-dev] [PATCH v2] " Jin Yu
2019-11-04  4:41   ` Tiwei Bie
2019-11-06 19:52   ` Maxime Coquelin
2019-11-06 19:59   ` Maxime Coquelin
2019-11-06 20:05     ` [dpdk-dev] [dpdk-stable] " David Marchand
2019-11-06 20:30       ` Maxime Coquelin
2019-11-06 20:59   ` [dpdk-dev] " Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029133544.GA18351@___ \
    --to=tiwei.bie@intel.com \
    --cc=dev@dpdk.org \
    --cc=jin.yu@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.