From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 59E7ECA9EAE for ; Tue, 29 Oct 2019 13:34:58 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 1E41F20874 for ; Tue, 29 Oct 2019 13:34:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E41F20874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id ECCA41BEB8; Tue, 29 Oct 2019 14:34:56 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 23A971BE86; Tue, 29 Oct 2019 14:34:54 +0100 (CET) X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 29 Oct 2019 06:34:54 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,244,1569308400"; d="scan'208";a="230061226" Received: from dpdk-virtio-tbie-2.sh.intel.com (HELO ___) ([10.67.104.74]) by fmsmga002.fm.intel.com with ESMTP; 29 Oct 2019 06:34:53 -0700 Date: Tue, 29 Oct 2019 21:35:44 +0800 From: Tiwei Bie To: Jin Yu Cc: dev@dpdk.org, stable@dpdk.org Message-ID: <20191029133544.GA18351@___> References: <20191028103443.42346-1-jin.yu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191028103443.42346-1-jin.yu@intel.com> User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] vhost: fix compile error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 28, 2019 at 06:34:43PM +0800, Jin Yu wrote: > Compile librte_vhost/vhost_crypto.c needs the rte_hash.h > So we need the librte_hash to be compiled before vhost. > Add the DEPDIRs to make sure this. > > Bugzilla ID: 356 > Cc: stable@dpdk.org Fixes: 939066d96563 ("vhost/crypto: add public function implementation") > > Signed-off-by: Jin Yu > --- > lib/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/Makefile b/lib/Makefile > index 41c463d92..a30accb29 100644 > --- a/lib/Makefile > +++ b/lib/Makefile > @@ -46,7 +46,7 @@ DIRS-$(CONFIG_RTE_LIBRTE_RAWDEV) += librte_rawdev > DEPDIRS-librte_rawdev := librte_eal librte_ethdev > DIRS-$(CONFIG_RTE_LIBRTE_VHOST) += librte_vhost > DEPDIRS-librte_vhost := librte_eal librte_mempool librte_mbuf librte_ethdev \ > - librte_net > + librte_net librte_hash Do we also depend on cryptodev (rte_cryptodev.h)? > DIRS-$(CONFIG_RTE_LIBRTE_HASH) += librte_hash > DEPDIRS-librte_hash := librte_eal librte_ring > DIRS-$(CONFIG_RTE_LIBRTE_EFD) += librte_efd > -- > 2.17.2 >