From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0A73CA9EAE for ; Tue, 29 Oct 2019 16:09:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B4C121479 for ; Tue, 29 Oct 2019 16:09:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390350AbfJ2QJc (ORCPT ); Tue, 29 Oct 2019 12:09:32 -0400 Received: from Chamillionaire.breakpoint.cc ([193.142.43.52]:59234 "EHLO Chamillionaire.breakpoint.cc" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390200AbfJ2QJc (ORCPT ); Tue, 29 Oct 2019 12:09:32 -0400 Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1iPU3f-0006Vk-M6; Tue, 29 Oct 2019 17:09:23 +0100 Date: Tue, 29 Oct 2019 17:09:23 +0100 From: Florian Westphal To: Praveen Chaudhary Cc: davem@davemloft.net, fw@strlen.de, kadlec@netfilter.org, pablo@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Zhenggen Xu , Andy Stracner Subject: Re: [PATCH] [netfilter]: Fix skb->csum calculation when netfilter manipulation for NF_NAT_MANIP_SRC\DST is done on IPV6 packet. Message-ID: <20191029160923.GB876@breakpoint.cc> References: <1572301675-5403-1-git-send-email-pchaudhary@linkedin.com> <1572301675-5403-2-git-send-email-pchaudhary@linkedin.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1572301675-5403-2-git-send-email-pchaudhary@linkedin.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Praveen Chaudhary wrote: > No need to update skb->csum in function inet_proto_csum_replace16(), > even if skb->ip_summed == CHECKSUM_COMPLETE, because change in L4 > header checksum field and change in IPV6 header cancels each other > for skb->csum calculation. Can you resend this and submit this patch to netfilter-devel@vger.kernel.org? You may add: Reviewed-by: Florian Westphal