All of lore.kernel.org
 help / color / mirror / Atom feed
From: <vattunuru@marvell.com>
To: <dev@dpdk.org>
Cc: <thomas@monjalon.net>, <jerinj@marvell.com>, <hkalra@marvell.com>,
	"Vamsi Attunuru" <vattunuru@marvell.com>
Subject: [dpdk-dev] [PATCH v1 1/1] net/octeontx2: skip flow control on lbk ports
Date: Tue, 29 Oct 2019 23:33:57 +0530	[thread overview]
Message-ID: <20191029180357.16986-1-vattunuru@marvell.com> (raw)

From: Vamsi Attunuru <vattunuru@marvell.com>

LBK interface does not support any flow control related
HW configurations.

Skip flow control set requests on LBK bound ethports.

Signed-off-by: Harman Kalra <hkalra@marvell.com>
Signed-off-by: Vamsi Attunuru <vattunuru@marvell.com>
---
 drivers/net/octeontx2/otx2_flow_ctrl.c | 13 +++++++++++++
 1 file changed, 13 insertions(+)

diff --git a/drivers/net/octeontx2/otx2_flow_ctrl.c b/drivers/net/octeontx2/otx2_flow_ctrl.c
index 1d00e46..9360e8b 100644
--- a/drivers/net/octeontx2/otx2_flow_ctrl.c
+++ b/drivers/net/octeontx2/otx2_flow_ctrl.c
@@ -50,6 +50,11 @@ otx2_nix_flow_ctrl_get(struct rte_eth_dev *eth_dev,
 	struct otx2_mbox *mbox = dev->mbox;
 	int rc;
 
+	if (otx2_dev_is_lbk(dev)) {
+		fc_conf->mode = RTE_FC_NONE;
+		return 0;
+	}
+
 	req = otx2_mbox_alloc_msg_cgx_cfg_pause_frm(mbox);
 	req->set = 0;
 
@@ -137,6 +142,11 @@ otx2_nix_flow_ctrl_set(struct rte_eth_dev *eth_dev,
 	uint8_t tx_pause, rx_pause;
 	int rc = 0;
 
+	if (otx2_dev_is_lbk(dev)) {
+		otx2_err("No flow control support for LBK bound ethports");
+		return -ENOTSUP;
+	}
+
 	if (fc_conf->high_water || fc_conf->low_water || fc_conf->pause_time ||
 	    fc_conf->mac_ctrl_frame_fwd || fc_conf->autoneg) {
 		otx2_info("Flowctrl parameter is not supported");
@@ -189,6 +199,9 @@ otx2_nix_update_flow_ctrl_mode(struct rte_eth_dev *eth_dev)
 	struct otx2_eth_dev *dev = otx2_eth_pmd_priv(eth_dev);
 	struct rte_eth_fc_conf fc_conf;
 
+	if (otx2_dev_is_lbk(dev))
+		return 0;
+
 	memset(&fc_conf, 0, sizeof(struct rte_eth_fc_conf));
 	/* Both Rx & Tx flow ctrl get enabled(RTE_FC_FULL) in HW
 	 * by AF driver, update those info in PMD structure.
-- 
2.8.4


             reply	other threads:[~2019-10-29 18:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-10-29 18:03 vattunuru [this message]
2019-10-30  5:54 ` [dpdk-dev] [PATCH v2 1/1] net/octeontx2: skip flow control on lbk ports vattunuru
2019-10-30 16:25   ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191029180357.16986-1-vattunuru@marvell.com \
    --to=vattunuru@marvell.com \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=jerinj@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.