* [PATCH] net: qrtr: Simplify 'qrtr_tun_release()'
@ 2019-10-30 6:36 ` Christophe JAILLET
0 siblings, 0 replies; 4+ messages in thread
From: Christophe JAILLET @ 2019-10-30 6:36 UTC (permalink / raw)
To: davem, navid.emamdoost
Cc: netdev, linux-kernel, kernel-janitors, Christophe JAILLET
Use 'skb_queue_purge()' instead of re-implementing it.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
net/qrtr/tun.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/net/qrtr/tun.c b/net/qrtr/tun.c
index e35869e81766..15ce9b642b25 100644
--- a/net/qrtr/tun.c
+++ b/net/qrtr/tun.c
@@ -111,15 +111,11 @@ static __poll_t qrtr_tun_poll(struct file *filp, poll_table *wait)
static int qrtr_tun_release(struct inode *inode, struct file *filp)
{
struct qrtr_tun *tun = filp->private_data;
- struct sk_buff *skb;
qrtr_endpoint_unregister(&tun->ep);
/* Discard all SKBs */
- while (!skb_queue_empty(&tun->queue)) {
- skb = skb_dequeue(&tun->queue);
- kfree_skb(skb);
- }
+ skb_queue_purge(&tun->queue);
kfree(tun);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] net: qrtr: Simplify 'qrtr_tun_release()'
@ 2019-10-30 6:36 ` Christophe JAILLET
0 siblings, 0 replies; 4+ messages in thread
From: Christophe JAILLET @ 2019-10-30 6:36 UTC (permalink / raw)
To: davem, navid.emamdoost
Cc: netdev, linux-kernel, kernel-janitors, Christophe JAILLET
Use 'skb_queue_purge()' instead of re-implementing it.
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
---
net/qrtr/tun.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/net/qrtr/tun.c b/net/qrtr/tun.c
index e35869e81766..15ce9b642b25 100644
--- a/net/qrtr/tun.c
+++ b/net/qrtr/tun.c
@@ -111,15 +111,11 @@ static __poll_t qrtr_tun_poll(struct file *filp, poll_table *wait)
static int qrtr_tun_release(struct inode *inode, struct file *filp)
{
struct qrtr_tun *tun = filp->private_data;
- struct sk_buff *skb;
qrtr_endpoint_unregister(&tun->ep);
/* Discard all SKBs */
- while (!skb_queue_empty(&tun->queue)) {
- skb = skb_dequeue(&tun->queue);
- kfree_skb(skb);
- }
+ skb_queue_purge(&tun->queue);
kfree(tun);
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] net: qrtr: Simplify 'qrtr_tun_release()'
2019-10-30 6:36 ` Christophe JAILLET
@ 2019-10-31 0:58 ` David Miller
-1 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-10-31 0:58 UTC (permalink / raw)
To: christophe.jaillet; +Cc: navid.emamdoost, netdev, linux-kernel, kernel-janitors
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Wed, 30 Oct 2019 07:36:40 +0100
> Use 'skb_queue_purge()' instead of re-implementing it.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] net: qrtr: Simplify 'qrtr_tun_release()'
@ 2019-10-31 0:58 ` David Miller
0 siblings, 0 replies; 4+ messages in thread
From: David Miller @ 2019-10-31 0:58 UTC (permalink / raw)
To: christophe.jaillet; +Cc: navid.emamdoost, netdev, linux-kernel, kernel-janitors
From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date: Wed, 30 Oct 2019 07:36:40 +0100
> Use 'skb_queue_purge()' instead of re-implementing it.
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Applied.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-10-31 0:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-30 6:36 [PATCH] net: qrtr: Simplify 'qrtr_tun_release()' Christophe JAILLET
2019-10-30 6:36 ` Christophe JAILLET
2019-10-31 0:58 ` David Miller
2019-10-31 0:58 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.