From: Lai Jiangshan <laijs@linux.alibaba.com>
To: linux-kernel@vger.kernel.org
Cc: Lai Jiangshan <laijs@linux.alibaba.com>,
"Paul E. McKenney" <paulmck@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Joel Fernandes <joel@joelfernandes.org>,
rcu@vger.kernel.org
Subject: [PATCH 06/11] rcu: clear t->rcu_read_unlock_special in one go
Date: Thu, 31 Oct 2019 10:08:01 +0000 [thread overview]
Message-ID: <20191031100806.1326-7-laijs@linux.alibaba.com> (raw)
In-Reply-To: <20191031100806.1326-1-laijs@linux.alibaba.com>
Clearing t->rcu_read_unlock_special in one go makes the code
more clearly.
Signed-off-by: Lai Jiangshan <laijs@linux.alibaba.com>
---
kernel/rcu/tree_plugin.h | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index bb3bcdb5c9b8..e612c77dc446 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -420,6 +420,7 @@ static bool rcu_preempt_has_tasks(struct rcu_node *rnp)
* Report deferred quiescent states. The deferral time can
* be quite short, for example, in the case of the call from
* rcu_read_unlock_special().
+ * t->rcu_read_unlock_special is cleared after called.
*/
static void
rcu_preempt_deferred_qs_irqrestore(struct task_struct *t, unsigned long flags)
@@ -439,11 +440,9 @@ rcu_preempt_deferred_qs_irqrestore(struct task_struct *t, unsigned long flags)
* t->rcu_read_unlock_special cannot change.
*/
special = t->rcu_read_unlock_special;
- t->rcu_read_unlock_special.b.exp_hint = false;
- t->rcu_read_unlock_special.b.deferred_qs = false;
+ t->rcu_read_unlock_special.s = 0;
if (special.b.need_qs) {
rcu_qs();
- t->rcu_read_unlock_special.b.need_qs = false;
}
/*
@@ -459,8 +458,6 @@ rcu_preempt_deferred_qs_irqrestore(struct task_struct *t, unsigned long flags)
/* Clean up if blocked during RCU read-side critical section. */
if (special.b.blocked) {
- t->rcu_read_unlock_special.b.blocked = false;
-
/*
* Remove this task from the list it blocked on. The task
* now remains queued on the rcu_node corresponding to the
--
2.20.1
next prev parent reply other threads:[~2019-10-31 10:09 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 10:07 [PATCH 00/11] rcu: introduce percpu rcu_preempt_depth Lai Jiangshan
2019-10-31 10:07 ` [PATCH 01/11] rcu: avoid leaking exp_deferred_qs into next GP Lai Jiangshan
2019-10-31 13:43 ` Paul E. McKenney
2019-10-31 18:19 ` Lai Jiangshan
2019-10-31 19:00 ` Paul E. McKenney
2019-10-31 10:07 ` [PATCH 02/11] rcu: fix bug when rcu_exp_handler() in nested interrupt Lai Jiangshan
2019-10-31 13:47 ` Paul E. McKenney
2019-10-31 14:20 ` Lai Jiangshan
2019-10-31 14:31 ` Paul E. McKenney
2019-10-31 15:14 ` Lai Jiangshan
2019-10-31 18:52 ` Paul E. McKenney
2019-11-01 0:19 ` Boqun Feng
2019-11-01 2:29 ` Lai Jiangshan
2019-10-31 10:07 ` [PATCH 03/11] rcu: clean up rcu_preempt_deferred_qs_irqrestore() Lai Jiangshan
2019-10-31 13:52 ` Paul E. McKenney
2019-10-31 15:25 ` Lai Jiangshan
2019-10-31 18:57 ` Paul E. McKenney
2019-10-31 19:02 ` Paul E. McKenney
2019-10-31 10:07 ` [PATCH 04/11] rcu: cleanup rcu_preempt_deferred_qs() Lai Jiangshan
2019-10-31 14:10 ` Paul E. McKenney
2019-10-31 14:35 ` Lai Jiangshan
2019-10-31 15:07 ` Paul E. McKenney
2019-10-31 18:33 ` Lai Jiangshan
2019-10-31 22:45 ` Paul E. McKenney
2019-10-31 10:08 ` [PATCH 05/11] rcu: clean all rcu_read_unlock_special after report qs Lai Jiangshan
2019-11-01 11:54 ` Paul E. McKenney
2019-10-31 10:08 ` Lai Jiangshan [this message]
2019-11-01 12:10 ` [PATCH 06/11] rcu: clear t->rcu_read_unlock_special in one go Paul E. McKenney
2019-11-01 16:58 ` Paul E. McKenney
2019-10-31 10:08 ` [PATCH 07/11] rcu: set special.b.deferred_qs before wake_up() Lai Jiangshan
2019-10-31 10:08 ` [PATCH 08/11] rcu: don't use negative ->rcu_read_lock_nesting Lai Jiangshan
2019-11-01 12:33 ` Paul E. McKenney
2019-11-16 13:04 ` Lai Jiangshan
2019-11-17 21:53 ` Paul E. McKenney
2019-11-18 1:54 ` Lai Jiangshan
2019-11-18 14:57 ` Paul E. McKenney
2019-10-31 10:08 ` [PATCH 09/11] rcu: wrap usages of rcu_read_lock_nesting Lai Jiangshan
2019-10-31 10:08 ` [PATCH 10/11] rcu: clear the special.b.need_qs in rcu_note_context_switch() Lai Jiangshan
2019-10-31 10:08 ` [PATCH 11/11] x86,rcu: use percpu rcu_preempt_depth Lai Jiangshan
2019-11-01 12:58 ` Paul E. McKenney
2019-11-01 13:13 ` Peter Zijlstra
2019-11-01 14:30 ` Paul E. McKenney
2019-11-01 15:32 ` Lai Jiangshan
2019-11-01 16:21 ` Paul E. McKenney
2019-11-01 16:21 ` Paul E. McKenney
2019-11-01 15:47 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031100806.1326-7-laijs@linux.alibaba.com \
--to=laijs@linux.alibaba.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.